Received: by 10.192.165.148 with SMTP id m20csp4146648imm; Mon, 30 Apr 2018 12:38:11 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrvRgJftZVHUUrvVjAwsgDripuaej+KcEDe36gmvHt1WLFftxMxmthRT6XN0gVQHksCgV/5 X-Received: by 10.98.60.16 with SMTP id j16mr13132070pfa.7.1525117091343; Mon, 30 Apr 2018 12:38:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525117091; cv=none; d=google.com; s=arc-20160816; b=umgD3JJPq56IEwCzvRZKq4phayx64R8NLqbLLIzZxeUJVMM5inNZ+vtEfvvLaapXgZ Ae5qpmBNSR5TBnKepoKNowPazry2PH8kmamNUDya9m72i3R0fPk+6olPjY3m30aabnoL rNVn3ZPoV2d/bKj0CR2LP/3WrulCEYwQ5G47ZQJ1G7F69oMo1dGCYaqJHc0Eh0imK/F2 oFsAcjBx6XluHOHxBYuIVqq8Rw8Jh9oJKVhHk8ZRAOPCqqWEMmAJ8VdCBZrA0mPDFdeo +RPC0Ke2dT9SHu+vg2MEu2q1kbacFOB8VZictinFpFHNqI8sLfRmWI1+8TbK/eIiJxEW j9Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dmarc-filter :arc-authentication-results; bh=1qEeDy2e5ChIQpRC3i6vcidxMREGtY14WuqOhN8r2mg=; b=IrJQF8HvIqoz8oNPtkIbNPvVXLGQiSKp5awdkE8zUgNoUtswHW14F64lyqnpdA0gcZ WJb76fVW8QSuYnsSqxzxVlLaINzfkg2i/idbOhdanmbL8Pdkxm7gyrqxHBan4eNCjoUx q3I2GMQvixN4O7VGS859nH9JeWjFMuqjjy9hBlU7TDxJn0IG4NLB7Ya9gcLQf+Carud9 FgLsbSvPLsEMiT3UlSkwcWbw5OewcPlfc1N4b1FxPSGKsvFy+u56oSgRDcjHc0wJ4dyz gRyBOTe5AFg/HWrYyUbYlTzpFMfnixZZA0KVhbD2jqPC2uvVeODOsREAuvfZ6UHJIDmx AwpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 60-v6si7858362plc.453.2018.04.30.12.37.57; Mon, 30 Apr 2018 12:38:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755773AbeD3Thk (ORCPT + 99 others); Mon, 30 Apr 2018 15:37:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:36668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755340AbeD3T2m (ORCPT ); Mon, 30 Apr 2018 15:28:42 -0400 Received: from localhost (unknown [104.132.1.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69FB922DAC; Mon, 30 Apr 2018 19:28:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69FB922DAC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=fail smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede Subject: [PATCH 4.16 090/113] virt: vbox: Move declarations of vboxguest private functions to private header Date: Mon, 30 Apr 2018 12:25:01 -0700 Message-Id: <20180430184019.004128899@linuxfoundation.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180430184015.043892819@linuxfoundation.org> References: <20180430184015.043892819@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.16-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit 02cfde67df1f440c7c3c7038cc97992afb81804f upstream. Move the declarations of functions from vboxguest_utils.c which are only meant for vboxguest internal use from include/linux/vbox_utils.h to drivers/virt/vboxguest/vboxguest_core.h. Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Signed-off-by: Greg Kroah-Hartman --- drivers/virt/vboxguest/vboxguest_core.h | 8 ++++++++ include/linux/vbox_utils.h | 23 ----------------------- 2 files changed, 8 insertions(+), 23 deletions(-) --- a/drivers/virt/vboxguest/vboxguest_core.h +++ b/drivers/virt/vboxguest/vboxguest_core.h @@ -171,4 +171,12 @@ irqreturn_t vbg_core_isr(int irq, void * void vbg_linux_mouse_event(struct vbg_dev *gdev); +/* Private (non exported) functions form vboxguest_utils.c */ +void *vbg_req_alloc(size_t len, enum vmmdev_request_type req_type); +int vbg_req_perform(struct vbg_dev *gdev, void *req); +int vbg_hgcm_call32( + struct vbg_dev *gdev, u32 client_id, u32 function, u32 timeout_ms, + struct vmmdev_hgcm_function_parameter32 *parm32, u32 parm_count, + int *vbox_status); + #endif --- a/include/linux/vbox_utils.h +++ b/include/linux/vbox_utils.h @@ -24,24 +24,6 @@ __printf(1, 2) void vbg_debug(const char #define vbg_debug pr_debug #endif -/** - * Allocate memory for generic request and initialize the request header. - * - * Return: the allocated memory - * @len: Size of memory block required for the request. - * @req_type: The generic request type. - */ -void *vbg_req_alloc(size_t len, enum vmmdev_request_type req_type); - -/** - * Perform a generic request. - * - * Return: VBox status code - * @gdev: The Guest extension device. - * @req: Pointer to the request structure. - */ -int vbg_req_perform(struct vbg_dev *gdev, void *req); - int vbg_hgcm_connect(struct vbg_dev *gdev, struct vmmdev_hgcm_service_location *loc, u32 *client_id, int *vbox_status); @@ -52,11 +34,6 @@ int vbg_hgcm_call(struct vbg_dev *gdev, u32 timeout_ms, struct vmmdev_hgcm_function_parameter *parms, u32 parm_count, int *vbox_status); -int vbg_hgcm_call32( - struct vbg_dev *gdev, u32 client_id, u32 function, u32 timeout_ms, - struct vmmdev_hgcm_function_parameter32 *parm32, u32 parm_count, - int *vbox_status); - /** * Convert a VirtualBox status code to a standard Linux kernel return value. * Return: 0 or negative errno value.