Received: by 10.192.165.148 with SMTP id m20csp4173390imm; Mon, 30 Apr 2018 13:10:32 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoHSOxDrlXwJSmi9yYbDadCY9N7CUC0Lyaqxrpox92g3IgZF7HS83Ff5GdCOwJG5TxT+QY0 X-Received: by 2002:a65:40c9:: with SMTP id u9-v6mr11199444pgp.142.1525119032776; Mon, 30 Apr 2018 13:10:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525119032; cv=none; d=google.com; s=arc-20160816; b=BkuWq6Ud72NCQrjnTwS7EPSY/w1xOi1GPmJoP+GpZzspCV8GCQ9lZy3LDy49/aUY0W 2Z9lFteNRxWF0f569Z68lxkddk+6cvdOTZB8CgfF/sUNTyOp4YKLQnhbMNCHtlhOEujr eNQ7kfTpCmXkUhBhN6IYoCeXLzNtpuupVFJRNwYTcAO8UHJo7FK3zVYOXX/rTJby+cqR eRIU+V6P3hugkNaEcy9qwxTqfwEfOl6bcL5ihH+VwWnBF2iLSmbbni0LolPq0rB6i4EN VETBfUWsNxhQTjiZPGO8hNsJWPgyZg04ME/YOqseT4rWht/ytVQT8jPQIs1dtLN1uDKB 0q5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=6ccVkOJ6wdWsyLUYHW9WL3/RebVeLqajuNWmp4qvVQk=; b=Cn+U1F82hPLSj3QosveBhK89YR2OSBAQyQeVqWinyeo9tzCFBpDIrOsExSjU2Ue0+N I3HSuhkLuRynj/fHYN6faq/9OwZwIjJRu2WNYe22yPCLwAbVlyJi1u9VZfj5HMdzmnc9 OmgIF1qep6auqG/rMXKgq8xmRa6VbejfxEm1jbMAgAHh0O+w5gCzhTMk/fBsqaTp9oQu 4kTI7RardizOmI3/hO1iyW6tIlMDwmVfXiN+s+T71HT+3aGpFAEupI+aIoF9CL7DOuQU LQLVnxU8QDRwYGdhov81nmXlna/1UhcCVQXb/of7bSCcVrjfIC7PHLoOBq2lnwF4vkpf kyOA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w127si7529663pfd.313.2018.04.30.13.10.18; Mon, 30 Apr 2018 13:10:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbeD3UKE (ORCPT + 99 others); Mon, 30 Apr 2018 16:10:04 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36220 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754555AbeD3UKB (ORCPT ); Mon, 30 Apr 2018 16:10:01 -0400 Received: from localhost (pool-173-77-163-54.nycmny.fios.verizon.net [173.77.163.54]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E010D13416B83; Mon, 30 Apr 2018 13:10:00 -0700 (PDT) Date: Mon, 30 Apr 2018 16:10:00 -0400 (EDT) Message-Id: <20180430.161000.699679324055043425.davem@davemloft.net> To: arvind.yadav.cs@gmail.com Cc: shannon.nelson@oracle.com, jag.raman@oracle.com, liam.merwick@oracle.com, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH] sparc: vio: use put_device() instead of kfree() From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 30 Apr 2018 13:10:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arvind Yadav Date: Wed, 25 Apr 2018 20:26:14 +0530 > Never directly free @dev after calling device_register(), even > if it returned an error. Always use put_device() to give up the > reference initialized. > > Signed-off-by: Arvind Yadav Applied and queued up for -stable, thanks.