Received: by 10.192.165.148 with SMTP id m20csp4374336imm; Mon, 30 Apr 2018 17:40:09 -0700 (PDT) X-Google-Smtp-Source: AB8JxZolEykp+Nd4seFw+437ZYOD70In1Hi2AFmLswYvhfpHdmB718JS7fk448J64MraBuIL91by X-Received: by 2002:a17:902:6549:: with SMTP id d9-v6mr14388534pln.196.1525135209940; Mon, 30 Apr 2018 17:40:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525135209; cv=none; d=google.com; s=arc-20160816; b=QSIeDwrDEEC681rZYg97SaZQW6ziKUHttkXgOjQ3HfUhAVu1sUXXtwr5LS1/PwXTwg ssxfzsBXCVyqoOjbDxleWz3BHhBO/JJMG9l1p3h2QWJ1jxC46spNUlM5P5oNdYLEatE1 dAhqtpudOk2Km2bm4ZT7WafBTYRhmvNoJvPgS3KcFWyYrkfRKH/rwb0UE/YcUChtDPj9 AFoY4sgvj3g2Dpf3SGLEyBhdEODbvpQ8B47CdNRMsiBlTlqDYE5qv9UPFnPGzHh6V/Ha 4lcCZ82SBciwi71+0wSuOrdZVvh10g6w2hbHDvjv+KRfCujbgm6oa0ZO+RXtb80kbi/F auBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=7Hjk9vU63ULpYkBKjbEyga1MYiuGUCoEHb0IOEpOpvg=; b=sdMJe8qj0fXKnN+vwN+WKMZ0EMlA2C1gdke2Mwt1QK4EZDLEeV6ijctBMlp6Upqk/E vrkrd9G6aoGpfOVe1P5j53djr5GLtkfGeNVxqDnvZU4dv95KKf0JNyy8wPmHJ81Aioct OTtRxkSMogOFn8JO0hfvaf59EOXaggrEvTAXuY1G76iA+LdyMLyDpgo4DdDn5EMaPfpR UhRfZeHBO4McZJwQNsYwA0G4orLyFLW4rRFkIj1jOp98cBmGyaAK4O0gpNgbgNXsZexy ZhN9FK1f4yumC2TtUdYjBJdCClEllNf7EslBEmnfar72HL07HPOV0HKgBGXUh03J2yr9 W+4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11-v6si6878844pgs.44.2018.04.30.17.39.55; Mon, 30 Apr 2018 17:40:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755815AbeEAAjR (ORCPT + 99 others); Mon, 30 Apr 2018 20:39:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56370 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751418AbeEAAjQ (ORCPT ); Mon, 30 Apr 2018 20:39:16 -0400 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A5AAC04BD55; Tue, 1 May 2018 00:39:16 +0000 (UTC) Received: from fidelio.ahs3.com (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EE61313DD05; Tue, 1 May 2018 00:39:13 +0000 (UTC) From: Al Stone To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Al Stone Subject: [PATCH v3 0/3] mailbox: ACPI: Remove incorrect error message about parsing PCCT Date: Mon, 30 Apr 2018 18:39:04 -0600 Message-Id: <20180501003907.4322-1-ahs3@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 01 May 2018 00:39:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This set of patches provide some cleanup in ACPI for minor issues found while correcting a bogus error message (the first two patches), and the correction for the error message itself (patch 3/3). Note that patches 1/3 and 2/3 are not required for 3/3 to work: 1/3 only changes a comment and 2/3 makes an ACPI table parsing loop a wee bit more robust. For patch 3/3, many systems on boot have been reporting "Error parsing PCC subspaces from PCCT" which turns out to not be an error at all. The issue is that the probe for ACPI mailboxes defined in the PCCT (Platform Communications Channel Table) makes a faulty assumption about the content of the PCCT. What's more, when the error is reported, no further PCC mailboxes are set up, even when they have been defined in the PCCT. So, in the reported cases, there was no error and the data in the PCCT was being ignored. This is described in more detail in patch 3/3. Since these patches primarily involve ACPI usages, it may make sense for all of them to go through the linux-acpi tree; clearly, this is up to the maintainers, though. v3: -- properly format docbook info in patch 1/3 -- remove extra parens in patch 2/3 -- clean up formatting, remove pr_warn() calls used in debugging but providing no value, clean up docbook info for count_pcc_subspaces() and parse_pcc_subspaces(), all in patch 3/3 v2: -- removed one extraneous '+' in a comment in patch 3/3 -- fixed an if test that had a predicate that kbuild pointed out would always be zero Al Stone (3): ACPI: improve function documentation for acpi_parse_entries_array() ACPI: ensure acpi_parse_entries_array() does not access non-existent table data mailbox: ACPI: erroneous error message when parsing the ACPI PCCT drivers/acpi/tables.c | 12 ++++--- drivers/mailbox/pcc.c | 96 +++++++++++++++++++++++++++++++++------------------ 2 files changed, 71 insertions(+), 37 deletions(-) -- 2.14.3