Received: by 10.192.165.148 with SMTP id m20csp4553463imm; Mon, 30 Apr 2018 22:25:32 -0700 (PDT) X-Google-Smtp-Source: AB8JxZod/5OzRHhDZZanWvRKfz5yBXUqjrTrYuJ8ce9QwbuF2ntcQ9i2xUuZsbEEjFje/meJYiaH X-Received: by 10.98.152.203 with SMTP id d72mr14379904pfk.98.1525152332393; Mon, 30 Apr 2018 22:25:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525152332; cv=none; d=google.com; s=arc-20160816; b=zLqNyl3Bc9Zwtmu27dRnJG6jSFRTDLkXJdQhinEy6MCgoSTcVVFZO7xpQynD6QoN0N 4PXjJAM7vZiUBWWsW7kouoRggf0tGuJiNslFwkO0VqBDXxL8G0d+WG59ZoZi9tCjcDKj AT8VJOnmpmS5sX1gkNMuGdwwXgf0xfITwPMY5YiN6ztimQckG/4l7UcPLm+Qp6COy6GA SRhaMpBMTQ2mCyxaSaB9eMVcgBUKmgWxcqlSvKw3sRlyL3R/9Bpuybu8ebvcx2bMSzJ9 Tfw9ix1kvV/yv/6pc3CoiFHDyWR/nj0yQZAx7jEXAXDfoOor5D+8Sp2lqPOfd2evSF7u /A5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=B0UCKRApzyyqM/e4yVR9MoxfwyoCyLL3ZdFbBcjj7cA=; b=erlN2E9JQZlAUut25UoSRQOyW6X4GAAplhnAbz1BJM1PB6OKOcc8LvQY+whORLbfIz 3Pe0guUEe6HoMH/56YDXU0Ey8cYNGPCUzsMaBLmjP/hcQ/eXyc4MJ+qRaSRgQwkWdjEH IFdrALeHWHXjo0+ABkt8/w9KCrwThSjCm20SgBOlyklG4bxJvArBKivJO6jKkMbee+c4 +mObqFWRU1iXE2risrcRzYT6mo1pSqdHmyoeIQ5eiDME5sURG9BMLUjePXeX919GKvPa zgwyQA8xqGZwp8VS5llZHvup/lShjmmc1WDy44U4rTNFGxk/qptjjAD5Xl8/OfiTzPYm 7fOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=j6SR55oT; dkim=pass header.i=@codeaurora.org header.s=default header.b=IwFiYqdg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z61-v6si8978732plb.200.2018.04.30.22.24.52; Mon, 30 Apr 2018 22:25:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=j6SR55oT; dkim=pass header.i=@codeaurora.org header.s=default header.b=IwFiYqdg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751472AbeEAFYn (ORCPT + 99 others); Tue, 1 May 2018 01:24:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53416 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbeEAFYm (ORCPT ); Tue, 1 May 2018 01:24:42 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B21716090E; Tue, 1 May 2018 05:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525152281; bh=X22JBzMtfwLGKqt92eImLzcJNWi/wdbUt6blrj3A/nc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=j6SR55oTqYSMCGnpk7FHl8EShM5hNXGlbw/wnkeB4qZIG49Rgb8tqLYAPDykHWUPc BujKlF6EyhDw34nrim3DbzMfDg2+GO3zQTbxk0Tr7uhxOsMRMPKaobB8bkqN98gWYt hc5Ysbm0ElFlNFXxt895Bjc/LLbquUL9ksCpDZ2w= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.204.79.109] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cpandya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 06FF660588; Tue, 1 May 2018 05:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525152280; bh=X22JBzMtfwLGKqt92eImLzcJNWi/wdbUt6blrj3A/nc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IwFiYqdgZdH7axH2MJWd1m/tC2KLU51sAZySt0wu9bMBMzWlEtcgJiUH4GuRaeueL 8+afhpxQrscJCeNH0mHZp/Hn08rWlG9HSHu8hZir9Fan70RYEWRUiUC3DgXcWoCzp0 zbku2yhTzg1MhPtzqpwu17UcZfDsoG9FZ4wr/hig= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 06FF660588 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cpandya@codeaurora.org Subject: Re: [PATCH v2 2/2] mm: vmalloc: Pass proper vm_start into debugobjects To: Andrew Morton Cc: vbabka@suse.cz, labbott@redhat.com, catalin.marinas@arm.com, hannes@cmpxchg.org, f.fainelli@gmail.com, xieyisheng1@huawei.com, ard.biesheuvel@linaro.org, richard.weiyang@gmail.com, byungchul.park@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, khandual@linux.vnet.ibm.com, mhocko@kernel.org References: <1523961828-9485-1-git-send-email-cpandya@codeaurora.org> <1523961828-9485-3-git-send-email-cpandya@codeaurora.org> <20180430160436.45f92ec5b3c78c84e4425ec4@linux-foundation.org> From: Chintan Pandya Message-ID: <6cfa516c-162a-c08a-80b9-3fed0c616b76@codeaurora.org> Date: Tue, 1 May 2018 10:54:34 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180430160436.45f92ec5b3c78c84e4425ec4@linux-foundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/1/2018 4:34 AM, Andrew Morton wrote: > should check for it and do a WARN_ONCE so it gets fixed. Yes, that was an idea in discussion but I've been suggested that it could be intentional. But since you are raising this, I will try to dig once again and share a patch with WARN_ONCE if passing intermediate 'addr' is absolutely not right thing to do. Chintan -- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project