Received: by 10.192.165.148 with SMTP id m20csp4671256imm; Tue, 1 May 2018 01:19:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrniEWdKYJwCd8FIHkqDHJKyOGu4odX4mgULyLQlvoCqHpFH+jnJ1e0phWpSyPPF94iiY/E X-Received: by 2002:a17:902:59ce:: with SMTP id d14-v6mr15646018plj.253.1525162747077; Tue, 01 May 2018 01:19:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525162747; cv=none; d=google.com; s=arc-20160816; b=WYlOueaKuOgm9dLd8OGntToCO1jkdaiDOCzaXkcwG+EPA9CjL6nm32TrTdFw+TTDJY TOzTOdmHcVXNkUCxFMOLnYXHzB+wB1w604nUV5VF352vwErQFp2pyTF4c6Yz2pC6jaI2 u2r6dv9xL6+j5QhoPNByKRT1sNyDKhBCszsaUPCJksGwFOLmWXBLMV2DKLRo0W5KpaIG ozjMN4WrTkauAsFIOgnFmfP8IxGbE7xLV0htxUKQPc9e80IBGKuUhIDipcm0Ues3Dmif +cP3i84zXwIZXdexRTiJfXr+r19sFrbC0YJm51tLrk81FFwTpJq8FCIadmALxcIDMWAC 3vXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=H7ERFroAWgb11hKUlQJzA09ZHbeGBuC3LgmTuPwN0fI=; b=POmuS0/MEKZrP9S7XHXwtYOH5vSZdANnkdsNu0w6kVgQUVaShY4BE1Pu0wjnKFtKXm OJLPo52PCX7ERLmkYctTOyorsBEIo0hc6Tp8ZGdfAvT27Mm4pWV1s9O0s5yQVWzhecc8 UcMhySANfiqi0H7ngL9e1+DLIzbtjjKexmALiuyq/sku7tEXpIH8b6zeDZkbUZX4yg1C rVCFCxHPGHhhPs+zNQFZw9fZPp0r0m0CryN3xhZmn8j8RtkCK0YzGrBTzzGIqQTID495 jrSN1EGIr0d5WBeRCap6NyU5/dYDWb/xSe/nqGCGBtg57T7IjL1j8aLdi3/h14PM2WYd Begw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 6si8983234pft.35.2018.05.01.01.18.53; Tue, 01 May 2018 01:19:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbeEAISj (ORCPT + 99 others); Tue, 1 May 2018 04:18:39 -0400 Received: from mail.skyhub.de ([5.9.137.197]:45806 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbeEAISh (ORCPT ); Tue, 1 May 2018 04:18:37 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id l8t-He8mhx5V; Tue, 1 May 2018 10:18:20 +0200 (CEST) Received: from pd.tnic (p200300EC2BC6BB0018CA5EB1E28A3112.dip0.t-ipconnect.de [IPv6:2003:ec:2bc6:bb00:18ca:5eb1:e28a:3112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 527791EC0288; Tue, 1 May 2018 10:18:20 +0200 (CEST) Date: Tue, 1 May 2018 10:18:19 +0200 From: Borislav Petkov To: "Maciej S. Szmigiero" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/6] x86/microcode/AMD: Add microcode container data checking functions Message-ID: <20180501081819.GB31863@pd.tnic> References: <20180430090447.GA6509@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 01, 2018 at 12:27:17AM +0200, Maciej S. Szmigiero wrote: > These checking functions are supposed to be called in order: We don't do magical rules like that - you either verify fully and correctly or you don't bother at all. And since you're adamant that this verification needs to happen, then please do it completely. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.