Received: by 10.192.165.148 with SMTP id m20csp4833638imm; Tue, 1 May 2018 04:50:10 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp11J/qPy0PH1XXbOebIF3KBLPzyT9+OJKNN1/b6j1mBpBmulOGNdnCifPksOlUT9mUrUqd X-Received: by 10.98.229.13 with SMTP id n13mr15352924pff.125.1525175410833; Tue, 01 May 2018 04:50:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525175410; cv=none; d=google.com; s=arc-20160816; b=ua/panpBH6UbkBjMgyT8OS/2uYH8GR757kd/Wk3snn/86ugZzAMwpA9leD0ICcrRJw uEfQoGDk9HKiUzFy9GfPlQTE2R4Y1KfL8iJvc9+4Om2IbQGUCo2cNXfeECpeIJikvaul MET140L46uJmj6tjZbpI1Nza3wh/UDpn4mXT8ln5URGCFCTA8+o3+ypVGqFgLJ2CXW0m hoxNn08moWkPCbhnzH5N5oe9kdxvTJ2loNpLik/mFCRrScVnnszevJheHeBl7DSTkt2X nKF+008R4IXylTfN9/qwDX9a9sc5OBoGWbjy7VulrYqkxzcVHEO6k5QcIrC9dKIxUnT+ BLWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=cyrlCjro9woOMWMoyT9nLgrvENC2nVrJ3Pkvp+hRv1Q=; b=nlWapiuHfN5hcicTyLgJzeQ/5Ach1dd5uSj8QGZ2CfFeBsu3WuwP3i5IkZN3xl9vbi iKygUn68rPROYSjhqu1tkAauubivL2YgpceC8Q0GGPviOW8vLTHzhbx2oWLbrNBepSAj wnTCZmDbXT1+BcXvRPzkLugQBhSv/H8mP0mN/Va+dkfSQeOggaY59u0ToCO8QXeEoNEY K7LJ0tzXTZSts7cpJO6GHQJk7B1+cT7FEpz4EzhRHAuENj9iN29LCWsVfNbGtrUHzD7K 4E4TtWu3pu1ovKWqPhN1ddA1q5SQverYQaOO01abW+VhlZfaBXRPJFx624hVMQ4ZAN+A 7xIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s62-v6si7802351pgc.216.2018.05.01.04.49.56; Tue, 01 May 2018 04:50:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754805AbeEALtp (ORCPT + 99 others); Tue, 1 May 2018 07:49:45 -0400 Received: from mga04.intel.com ([192.55.52.120]:20976 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920AbeEALto (ORCPT ); Tue, 1 May 2018 07:49:44 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 May 2018 04:49:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,350,1520924400"; d="scan'208";a="52240613" Received: from nbozheno-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.85]) by orsmga001.jf.intel.com with ESMTP; 01 May 2018 04:49:41 -0700 Date: Tue, 1 May 2018 14:49:40 +0300 From: Jarkko Sakkinen To: Thiebaud Weksteen Cc: nayna@linux.vnet.ibm.com, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] tpm: Add explicit endianness cast Message-ID: <20180501114940.GD20978@linux.intel.com> References: <20180425132641.106385-1-tweek@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180425132641.106385-1-tweek@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 03:26:41PM +0200, Thiebaud Weksteen wrote: > Signed-off-by: Thiebaud Weksteen > --- > drivers/char/tpm/tpm_eventlog_of.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/tpm/tpm_eventlog_of.c b/drivers/char/tpm/tpm_eventlog_of.c > index 96fd5646f866..ea0f16f19d73 100644 > --- a/drivers/char/tpm/tpm_eventlog_of.c > +++ b/drivers/char/tpm/tpm_eventlog_of.c > @@ -56,8 +56,8 @@ int tpm_read_log_of(struct tpm_chip *chip) > * but physical tpm needs the conversion. > */ > if (of_property_match_string(np, "compatible", "IBM,vtpm") < 0) { > - size = be32_to_cpup(sizep); > - base = be64_to_cpup(basep); > + size = be32_to_cpup((__force __be32 *)sizep); > + base = be64_to_cpup((__force __be64 *)basep); > } else { > size = *sizep; > base = *basep; > -- > 2.17.0.484.g0c8726318c-goog > Repeal and replace, right (no change log)? /Jarkko