Date: Mon, 25 Aug 2003 18:37:45 +0200
From: =?iso-8859-1?Q?J=F6rn?= Engel <joern@wohnheim.fh-wedel.de>
To: Dan Aloni <da-x@gmx.net>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [BK PATCH] One strdup() to rule them all
Message-ID: <20030825163745.GA17608@wohnheim.fh-wedel.de>
References: <20030825161435.GB8961@callisto.yi.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20030825161435.GB8961@callisto.yi.org>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1081
Lines: 39

On Mon, 25 August 2003 19:14:35 +0300, Dan Aloni wrote:
> 
> While working on the fix to network devices names and sysctl,
> I fought to urge to create yet another strdup() implementation
> This came up.

Nice one.

> +/**
> + * strdup - Allocate a copy of a string.
> + * @s: The string to copy. Must not be NULL.
> + *
> + * returns the address of the allocation, or NULL on
> + * error. 
> + */
> +char *strdup(const char *s)
> +{
> +	char *rv = kmalloc(strlen(s)+1, GFP_KERNEL);
> +	if (rv)
> +		strcpy(rv, s);
> +	return rv;
> +}

My gut feeling is always afraid when something "must not be NULL",
someone will ignore this and Bad Things (tm) happen.  Is strdup ever
used such performance critical code that the extra check would hurt?

Apart from that, well done.

J?rn

-- 
Eighty percent of success is showing up.
-- Woody Allen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/