Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262028AbTHYRF4 (ORCPT ); Mon, 25 Aug 2003 13:05:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262050AbTHYRFz (ORCPT ); Mon, 25 Aug 2003 13:05:55 -0400 Received: from havoc.gtf.org ([63.247.75.124]:45770 "EHLO havoc.gtf.org") by vger.kernel.org with ESMTP id S262028AbTHYRFd (ORCPT ); Mon, 25 Aug 2003 13:05:33 -0400 Date: Mon, 25 Aug 2003 13:05:30 -0400 From: Jeff Garzik To: Jakub Jelinek Cc: Dan Aloni , Linux Kernel List Subject: Re: [BK PATCH] One strdup() to rule them all Message-ID: <20030825170530.GB7097@gtf.org> References: <20030825161435.GB8961@callisto.yi.org> <20030825122532.J10720@devserv.devel.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030825122532.J10720@devserv.devel.redhat.com> User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1227 Lines: 44 On Mon, Aug 25, 2003 at 12:25:32PM -0400, Jakub Jelinek wrote: > On Mon, Aug 25, 2003 at 07:14:35PM +0300, Dan Aloni wrote: > > diff -Nru a/lib/string.c b/lib/string.c > > --- a/lib/string.c Mon Aug 25 19:03:26 2003 > > +++ b/lib/string.c Mon Aug 25 19:03:26 2003 > > @@ -582,3 +582,19 @@ > > } > > > > #endif > > + > > +/** > > + * strdup - Allocate a copy of a string. > > + * @s: The string to copy. Must not be NULL. > > + * > > + * returns the address of the allocation, or NULL on > > + * error. > > + */ > > +char *strdup(const char *s) > > +{ > > + char *rv = kmalloc(strlen(s)+1, GFP_KERNEL); > > + if (rv) > > + strcpy(rv, s); > > + return rv; > > +} > > +EXPORT_SYMBOL(strdup); > > Better save strlen(s)+1 in a local size_t variable and use memcpy instead > of strcpy. Yep. When Rusty did his strdup cleanup, he followed my suggestion and did just that. Unfortunately Linus doesn't like the strdup cleanup, so I don't see this patch going in either :) Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/