Received: by 10.192.165.148 with SMTP id m20csp5270939imm; Tue, 1 May 2018 12:00:42 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp2JCFk1tJwXC+H6j8MZBFHrtTDYhyr1FBf294zjwLyaGhgImVNbqJpns9f3XMslixdnDBi X-Received: by 2002:a63:7003:: with SMTP id l3-v6mr16653pgc.14.1525201242889; Tue, 01 May 2018 12:00:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525201242; cv=none; d=google.com; s=arc-20160816; b=LE6cyc8nDb5jIHIJlRuz+gxp+FnvRZR9a1v0COm0FlrPl7Oa98CTm1eMfB/RBWcJga FiX+D7Pr8KyQt61VoDaDxLrLhsHcKnn6bdqqm8K0ykbogAu91dNhu1Hso0+LmZYhxK1x 0T2oh/QXZB5Tv3wCylG/85y6IYi2wJsIFTrHC73rpS/rDiOCnvKPR4ul2yrF2xXzVsZz BElkcgbyOv0o0NQZQJ+NFLPoEkM7k8sjVgA81tPP/vy+vJQ1qSaJjzcLhPW9iODzj7tC UhOWqe7K4EkdSxxOnvVJWwnPxzALFk2Sl4dV+tbubGBIqhQxZRIOg1vmYFilbVYmPUkL Pu/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=bLB0g2Uks9n5lV74CbD2OUkNO1VHyegC2b9hYdz1ZVo=; b=VmnYiVBaQi6KNjqFgcfuYiTc6K46LnDKLvCDGL79F/lf4+1K78nRJHGFqTT6woatfd QRhWO72xW92vO0gZHKsyC6tue0ihKhFWH30aeYnqxVbgBNGEkmRoiMLoqShW969k9+ze F1L7hhECCxIds1hOivNzBskMbNgTF/LIh5oyf30MAUX3OXKeEw8grNmOYdlewANTiY7R gUti3fWI16LOUc2yoxm0vnNzrB1fQyhsUmlmHF5zAdELepsR/knfgKX/M1jAVXxNPWu1 LmMRBnn1RlZIx8DJX+Ld6m4qRM2vzbNaVGlm81Jr6gXRBoclBOxy2AptJuqVt1mQP/5y zNXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6-v6si8143865pgs.399.2018.05.01.12.00.28; Tue, 01 May 2018 12:00:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756731AbeEAS6s (ORCPT + 99 others); Tue, 1 May 2018 14:58:48 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7644 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756654AbeEAS6K (ORCPT ); Tue, 1 May 2018 14:58:10 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 76A46B93EA053; Wed, 2 May 2018 02:57:57 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.202.226.46) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.361.1; Wed, 2 May 2018 02:57:50 +0800 From: Salil Mehta To: CC: , , , , , , , Fuyun Liang Subject: [PATCH net-next 6/9] net: hns3: Fix to support autoneg only for port attached with phy Date: Tue, 1 May 2018 19:56:02 +0100 Message-ID: <20180501185605.9584-7-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180501185605.9584-1-salil.mehta@huawei.com> References: <20180501185605.9584-1-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.202.226.46] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fuyun Liang This patch adds a check to support autoneg(ethtool -A) only when PHY is attached with the port. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index cc09713..a4e9991 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -5169,12 +5169,6 @@ static int hclge_set_pauseparam(struct hnae3_handle *handle, u32 auto_neg, struct phy_device *phydev = hdev->hw.mac.phydev; u32 fc_autoneg; - /* Only support flow control negotiation for netdev with - * phy attached for now. - */ - if (!phydev) - return -EOPNOTSUPP; - fc_autoneg = hclge_get_autoneg(handle); if (auto_neg != fc_autoneg) { dev_info(&hdev->pdev->dev, @@ -5193,6 +5187,12 @@ static int hclge_set_pauseparam(struct hnae3_handle *handle, u32 auto_neg, if (!fc_autoneg) return hclge_cfg_pauseparam(hdev, rx_en, tx_en); + /* Only support flow control negotiation for netdev with + * phy attached for now. + */ + if (!phydev) + return -EOPNOTSUPP; + return phy_start_aneg(phydev); } -- 2.7.4