Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262082AbTHYRXY (ORCPT <rfc822;willy@w.ods.org>);
	Mon, 25 Aug 2003 13:23:24 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262091AbTHYRXY
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 25 Aug 2003 13:23:24 -0400
Received: from mail.gmx.net ([213.165.64.20]:389 "HELO mail.gmx.net")
	by vger.kernel.org with SMTP id S262082AbTHYRXS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Aug 2003 13:23:18 -0400
Date: Mon, 25 Aug 2003 20:23:14 +0300
From: Dan Aloni <da-x@gmx.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
       Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [BK PATCH] One strdup() to rule them all
Message-ID: <20030825172314.GA10606@callisto.yi.org>
References: <20030825161435.GB8961@callisto.yi.org> <20030825122532.J10720@devserv.devel.redhat.com> <20030825170530.GB7097@gtf.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030825170530.GB7097@gtf.org>
User-Agent: Mutt/1.5.4i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1567
Lines: 48

On Mon, Aug 25, 2003 at 01:05:30PM -0400, Jeff Garzik wrote:
> On Mon, Aug 25, 2003 at 12:25:32PM -0400, Jakub Jelinek wrote:
> > On Mon, Aug 25, 2003 at 07:14:35PM +0300, Dan Aloni wrote:
> > > diff -Nru a/lib/string.c b/lib/string.c
> > > --- a/lib/string.c	Mon Aug 25 19:03:26 2003
> > > +++ b/lib/string.c	Mon Aug 25 19:03:26 2003
> > > @@ -582,3 +582,19 @@
> > >  }
> > >  
> > >  #endif
> > > +
> > > +/**
> > > + * strdup - Allocate a copy of a string.
> > > + * @s: The string to copy. Must not be NULL.
> > > + *
> > > + * returns the address of the allocation, or NULL on
> > > + * error. 
> > > + */
> > > +char *strdup(const char *s)
> > > +{
> > > +	char *rv = kmalloc(strlen(s)+1, GFP_KERNEL);
> > > +	if (rv)
> > > +		strcpy(rv, s);
> > > +	return rv;
> > > +}
> > > +EXPORT_SYMBOL(strdup);
> > 
> > Better save strlen(s)+1 in a local size_t variable and use memcpy instead
> > of strcpy.
> 
> Yep.  When Rusty did his strdup cleanup, he followed my suggestion and
> did just that.
> 
> Unfortunately Linus doesn't like the strdup cleanup, so I don't see this
> patch going in either :)

Perhaps Linus would like to keep strdup()'s scattered across the kernel, 
so their combined power would not be exploited by evil <insert silly LotR 
humor here>. :) I'll end this thread here.

-- 
Dan Aloni
da-x@gmx.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/