Received: by 10.192.165.148 with SMTP id m20csp5358641imm; Tue, 1 May 2018 13:36:36 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqHioUrHec25tLv8x3cNghWnZuJsJ1RQTGwSBdd9LLYd1hhFpMPowgfBwb1OkCN1m/vkUFR X-Received: by 10.167.134.20 with SMTP id p20mr16967428pfn.159.1525206996344; Tue, 01 May 2018 13:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525206996; cv=none; d=google.com; s=arc-20160816; b=QBhehgCB3QbcXwJa+0QSrWSXZOQI96nrxn7sGjZv5xsVdHxcExSei/if+mpboOeJfj wG+OWwioXTdRkGBm+lS9pA+RFUd6wWhbnAiQNTW9LvZ81egFw3cVfS3DAtcBq/nokAJI OWpBGAeglgY+e8Ue1JOlFVKqhWMdPF7Z+R8KzMTUnThsJuPQN4vCyuAijF/5coxT81hR 5IOPj7NMYxkw4m8yJcn69vFUgMPbMHfuj8Rr/ke6njV8ehJOffkbh7l2avSk52Q1Mw71 LRu7kU7VEK3GykeK/TaHzzDXOCn6R8Fvs1UZP0yPzYeB2DkqjWx51ZMBdnIavZRtAHHn ph4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=SqAv3f6ub6xxnyEwmpnMdBpZRMaIwQ6RdOh+LVnMZhA=; b=W9yQd9CWw0uLNwClcBbbuBoff34KwVsngvsgAtU/duSE+PhhAzse3rAjo5V3sB5s/1 HFl56vKR2fji1Wze99Ge5V+wkQWgzCdlwL5snVHBCZfxpLrG5TMLxxohuqI9xGHtVcii NeltufCl/auxXeLIT2Pxqs8E3kvX6dWExgKV/uTXqpkvB5Ma3ZWBkVgtE56iI447n914 PKH/H85FIXNfMHljuGTdWnW9tOnTXaILkUHqjh4/gMYl+i1TgItHrlPkK9iPbpuf0PdI YlMsbTjwyz8EPhzzrku6Iq3OH/auxbhqH/AL1/tr9+AJxmhkffXCgeV/SalxC/rTedEd 7Q1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NqxGoyhc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b123si10143599pfb.189.2018.05.01.13.36.21; Tue, 01 May 2018 13:36:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NqxGoyhc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229AbeEAUfz (ORCPT + 99 others); Tue, 1 May 2018 16:35:55 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:50950 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbeEAUfx (ORCPT ); Tue, 1 May 2018 16:35:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SqAv3f6ub6xxnyEwmpnMdBpZRMaIwQ6RdOh+LVnMZhA=; b=NqxGoyhcG54JeTf9t8xAsurO4 S2a47MYSKxQTejKOb2dRGSRBgTYMOU1Lr4jQTlgfVFD9Y13PUsG9yP+fWvmdfx1wygptgTR0g7HOc vRYmDSo89+1gyxrXZEP7Ujkpk5gyIgNk1Kvp8ED5rt6C2UU0D1q9BV8ocYZW2OmXjKnnI=; Received: from [211.55.52.17] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fDbzs-00011i-V4; Tue, 01 May 2018 20:35:37 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id CCA1C44007A; Tue, 1 May 2018 21:35:31 +0100 (BST) Date: Wed, 2 May 2018 05:35:31 +0900 From: Mark Brown To: Ryder Lee Cc: Leilk Liu =?utf-8?B?KOWImOejiik=?= , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] spi: mediatek: Use of_device_get_match_data() Message-ID: <20180501203531.GA2714@sirena.org.uk> References: <31f944ab8dfcc1d7b6f03b35657a2a34825b5246.1523347340.git.ryder.lee@mediatek.com> <94cba80f703be048666afde1ed53c15c3704c533.1523347340.git.ryder.lee@mediatek.com> <1525073196.21494.3.camel@mtkswgap22> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <1525073196.21494.3.camel@mtkswgap22> X-Cookie: Rubber bands have snappy endings! User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 30, 2018 at 03:26:36PM +0800, Ryder Lee wrote: > Hi Mark, >=20 > Is it okay with you? >=20 > On Mon, 2018-04-16 at 10:33 +0800, Ryder Lee (=E6=9D=8E=E5=BA=9A?V) wrote: > > The usage of of_device_get_match_data() reduce the code size a bit. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so=20 on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway. --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlroz5IACgkQJNaLcl1U h9Aozgf/dlersQlemJt9YYytwTHQpJn6ykNz0dHqAHr3JotCFqSGnkYfnmf1BrhS AmkDq4YgOtcv0XoGcdMCLMPeL5Ah2N2w+wkVG1JFXKSevbfAd19+rgyvrj7/iXRN z2R2FJu2avyaAGJONG0PZ9raP0CpqaxAfd9vww/n+4py/fnFCp7/r5m1fBbN6rkF 8i6jOWvA302gUgRk9r8viElBvWNBGmeso2IJBkcevlPET6pCgUg+N0SA5bFY0yJz U67oySQy/7z+Au+aJpdPiVsdIwGdRmWyeyGKQoVcuxl0NzERZ/9gjjA48gqTcRHT kKupcvzZoCxZeArEo1RoLNrqE51Ynw== =psBX -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v--