Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 1 May 2018 15:49:20 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Javier Martinez Canillas <javierm@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        linux-input@vger.kernel.org,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Nick Dyer <nick@shmanahar.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] Input: atmel_mxt_ts - add missing compatible strings
 to OF device table
Message-ID: <20180501224920.GB130399@dtor-ws>
References: <20180410095340.24074-1-javierm@redhat.com>
 <20180501184853.GB52077@dtor-ws>
 <CAL_JsqJ-UTGrPm2tiS1yVFweWB_LH2JSBpOpMtogTYFi7pCsGA@mail.gmail.com>
 <20180501205713.GA130399@dtor-ws>
 <CAL_JsqKs7Jb0yCM+mUHwqRfrhzCPar1rHq4J+cCyxne=rVoV3g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL_JsqKs7Jb0yCM+mUHwqRfrhzCPar1rHq4J+cCyxne=rVoV3g@mail.gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, May 01, 2018 at 04:33:07PM -0500, Rob Herring wrote:
> On Tue, May 1, 2018 at 3:57 PM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> > From: Javier Martinez Canillas <javierm@redhat.com>
> >
> > Commit af503716ac14 ("i2c: core: report OF style module alias for devices
> > registered via OF") fixed how the I2C core reports the module alias when
> > devices are registered via OF.
> >
> > But the atmel_mxt_ts driver only has an "atmel,maxtouch" compatible in its
> > OF device ID table, so if a Device Tree is using a different one, autoload
> > won't be working for the module (the matching works because the I2C device
> > ID table is used as a fallback).
> >
> > So add compatible strings for each of the entries in the I2C device table.
> >
> > Fixes: af503716ac14 ("i2c: core: report OF style module alias for devices registered via OF")
> > Reported-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > [dtor: document which compatibles are deprecated and should not be used]
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
> >  .../devicetree/bindings/input/atmel,maxtouch.txt   |    7 +++++++
> >  drivers/input/touchscreen/atmel_mxt_ts.c           |    5 +++++
> >  2 files changed, 12 insertions(+)
> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Someone is going to make the dts updates, right?

I sent out 2 patches...

-- 
Dmitry