Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Wang <davidwang@zhaoxin.com>
To:     'Thomas Gleixner' <tglx@linutronix.de>
CC:     <mingo@redhat.com>, <hpa@zytor.com>, <gregkh@linuxfoundation.org>,
        <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
        <brucechang@via-alliance.com>, <cooperyan@zhaoxin.com>,
        <qiyuanwang@zhaoxin.com>, <benjaminpan@viatech.com>,
        <lukelin@viacpu.com>, <timguo@zhaoxin.com>
Subject: Re: [PATCH v3] report correct CPU/cache topology
Date:   Wed, 2 May 2018 15:14:35 +0800
Message-ID: <000001d3e1e5$39b15640$ad1402c0$@zhaoxin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="gb2312"
Content-Transfer-Encoding: 8BIT
Thread-Index: AdPh5OZG/ZPAdTjOTuCfG5Pk1Np1sQ==
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> -----Original Mail-----
> Sender: Thomas Gleixner [mailto:tglx@linutronix.de]
> Time: 2018??4??26?? 19:56
> Receiver: David Wang <davidwang@zhaoxin.com>
> CC: mingo@redhat.com; hpa@zytor.com; gregkh@linuxfoundation.org;
> x86@kernel.org; linux-kernel@vger.kernel.org; brucechang@via-
> alliance.com; cooperyan@zhaoxin.com; qiyuanwang@zhaoxin.com;
> benjaminpan@viatech.com; lukelin@viacpu.com; timguo@zhaoxin.com
> Subject: Re: [PATCH v3] report correct CPU/cache topology
> 
> 
> 
> On Thu, 26 Apr 2018, David Wang wrote:
> 
> > Centaur CPUs enumerate the cache topology in the same way as Intel
> > CPUs, but the function is unused so far.
> > The Centaur init code also misses to initialize x86_info::max_cores,
> > so the CPU topology can't be described correctly.
> >
> > Initialize x86_info::max_cores and invoke init_intel_cachinfo() to
> > make CPU and cache topology information avaliable and correct
> 
> Now that looks pretty good.
> 
> > Signed-off-by: David Wang <davidwang@zhaoxin.com>
> >
> > Changes from v2 to v3:
> > *1 define new detect_num_cpu_cores() in common.c to replace the
> > original intel_num_cpu_cores;
> > *2 move cpu_detect_cache_sizes inside init_intel_cacheinfo.
> 
> But I asked for that being a separate patch with a separate changelog. And
> the intel_cache_info() change wants to be in a separate patch as well.
Then
> the third patch is the one which makes use of these changes for centaur.
> 
> Please read review comments carefully and rather ask when you have
> doubts about the meaning.
> 
> Thanks,
> 
> 	tglx
> 
	Sorry! 
	I will split the changes to three separate patches.
	Thank you.
---
David