Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 12B3F6028D
Subject: Re: [PATCH v1] kthread/smpboot: Serialize kthread parking against
 wakeup
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     tglx@linutronix.de, mpe@ellerman.id.au, mingo@kernel.org,
        bigeasy@linutronix.de, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        Neeraj Upadhyay <neeraju@codeaurora.org>,
        Will Deacon <will.deacon@arm.com>,
        Oleg Nesterov <oleg@redhat.com>
References: <20180426085719.GW4129@hirez.programming.kicks-ass.net>
 <4d3f68f8-e599-6b27-a2e8-9e96b401d57a@codeaurora.org>
 <20180430111744.GE4082@hirez.programming.kicks-ass.net>
 <3af3365b-4e3f-e388-8e90-45a3bd4120fd@codeaurora.org>
 <20180501101845.GE12217@hirez.programming.kicks-ass.net>
 <f134c8d8-e56f-bf29-0177-e6702ae79f2b@codeaurora.org>
 <20180501113132.GF12217@hirez.programming.kicks-ass.net>
 <745d762d-9ab3-0749-9b87-9bb03d913071@codeaurora.org>
 <20180501131904.GG12217@hirez.programming.kicks-ass.net>
 <9b289790-9b3a-73bd-7166-bf39f32cefd8@codeaurora.org>
 <20180502082011.GB12180@hirez.programming.kicks-ass.net>
From:   "Kohli, Gaurav" <gkohli@codeaurora.org>
Message-ID: <830d7225-af90-a55a-991a-bb2023d538f1@codeaurora.org>
Date:   Wed, 2 May 2018 15:43:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <20180502082011.GB12180@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 5/2/2018 1:50 PM, Peter Zijlstra wrote:
> On Wed, May 02, 2018 at 10:45:52AM +0530, Kohli, Gaurav wrote:
>> On 5/1/2018 6:49 PM, Peter Zijlstra wrote:
> 
>>>    - complete(&kthread->parked), which we can do inside schedule(); this
>>>      solves the problem because then kthread_park() will not return early
>>>      and the task really is blocked.
>>
>> I think complete will not help, as problem is like below :
>>
>> Control Thread                                CPUHP thread
>> 					
>> 					      cpuhp_thread_fun
>> 					      Wake control thread
>> 					      complete(&st->done);
>>
>> takedown_cpu
>> kthread_park
>> set_bit(KTHREAD_SHOULD_PARK
>>
>> 					     Here cpuhp is looping,
>> 					//success case
>> 					     Generally when issue is not
>> 					     coming
>> 					     it schedule out by below :
>>                                             ht->thread_should_run(td->cpu
>> 					      scheduler
>> 					//failure case
>> 					before schedule
>> 					loop check
>> 					(kthread_should_park()
>> 				         enter here as PARKED set
>>
>> wake_up_process(k)
> 
> If k has TASK_PARKED, then wake_up_process() which uses TASK_NORMAL will
> no-op, because:
> 
> 	TASK_PARKED & TASK_NORMAL == 0
> 
>> 					__kthread_parkme
>> 					 complete(&self->parked);
>> SETS RUNNING
>> 		                         schedule			
> 
> But suppose, you do get that store, and we get to schedule with
> TASK_RUNNING, then schedule will no-op and we'll go around the loop and
> not complete.
> 
> See also: lkml.kernel.org/r/20180430111744.GE4082@hirez.programming.kicks-ass.net
> 
> Either TASK_RUNNING gets set before we do schedule() and we go around
> again, re-set TASK_PARKED, resched the condition and re-call schedule(),
> or we schedule() first and ttwu() will not issue the TASK_RUNNING store.
> 
> In either case, we'll eventually hit schedule() with TASK_PARKED. Then,
> and only then will the complete() happen.
> 
>> wait_for_completion(&kthread->parked);
> 
> The point is, we'll only ever complete ^ that completion when we've
> scheduled out the task in TASK_PARKED state. If the task didn't get
> parked, no completion.

Thanks for the detailed explanation, yes in all cases unpark will 
observe parked state only.
> 
> 
> And that is the reason I like this approach above the others. It
> guarantees the task really is parked when we ask for it. We don't have
> to deal with the task still running and getting migrated to another CPU
> nonsense.
> 

-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, 
Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.