Received: by 10.192.165.148 with SMTP id m20csp538127imm; Wed, 2 May 2018 04:53:52 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqgyvAgqYPF9zpulqfVyTn2CXRBS3GmhBajFTcS0X9ZA9mx7JWVVvG5ObaHodzZ60iXLqMl X-Received: by 2002:a63:7352:: with SMTP id d18-v6mr16332263pgn.52.1525262032846; Wed, 02 May 2018 04:53:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525262032; cv=none; d=google.com; s=arc-20160816; b=ukoQD+XrPnjw+k3xBDnaZNLT4wvZ9Ivis607G4V9zZXMD+2QTUuZWazzA+sL3pQeNb 5PRTmOWZXAwi1m6Vtz0MCtAlLSeHniXix1LMual6zADWAhuz9fH7Rgp44+i+1J+N6N6x ZMeMX8RFdGPdEDUg77EWz59Cj6FWimyYObCAiqjYDp+arhDaXlseHEpFTNFQPcJuTdMD Mi4yCwYSs+I+j0goqaENWBtqMcg4NdajO8HnYsmo9tohz9ij8pR5VRgtUMHAikpSQNHL ETW5Xct6BrKXxCocdHBQN/UQ9S3Mgcf9eO3FMREMJj9umVHUyV/PeF/uRPVg3eKhtPoq VX/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:from:cc:to:subject :content-transfer-encoding:mime-version:references:in-reply-to:date :arc-authentication-results; bh=ct4U4KW3SiBpZQO1/w8n+G0T859VM6cfvUyIMaOxdLA=; b=vQGie2FciB2q4VLfg0GYbjhD+CQ5xSmmNAPpMIgzhxFChXidL41wdqTip0afqshKW4 Fu/BtRu/anIUp6mq0yxRVlXaUMUMJmOrngNFIhjyj900eXFjz6RCZma3fB9BbiRn0Iry JgOrWNmBKFGtq1MljPK9Z2teryElx9jKYhtzVZRsM1h8qXQoEY13Ejku1fmm0+3ziQGh 6i/IFunWwdeL3d2jm8OSmiGrRQ60R4Fese5o5JfCW2QRnsizXfU1EaVWsJVCdsiZsQZH EyQXjaDLB08Mh5QPUNJs8N4XpNZMZmwMVG47mUiuJSEtvGW9soEezHl6cVThJQDhVJU8 u5mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1-v6si11504223plb.430.2018.05.02.04.53.38; Wed, 02 May 2018 04:53:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751414AbeEBLwS convert rfc822-to-8bit (ORCPT + 99 others); Wed, 2 May 2018 07:52:18 -0400 Received: from hermes.aosc.io ([199.195.250.187]:47659 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750936AbeEBLwP (ORCPT ); Wed, 2 May 2018 07:52:15 -0400 Received: from localhost (localhost [127.0.0.1]) (Authenticated sender: icenowy@aosc.io) by hermes.aosc.io (Postfix) with ESMTPSA id 9C2535C2A0; Wed, 2 May 2018 11:52:05 +0000 (UTC) Date: Wed, 02 May 2018 19:51:37 +0800 In-Reply-To: <20180502114843.ou4qczp5eaigrdfo@flea> References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-16-jagan@amarulasolutions.com> <20180502114843.ou4qczp5eaigrdfo@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH 15/21] drm: sun4i: add support for HVCC regulator for DWC HDMI glue To: Maxime Ripard , Jagan Teki CC: Chen-Yu Tsai , Jernej Skrabec , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel@lists.freedesktop.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Michael Trimarchi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com From: Icenowy Zheng Message-ID: <2E519B6E-D1BA-4C6F-9105-446E564FBBB6@aosc.io> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年5月2日 GMT+08:00 下午7:48:43, Maxime Ripard 写到: >On Mon, Apr 30, 2018 at 05:10:52PM +0530, Jagan Teki wrote: >> From: Icenowy Zheng >> >> Allwinner SoCs with DWC HDMI controller have a "HVCC" power pin for >the >> HDMI part, and on some boards it's connected to a dedicated regulator >> rather than the main 3.3v. >> >> Add support for optional HVCC regulator. For boards that doesn't use >a >> dedicated regulator to power it, the default dummy regulator is used. >> >> Signed-off-by: Icenowy Zheng >> Signed-off-by: Jagan Teki >> --- >> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 14 ++++++++++++++ >> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h | 2 ++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >> index 9f40a44b456b..7c33faff7ad4 100644 >> --- a/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c >> @@ -73,6 +73,12 @@ static int sun8i_dw_hdmi_bind(struct device *dev, >struct device *master, >> if (encoder->possible_crtcs == 0) >> return -EPROBE_DEFER; >> >> + hdmi->vcc_hdmi = devm_regulator_get(dev, "hvcc"); >> + if (IS_ERR(hdmi->vcc_hdmi)) { >> + dev_err(dev, "Could not get HDMI power supply\n"); >> + return PTR_ERR(hdmi->vcc_hdmi); >> + } >> + > >You're not making it optional here, unlike what your commit log >says. Not that I'm fine with both, but we need to be consistent :) If it's not set, regulator subsystem will generate a dummy regulator as a spaceholder, except using the exclusive variant of the function. The word "optional" is from DT perspectove, as it's possible that it's bound to some critical regulators. > >> hdmi->rst_ctrl = devm_reset_control_get(dev, "ctrl"); >> if (IS_ERR(hdmi->rst_ctrl)) { >> dev_err(dev, "Could not get ctrl reset control\n"); >> @@ -91,6 +97,12 @@ static int sun8i_dw_hdmi_bind(struct device *dev, >struct device *master, >> return ret; >> } >> >> + ret = regulator_enable(hdmi->vcc_hdmi); >> + if (ret) { >> + dev_err(dev, "Cannot enable HDMI power supply\n"); >> + goto err_disable_vcc; >> + } >> + >> ret = clk_prepare_enable(hdmi->clk_tmds); >> if (ret) { >> dev_err(dev, "Could not enable tmds clock\n"); >> @@ -143,6 +155,8 @@ static int sun8i_dw_hdmi_bind(struct device *dev, >struct device *master, >> clk_disable_unprepare(hdmi->clk_tmds); >> err_assert_ctrl_reset: >> reset_control_assert(hdmi->rst_ctrl); >> +err_disable_vcc: >> + regulator_disable(hdmi->vcc_hdmi); > > >The err_disable_vcc label will disable the regulator, but if there's >an error in regulator_enable, it will disable it while it wasn't >enabled in the first place, which is not really something we want to >do. > >Maxime