Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 2 May 2018 16:36:37 +0300
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Kevin Easton <kevin@guarana.org>
Cc:     David Miller <davem@davemloft.net>, linux-kernel@vger.kernel.org,
        jasowang@redhat.com, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] vhost: make msg padding explicit
Message-ID: <20180502162932-mutt-send-email-mst@kernel.org>
References: <1524844881-178524-1-git-send-email-mst@redhat.com>
 <20180501.112822.1871426720257639849.davem@davemloft.net>
 <20180501201841-mutt-send-email-mst@kernel.org>
 <20180501.140551.1944561534446599966.davem@davemloft.net>
 <20180502062809.GA14485@la.guarana.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180502062809.GA14485@la.guarana.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 02, 2018 at 02:28:09AM -0400, Kevin Easton wrote:
> On Tue, May 01, 2018 at 02:05:51PM -0400, David Miller wrote:
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> > Date: Tue, 1 May 2018 20:19:19 +0300
> > 
> > > On Tue, May 01, 2018 at 11:28:22AM -0400, David Miller wrote:
> > >> From: "Michael S. Tsirkin" <mst@redhat.com>
> > >> Date: Fri, 27 Apr 2018 19:02:05 +0300
> > >> 
> > >> > There's a 32 bit hole just after type. It's best to
> > >> > give it a name, this way compiler is forced to initialize
> > >> > it with rest of the structure.
> > >> > 
> > >> > Reported-by: Kevin Easton <kevin@guarana.org>
> > >> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > >> 
> > >> Michael, will you be sending this directly to Linus or would you like
> > >> me to apply it to net or net-next?
> > >> 
> > >> Thanks.
> > > 
> > > I'd prefer you to apply it for net and cc stable if possible.
> > 
> > Ok, applied, and added to my -stable submission queue.
> 
> Hold on, this patch changes the layout for i386 (where there is
> no padding at all).  And it's part of UAPI.
> 
>     - Kevin
> 
> > 

Ouch.  True - and in particular the 32 bit ABI on 64 bit kernels doesn't
work at all. Hmm. It's relatively new and maybe there aren't any 32 bit
users yet. Thoughts?

-- 
MST