Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
From:   Stephane Eranian <eranian@google.com>
Date:   Wed, 02 May 2018 16:38:33 +0000
Message-ID: <CABPqkBTm+9Wsa21GVXpogWUDNkpRF4eyZOPGa8QJCvdV2Lz2rA@mail.gmail.com>
Subject: [RFC] perf record: dead code perf_event__synthesize_id_index()
To:     LKML <linux-kernel@vger.kernel.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@redhat.com>, mingo@elte.hu,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

It looks like perf_event__synthesize_id_index() is dead code in the current
tip
tree. I don't see any invocation of the function anywhere in perf.I
understand why
you'd want to keep the rest of the code related to  PERF_RECORD_ID_INDEX
because some perf.data file may have this user-level record type. But the
synthesize code is not needed anymore, in my opinion.

Shouldn't we remove this code?