Received: by 10.192.165.148 with SMTP id m20csp966967imm; Wed, 2 May 2018 11:41:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoMCtWRHBqPD18ET2JqCXn9vNRg4fW/ckSHZh0eO4nbudo474MADwlOMWrbBrGirVv8DEEC X-Received: by 2002:a17:902:bc4a:: with SMTP id t10-v6mr21165547plz.343.1525286475141; Wed, 02 May 2018 11:41:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525286475; cv=none; d=google.com; s=arc-20160816; b=z77HvQgK9UegSBeky5vXilRwaq2cgUcOo6oSjj4PZGOSKwjpwAIiWIPmWzFPWgIWcn EZA+aHFkaywN3w7QLsF28YG+HXIt036nhXITvwjJkpKKro+dNsAqJnDLnpWqNxJpiSfB hwV6GGQkcp0jImMHvq9ePDWGrrVx/ID4/G8W4ruV0B2m9vh1NJngF4lCC9FJEvJi1lbS +CJf+0T3VaubJhCR7z6hDzr0zy/pq0omKO/mwbo8rl1wtrxZuPo8rASE5oBuHaIAs6gm M3Fqd2kv3NKbjfl6z82ZtAh7Ec1u0Udo9Y8kfPjLYtj5rAfVPIsFFTOL4qqUxWaHblzu vJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=k7yVgkUmAUuMUTJIXgIR/xjYusclNhk4wZyfA+4gxhc=; b=rfXOu9WqrmWScApicixHvMdUkiB1M/JvUpXuFv+7gTSZGeSI/RW0UzuOh8t1Fd7FMY hXWJAu6SO7QpVdQuT8IvU/9C+dqwfnxaiH4cQgbRF0rgkixd1eJUgspGikCpAAjQy389 U80S0JwsxB2mTS/qVD/DgfYPbelUbSi5w0rMZ1ekbVyFeYW4K8iBe5ZYOwqO/KVhbwkZ ZCmR8yHSmByJxQpBtjOkMBLX4pGAX1ACtapXhcCp7WTqC/9+AyKJpMZ+09fa16d9rYgW SUvr6ke/iwoXy6PFYWnKCbLwKnxlQNtYV033JozLUKGXpxO19cee+5zJeDyyG242CKTW e9Tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w13-v6si9814378pgm.91.2018.05.02.11.41.00; Wed, 02 May 2018 11:41:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbeEBSkt (ORCPT + 99 others); Wed, 2 May 2018 14:40:49 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:52660 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbeEBSks (ORCPT ); Wed, 2 May 2018 14:40:48 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fDwgJ-000318-Fr; Wed, 02 May 2018 18:40:47 +0000 Date: Wed, 2 May 2018 19:40:47 +0100 From: Al Viro To: Ilya Dryomov Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iov_iter: fix memory leak in pipe_get_pages_alloc() Message-ID: <20180502184047.GV30522@ZenIV.linux.org.uk> References: <1525285017-18616-1-git-send-email-idryomov@gmail.com> <1525285017-18616-2-git-send-email-idryomov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525285017-18616-2-git-send-email-idryomov@gmail.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 02, 2018 at 08:16:57PM +0200, Ilya Dryomov wrote: > Make n signed to avoid leaking the pages array if __pipe_get_pages() > fails. Applied, with s/fails/& to allocate any pages/.