Received: by 10.192.165.148 with SMTP id m20csp1238971imm; Wed, 2 May 2018 17:13:30 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrpccBe5+wehEswHP2BGub1cwgpt93OnBCCI2GH7SrBHcJhlivaK6DZDyXA7YrzoRWJY8B6 X-Received: by 2002:a63:755c:: with SMTP id f28-v6mr18158250pgn.30.1525306410532; Wed, 02 May 2018 17:13:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525306410; cv=none; d=google.com; s=arc-20160816; b=hiyL9B3pmIWP28U+mLRsnfDxeX/NORIVTwX1BtukgeIbFT0g4dsri0xamRLleZMZ4C +LzT3LmF1UvQL2ag9c0J+ExX8DLVQkzKr5TN0zRRpJ34cnXyx3KDX4uTkD91NqvMylPA C/Xrg1B8Xd98GZZiyXUV4dVT/FlJIhrycsZwfowhE4PDr9L0B33PSdn+4pDc3OeSbaXo e/70+9+gJx/UhQyS+v/vuTg/WSfpN0TMewkBNXBe023Tq8vhZv7V3DcBY330pZ2RgEGJ lPL7nJVSv/gqiiii6MAK6Wmn0KOMqh1SRrjlgdZfnNq8lquAfJBiTXbL8e2ZKeoeXJpA sWuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=spc33yVAf/4c3IIydv8SbeopafPFNgFtlHIvU84GRoE=; b=XcSgi6AkpLli49kobDwDpXtdezCelwPcRxpiy1CNfpuOeqo43+8GL2JBtwwXRTarLb HjzsbZ+Ui0u9sonEzQXmqObaXNvqitNhNyhCdpDjhwPgetGpb9LFzWN4SkxINBOdIngk PM4ToyTocF6RE2ZOFMpr+f50dkC/z3w95B9RRKM0R0DgfFtwT5t5bBKdVR4o7J9XeYUm DHlJpXRrp6SsDZb428jqAs+ur7sjS01n5Ts6oLJdeZiSMB7p/cCbzk83YfMtYQh7Gz3V rovMohLq+VKGI+ZESSOpIZXDuDCO8hfS3snFYV7htfpMHiCvPwb4dimi0lKiU73AENR6 uhYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=A91rT4kS; dkim=pass header.i=@codeaurora.org header.s=default header.b=FXkBuFJv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r2-v6si12675652pli.370.2018.05.02.17.13.16; Wed, 02 May 2018 17:13:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=A91rT4kS; dkim=pass header.i=@codeaurora.org header.s=default header.b=FXkBuFJv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbeECANF (ORCPT + 99 others); Wed, 2 May 2018 20:13:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47908 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbeECAND (ORCPT ); Wed, 2 May 2018 20:13:03 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6883D6037B; Thu, 3 May 2018 00:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525306382; bh=6jx6qe/dY5ZW9LNbWN+ILxCD6JtQl/JNCWThzJXWEKk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=A91rT4kSLxWE3JiItopP9gGxJnmSR6eiLWTgeBhUk+TOp/1pv3cCjx6nEFkT5Y3ul J6FFq4ej1LuMXw+hWPj5eHiqqxs9MUVhO1G+QmsvKWE7Npn7YE4BeEwtk0tTe1jzL6 tJ+xhvHH03j5TEs5OhoQVJrLJAeD9aEFZQO7UYDw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [10.46.164.143] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: collinsd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 427D06037B; Thu, 3 May 2018 00:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525306381; bh=6jx6qe/dY5ZW9LNbWN+ILxCD6JtQl/JNCWThzJXWEKk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FXkBuFJvcRF0Xa4T/ICCzx3UKZTUIfebfs2EPxoaBWaYYcFde7tnNI5zb6ctJbsr/ odQzVxPqiVZst10o/nnggmz8bN+pA6k6NQALbi+yLW73ENVNV4YrzPQDT6yXSXAUG1 A5bQ3iT9ucGRH62YludAryqPLqfI8mB1CloA4kbg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 427D06037B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=collinsd@codeaurora.org Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings To: Doug Anderson Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd References: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org> From: David Collins Message-ID: Date: Wed, 2 May 2018 17:13:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/02/2018 09:37 AM, Doug Anderson wrote: > On Fri, Apr 13, 2018 at 7:50 PM, David Collins wrote: >> +- vdd_l26-supply >> +- vdd_lvs1_lvs2-supply >> +- vdd_lvs1_lvs2-supply >> + Usage: optional (PM8998 only) >> + Value type: >> + Definition: phandle of the parent supply regulator of one or more of the >> + regulators for this PMIC. > > One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice. I'll remove the duplicate. > Also on the schematics (and in the PM8998 datasheet) I have this is > "VIN_LVS_1_2". It seems like you should be consistent here and call > this "vin-lvs-1-2-supply". I was trying to keep the naming consistent within device tree binding documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I suppose that I can change this to match the hardware documentation pin name. I can also change '_' to '-' in the supply names if that is preferred. Take care, David -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project