Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180503044521.156965-1-astrachan@google.com>
In-Reply-To: <20180503044521.156965-1-astrachan@google.com>
From:   Joel Fernandes <joelaf@google.com>
Date:   Thu, 03 May 2018 05:11:42 +0000
Message-ID: <CAJWu+oof2VRWSeXGjTaP3M8tP4B9=kLw_nLN08bpCprYSYuh0g@mail.gmail.com>
Subject: Re: [kernel-team] [PATCH 1/3] staging: Android: vsoc: Create wc
 kernel mapping for region shm.
To:     Alistair Strachan <astrachan@google.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arve Hjonnevag <arve@android.com>,
        Todd Kjos <tkjos@android.com>, maco@android.com,
        ghartman@google.com, devel@driverdev.osuosl.org,
        "Cc: Android Kernel" <kernel-team@android.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 2, 2018 at 9:45 PM 'Alistair Strachan' via kernel-team <
kernel-team@android.com> wrote:

> Map the region shm as write-combining instead of uncachable.


I think more commit message is needed. Why is this done, what does it fix,
etc. Its hard to know what the improvement is without a cover-letter either.

I am assuming the improvement is in performance by using the
write-combining mode.

thanks,

- Joel