Received: by 10.192.165.148 with SMTP id m20csp1569139imm; Thu, 3 May 2018 01:27:43 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrw4z13g2z+H8TfM1iYk5pfgNtTObrDeE2NA2GLvvinNXKFi9lAs1Q6kErAbioRmfVeFA1E X-Received: by 10.98.231.16 with SMTP id s16mr22298601pfh.227.1525336063119; Thu, 03 May 2018 01:27:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525336063; cv=none; d=google.com; s=arc-20160816; b=ky8jT5gIsS2ziediXcvbk0AIGZ77e+bnqNIWc6DSO4E4sU6dvA7Mab1g1CyAbY9HFt f5HNc3nyg49obqeD3hf8+RNsgmQx4b/NGMWvzS6XJJb2ImMJwUsxtP7fFLpUEpZBbLua 9NzLHHpz+nZtWxk2AnzzTi34ru7ZOYLLqZ+06cNUX78ZHyXyEHWK4B75MhKo+HRIcWrn DbZ2TFxLRJvkNwjF/sJV9F2Ae0bwDAtrDpwMll66k34gvfiY/QMYs/i9d9FdKowFDT/d tGsf1ODZo/bBT71OPzWpxQ03p0oKUSSZuJO+WxQMsuROrTRpluVA9c2+WoHeNknV8KLv uC8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject :arc-authentication-results; bh=5pdqLw9HKf/wgCJwo/ec5/6AXq6v3k+xSJ0E29ckaYc=; b=pKnrT0Y0kCKuMuXacfSsblJmOos+1wRrBYw0A9amao9rYBh4r7O5iJOJDpr+FwNxZz At9i80XGRACT+iYoP94TPE9ewmu+vDKykNRgCfNCmUMNCXBVmhPbYU/9RbKZiMnA3TLU gUZoyhEWrumyuvlSuP1t3HSOZeICIj6jvMPoxR24xz4uOf+f7F0NGkUzuyhOVePwxT5q bgXrsslRcx+T0YDGA46B2L32gk7HUHO+l0zPoHqIQ1byZq3EsUsgAj428sTr0I8rByj3 xqqFNjhm8BZQr6qVyuO2i358lWomHp2STMFaQGeATS5sNsHKTd5aIifJmOD5aqFHSqkG QYkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3-v6si12961076pli.274.2018.05.03.01.27.29; Thu, 03 May 2018 01:27:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbeECI02 (ORCPT + 99 others); Thu, 3 May 2018 04:26:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:40160 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbeECI00 (ORCPT ); Thu, 3 May 2018 04:26:26 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2018 01:26:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,357,1520924400"; d="scan'208";a="36521343" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.168]) ([10.237.72.168]) by fmsmga007.fm.intel.com with ESMTP; 03 May 2018 01:26:21 -0700 Subject: Re: [PATCH 05/12] perf pmu: Fix pmu events parsing rule To: Arnaldo Carvalho de Melo , Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Jiri Olsa , Alexander Shishkin , David Ahern , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo References: <20180425160008.3407-1-acme@kernel.org> <20180425160008.3407-6-acme@kernel.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <448c4e21-8232-3d04-cac4-49b95c8bca3a@intel.com> Date: Thu, 3 May 2018 11:25:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180425160008.3407-6-acme@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi This breaks Intel PT i.e. $ perf record -e intel_pt//u uname event syntax error: 'intel_pt//u' \___ parser error Run 'perf list' for a list of valid events Usage: perf record [] [] or: perf record [] -- [] -e, --event event selector. use 'perf list' to list available events See below for cause. On 25/04/18 19:00, Arnaldo Carvalho de Melo wrote: > From: Jiri Olsa > > Currently all the event parsing fails end up in the event_pmu rule, and > display misleading help like: > > $ perf stat -e inst kill > event syntax error: 'inst' > \___ Cannot find PMU `inst'. Missing kernel support? > ... > > The reason is that the event_pmu is too strong and match also single > string. Changing it to force the '/' separators to be part of the rule, > and getting the proper error now: > > $ perf stat -e inst kill > event syntax error: 'inst' > \___ parser error > Run 'perf list' for a list of valid events > ... > > Signed-off-by: Jiri Olsa > Reported-by: Ingo Molnar > Tested-by: Arnaldo Carvalho de Melo > Cc: Alexander Shishkin > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Link: http://lkml.kernel.org/r/20180423090823.32309-5-jolsa@kernel.org > Signed-off-by: Arnaldo Carvalho de Melo > --- > tools/perf/util/parse-events.y | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > index 7afeb80cc39e..d14464c42714 100644 > --- a/tools/perf/util/parse-events.y > +++ b/tools/perf/util/parse-events.y > @@ -224,15 +224,15 @@ event_def: event_pmu | > event_bpf_file > > event_pmu: > -PE_NAME opt_event_config > +PE_NAME '/' event_config '/' These are not equivalent because opt_event_config allows '//' but event_config cannot be an empty string. > { > struct list_head *list, *orig_terms, *terms; > > - if (parse_events_copy_term_list($2, &orig_terms)) > + if (parse_events_copy_term_list($3, &orig_terms)) > YYABORT; > > ALLOC_LIST(list); > - if (parse_events_add_pmu(_parse_state, list, $1, $2, false)) { > + if (parse_events_add_pmu(_parse_state, list, $1, $3, false)) { > struct perf_pmu *pmu = NULL; > int ok = 0; > char *pattern; > @@ -262,7 +262,7 @@ PE_NAME opt_event_config > if (!ok) > YYABORT; > } > - parse_events_terms__delete($2); > + parse_events_terms__delete($3); > parse_events_terms__delete(orig_terms); > $$ = list; > } >