Received: by 10.192.165.148 with SMTP id m20csp1602617imm; Thu, 3 May 2018 02:11:13 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrHIc4+r7q0ZZx1h2s/0ttIfAnMuWsjSYW4lfOKKdVNA+zt1aIaJBv0uNrILekT8nyHx463 X-Received: by 2002:a63:705b:: with SMTP id a27-v6mr18548971pgn.432.1525338672967; Thu, 03 May 2018 02:11:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525338672; cv=none; d=google.com; s=arc-20160816; b=GiEZZYmcNAxnVs2IkCxjFwo6NxOF4ou+Q1zZnTc4LBRA7ix+Kx/z4mPvkZNXIbKZRU ma50d9J0hVyl9Dp1h2iWh5bRql4Yr2Gf8bmPCBiiLszIrg8LImvGqeAUAlW5dtIJNRcQ uq/ZukOqknLypSxOC1/F78Mi/0IhEJzJuO6KKIQ2sYtkroN1cBpxHWjVI6rSvgP2iWto p3YBLImwPoQ75StOfdfJYG2HJWbFQoGmrmlvEn9yV+U4O0K2KN9g7m1swpxiMb2sUyb4 BXwderg4p0cILMQI1O9em37biIfidwUE0Xt01QIyZAFiZWvlCwftM5kTHfZen2M5WA6m H5GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=1/ayIXGhsJvShEdQevQHCKh/vzgHft12K7FFPIrVY3w=; b=oYyK7xcKy6amLuVeZcpKOxijLwiWjOGFDX/BtH0VWjuY9BKFC1bqP8r2H2PUz8cycP S6B6qYcSu4mno4fAFWj2yr/OAQCbNOgMNBB5SpvR4bDzLjaVHypzMuKzyQhsONFbZL/X P4CAQkq7EcPBmInbFhTtwxrbel8RKVhWgkBqfMsfKmg3jEZWC2UD90dVZVLsO88sndTx QPNwry2m1lMwNrIRZCos+2viok0y2zkdloIivlWN/w5fZ8400NapfPlWRfhJ2K3ek56j Plnzpnsa0vqSkjHzll+WhhfqNJ4IlGRAafKXClLRjO2H2/sU9q1GPmqCD0qNuCdxCONZ Q7eA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n13si12910372pfg.227.2018.05.03.02.10.58; Thu, 03 May 2018 02:11:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbeECJJS (ORCPT + 99 others); Thu, 3 May 2018 05:09:18 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:59780 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751132AbeECJJP (ORCPT ); Thu, 3 May 2018 05:09:15 -0400 Received: from tarshish (unknown [10.0.8.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 8CA5D4409C2; Thu, 3 May 2018 12:09:11 +0300 (IDT) Date: Thu, 3 May 2018 12:09:09 +0300 From: Baruch Siach To: Jacob Chen Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mchehab@kernel.org, linux-media@vger.kernel.org, sakari.ailus@linux.intel.com, hans.verkuil@cisco.com, tfiga@chromium.org, zhengsq@rock-chips.com, laurent.pinchart@ideasonboard.com, zyc@rock-chips.com, eddie.cai.linux@gmail.com, jeffy.chen@rock-chips.com, devicetree@vger.kernel.org, heiko@sntech.de, Jacob Chen , Jacob Chen , Allon Huang Subject: Re: [PATCH v6 05/17] media: rkisp1: add Rockchip ISP1 subdev driver Message-ID: <20180503090909.o3dyhukzs2y7em5z@tarshish> References: <20180308094807.9443-1-jacob-chen@iotwrt.com> <20180308094807.9443-6-jacob-chen@iotwrt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308094807.9443-6-jacob-chen@iotwrt.com> User-Agent: NeoMutt/20180323 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacob, On Thu, Mar 08, 2018 at 05:47:55PM +0800, Jacob Chen wrote: > +static int rkisp1_isp_sd_s_power(struct v4l2_subdev *sd, int on) > +{ > + struct rkisp1_device *isp_dev = sd_to_isp_dev(sd); > + int ret; > + > + v4l2_dbg(1, rkisp1_debug, &isp_dev->v4l2_dev, "s_power: %d\n", on); > + > + if (on) { > + ret = pm_runtime_get_sync(isp_dev->dev); > + if (ret < 0) > + return ret; > + > + rkisp1_config_clk(isp_dev); > + } else { > + ret = pm_runtime_put(isp_dev->dev); I commented this line out to make more than one STREAMON work. Otherwise, the second STREAMON hangs. I guess the bug is not this driver. Probably something in drivers/soc/rockchip/pm_domains.c. Just noting that in case you or someone on Cc would like to investigate it further. I tested v4.16-rc4 on the Tinkerboard. baruch > + if (ret < 0) > + return ret; > + } > + > + return 0; > +} -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -