Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180503035931.22439-1-pasha.tatashin@oracle.com>
 <20180503035931.22439-3-pasha.tatashin@oracle.com> <20180503055407.GN3791@eros>
In-Reply-To: <20180503055407.GN3791@eros>
From:   Pavel Tatashin <pasha.tatashin@oracle.com>
Date:   Thu, 03 May 2018 13:38:35 +0000
Message-ID: <CAGM2reYu8uNuasJmsrJ8nzSJ5Zs2466D=ytgG21dJCd+7RO7fQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] drivers core: multi-threading device shutdown
To:     tobin@apporbit.com
Cc:     Steven Sistare <steven.sistare@oracle.com>,
        Daniel Jordan <daniel.m.jordan@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>, jeffrey.t.kirsher@intel.com,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        gregkh@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 3, 2018 at 1:54 AM Tobin C. Harding <tobin@apporbit.com> wrote:

> This code was a pleasure to read, super clean.


Hi Tobin,

Thank you very much for your review, I will address all of your comments in
the next revision.

BTW, I found  a lock ordering issue in my work that  that I will need to
fix:

In device_shutdown() device_lock() must be taken before
devices_kset->list_lock. Instead I will use device_trylock(), and if that
fails, will drop devices_kset->list_lock and acquiring the device lock
outside, and check that the device is still in the list after taking the
list lock again.

Pavel