Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 3 May 2018 15:59:04 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Chen-Yu Tsai <wens@csie.org>, Mark Rutland <mark.rutland@arm.com>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        dri-devel@lists.freedesktop.org,
        Gustavo Padovan <gustavo@padovan.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sean Paul <seanpaul@chromium.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 6/8] drm/panel: Add Ilitek ILI9881c panel driver
Message-ID: <20180503135904.bxobnijc3qadpz4f@flea>
References: <cover.a3617c4362eac8783f412525e52cf5552d19095d.1522835818.git-series.maxime.ripard@bootlin.com>
 <a99bb44577ae18e77e60dba904618db23ee5dca7.1522835818.git-series.maxime.ripard@bootlin.com>
 <20180426150712.GF31888@ulmo>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qlm2nnhy75vsga56"
Content-Disposition: inline
In-Reply-To: <20180426150712.GF31888@ulmo>
User-Agent: NeoMutt/20180323
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qlm2nnhy75vsga56
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Thierry,

Thanks for your review, I'll fix the other things you pointed out.

On Thu, Apr 26, 2018 at 05:07:12PM +0200, Thierry Reding wrote:
> > +static int ili9881c_send_cmd_data(struct ili9881c *ctx, u8 cmd, u8 dat=
a)
> > +{
> > +	u8 buf[2] =3D { cmd, data };
> > +	int ret;
> > +
> > +	ret =3D mipi_dsi_dcs_write_buffer(ctx->dsi, buf, sizeof(buf));
> > +	if (ret < 0)
> > +		return ret;
> > +
> > +	return 0;
> > +}
>=20
> According to this you're sending DCS commands, but none of the above
> look like valid DCS commands. Do you know what's going on here?

It looks to me that they are custom DCS commands.

> Also, can you include a reference to a datasheet where these
> instructions come from?

I'm not sure an Excel spreadsheet coming from the panel supplier would
be a good thing to include in a driver :)

Maxime

--=20
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

--qlm2nnhy75vsga56
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlrrFacACgkQ0rTAlCFN
r3Rd5w/+L3D/cUYcXj2rREM7Lt+SiwZWXdV7pIkLbY+MtKn7rxLqPewXTO/oSaoX
ylzyDJ+nftxiVJIFf+iU+EyI/zjjvGBeJ+QsMcT0Iqpz3SeR0qdjWTOL7VZ4HaEQ
TAexYkBHRhONKuc5g1boRwZ9a0sa8jhAy+C2kQKO+kC018GgU6/jg+TYKux9Sekn
jzglGTsIEpq5TJv9XfbzfTJ6zQmL482a+8EIqz66aIY+TbZUjAk3z7Kqac4bM7fl
OlyjRSK9Pa5U0O7kxjGsVEyJ45Wgl9UZOnNSfJYeLLqu/H1qyWOOwzuf6oyKnPda
q4YdZg8gYqhlZ671AA38M6xlGVmGWL0bvAwPHHEvhbm5ct6ezACeY5kSfBUjpE7e
FwdMIniPisqqP+ZHaRq7oi8SNQ6mWx208jL7I+tU9YnI+pptPjKbuyDQJEDC+3l9
k1AA4YE0BORG4PEaLsNwj4kBBRh80EeUbBhfd15kTDwmqXkF/7IOPnjqte22O/Wg
KW9O7pStLON1cguU+VvDIYDHmkQx0cgyMc3hJ4J99rlEtPv6q2mVSRBmb4WEVGNI
wmkioOUSWN3h46ez2mNTLOK2pK5ED+Jmo6jVxo55K5Elx+h7KiojS+/NzQygA3Ml
KqygE4kaJyZiWNFlEH0B7zzOt/SdCqwxngRs6QGtZCtqSzlRzAQ=
=CZiK
-----END PGP SIGNATURE-----

--qlm2nnhy75vsga56--