Received: by 10.192.165.148 with SMTP id m20csp1932532imm; Thu, 3 May 2018 07:43:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq9vXGe4S0lRpyoCEG+PbxdexC9PyXruVjueFwHk0/CUH1IUPZsdDt0Lo2wWnRbbO4/ot9g X-Received: by 2002:a17:902:bc49:: with SMTP id t9-v6mr24645144plz.109.1525358582874; Thu, 03 May 2018 07:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525358582; cv=none; d=google.com; s=arc-20160816; b=CFKFpm5orzw+qg3QQWP8/vU3Pe+HwX4EhvIHiqGH5XWTOHFRGMp/s+kcSi9/p9KS57 dCfgA4vIYIFEvz7uXI/LddLr2pCyqaiZFyy2HZbnK7DaM5b3G9GOnjo8InMYW5Vk1Hbi i46yb5/xoY8d8hh0VwazQFCVR2ngDrPuQlA25T9V8ea7zcEGcP+05kh8SvTXP+6f5uh1 W0RX3VboaVsxmD6iCrEOzwkv6KvpOpmLpBOKtYPsOr+26JfqvdRPstwaC3OA0Vx9WjCm vpQGD2mek04G+oAkIqZ9GyWeP2523I3ReEM+FbRBoRX7TCMrBNMbNNAmigRe9/AmDDgH 7dcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=Jsqg/9Wynyc1u7AAc2khVPJEynWzSRABBpgtLEVpU30=; b=cFjcKTaEMubLfanKloxvj5Y7gFTJuWRWrfZ1DTMHQksktHMM0A1L5SwDU6NdeicGkq THO2PxiUVm0DKHmqkTfO1P8MYI9enmrrHbwwhlEmip/Zz4xljlr2j8b/GySMRy9xYafB +8nwzuu68CjP6z4P2H+t/WcNCFXQpQAwYm8IUMNL1OEgA/ycmHtM+tRMsHitq1AEUjey Zhn0S/BXWNjYNZvPs8HnAvyOP4TwzSAQSNoioSLyEuFrAewOsL+xAFUjyBbQkpswMA91 LYL4sTV6sb2a5cLR0DQBRbQrrh5x2SPX+QJDF9Deo985Ww6dfYyHSxxEXNhgUv3Q4QUA z5qA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z1-v6si13545224plb.558.2018.05.03.07.42.48; Thu, 03 May 2018 07:43:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbeECOm2 (ORCPT + 99 others); Thu, 3 May 2018 10:42:28 -0400 Received: from foss.arm.com ([217.140.101.70]:42934 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750954AbeECOmU (ORCPT ); Thu, 3 May 2018 10:42:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5F9A31596; Thu, 3 May 2018 07:42:20 -0700 (PDT) Received: from [10.1.207.55] (melchizedek.cambridge.arm.com [10.1.207.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 609D23F25D; Thu, 3 May 2018 07:42:15 -0700 (PDT) Subject: Re: [PATCH v2 11/17] kvm: arm64: Configure VTCR per VM To: Suzuki K Poulose Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, cdall@kernel.org, marc.zyngier@arm.com, punit.agrawal@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com, ard.biesheuvel@linaro.org, peter.maydell@linaro.org, kristina.martsenko@arm.com, mark.rutland@arm.com References: <1522156531-28348-1-git-send-email-suzuki.poulose@arm.com> <1522156531-28348-12-git-send-email-suzuki.poulose@arm.com> From: James Morse Message-ID: <1175bc06-14b1-63e4-7b99-55c22db1c451@arm.com> Date: Thu, 3 May 2018 15:39:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1522156531-28348-12-git-send-email-suzuki.poulose@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suzuki, On 27/03/18 14:15, Suzuki K Poulose wrote: > We set VTCR_EL2 very early during the stage2 init and don't > touch it ever. This is fine as we had a fixed IPA size. This > patch changes the behavior to set the VTCR for a given VM, > depending on its stage2 table. The common configuration for > VTCR is still performed during the early init as we have to > retain the hardware access flag update bits (VTCR_EL2_HA) > per CPU (as they are only set for the CPUs which are capabile). > The bits defining the number of levels in the page table (SL0) > and and the size of the Input address to the translation (T0SZ) > are programmed for each VM upon entry to the guest. > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index 596f8e4..9f3c8b8 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -392,10 +392,12 @@ int kvm_arm_vcpu_arch_has_attr(struct kvm_vcpu *vcpu, > > static inline void __cpu_init_stage2(void) > { > - u32 parange = kvm_call_hyp(__init_stage2_translation); > + u32 ps; > > - WARN_ONCE(parange < 40, > - "PARange is %d bits, unsupported configuration!", parange); > + kvm_call_hyp(__init_stage2_translation); > + ps = id_aa64mmfr0_parange_to_phys_shift(read_sysreg(id_aa64mmfr0_el1)); Doesn't id_aa64mmfr0_parange_to_phys_shift() expect you do to the mask and shift for it? This will always hit the default case. > + WARN_ONCE(ps < 40, > + "PARange is %d bits, unsupported configuration!", ps); > } Thanks, James