Received: by 10.192.165.148 with SMTP id m20csp1953528imm; Thu, 3 May 2018 08:03:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq3VZYnJ/y5YMuDEep6FEV83pRDg18kgRgGco2xzKsz5+pxqma+tl2Mdctvxg3Kx+84kpTo X-Received: by 2002:a17:902:b902:: with SMTP id bf2-v6mr23738836plb.37.1525359782830; Thu, 03 May 2018 08:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525359782; cv=none; d=google.com; s=arc-20160816; b=Qar6WjE9Syv4lQtw5KVrL6TwT9sEbB4cKU4/9wyzcuN0hbm1H2LWdwZV+KDehQ+zyJ pxCLSD8+E/0+9KAqlU7sqDi8NSr9+UY5AE3Hs/WsFMwmFe/gBLOiwV8I4nQ+zmLSSf5V upLIfQXY3/VP+w0bK3B/Q1czVRq6lrK8dmLIgTSOa/FlA8aaqccJBbzdemmPKWMEX0+w DsfhIrnAr89a/1w3XL7Ke3822avmKhSAWq37evb1v54rz/PJq+N2ILubn5EDthXlRQAy L/tStcSDlhiUtTPTg74vQln5wt2Ita7HyuqY59tuX3ljINd3EYAmeQH2iBrSlM1Cq0Zr 5FKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=xcW56Ki+Le5tHqOqZ03lP882wv/fg1wsuACW1zIYN5k=; b=mCNOVzCyLKhrI16rX8F+zNwzNonLgbegzjDIWA4O9K4BNRRys+nFm3DIzy8rYF2QOU sHj/ZO+uK1skdN9laxu/ik+jdLuM6sYPffxKiCVCDqnDbKp9VDVEcOcZjqRFrWXn7hpE meF1VBumVF3D4/GpHHf6byp5wkiaivt+9Lb1uGAS8bNsp6HzZpmHJMS1C4lh/qQaSNWM OwAjELb9GWVj3xVj7j2RJCrxl//lxMZzKijqInRrBiu1Kfi6HqHSD9kvBmfATk5iMKOJ ngy/pi64oeXPjJoBOXEW1/8tcUyqHkxgaBFBHP0cFkd7bS4sIF4xDJlfHVSk3/fPUvDd 2YAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=v/h1m0ZR; dkim=fail header.i=@chromium.org header.s=google header.b=QmxDmV2e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5-v6si11170265pga.638.2018.05.03.08.02.35; Thu, 03 May 2018 08:03:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=v/h1m0ZR; dkim=fail header.i=@chromium.org header.s=google header.b=QmxDmV2e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbeECPBd (ORCPT + 99 others); Thu, 3 May 2018 11:01:33 -0400 Received: from mail-ua0-f193.google.com ([209.85.217.193]:42897 "EHLO mail-ua0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbeECPB3 (ORCPT ); Thu, 3 May 2018 11:01:29 -0400 Received: by mail-ua0-f193.google.com with SMTP id f3so11990190uan.9 for ; Thu, 03 May 2018 08:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xcW56Ki+Le5tHqOqZ03lP882wv/fg1wsuACW1zIYN5k=; b=v/h1m0ZRBBC4mlR276q6eXbESUMCg1e7+fOxuX1TrCe1Hd7bPanqrHsH8IQkC109Yb GdQLG+P/9B2xZM3Ckx0K+fSPmeuVbgYPHp+B9NUuJH53Q7asE7Nb3ysm+ihod14q/W6I W08gFdSDxB/mNPYS9+3sLfwEEgFuU5JUuIRE301EyzHBm0oKKkTCnOY2kDje6PlFZFE6 fDltf/cxZjGMEAHc00YQwxY+p7wijD3gLac3iPO7ld4/gEsFUuRLssM5C8eywM7tPQf8 90IGQrynLE7pyc+8Oy9YH73pUoInVZZf6h7v1LDtqmQjq9lk8RpeDJMTzDW+pYLVoH/G 9scQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xcW56Ki+Le5tHqOqZ03lP882wv/fg1wsuACW1zIYN5k=; b=QmxDmV2enDh0zi7VJgyE97xPn7oJi9J1B9z2+imol4sC5fkQRFFHrNGTswb1N2poWV 3JSco+u4UugvPeeDekC/8zS7tJtadL1ZxVNiSiBrovXbHoJN0uSKu2E3MOMMtN+pMxKm ILx8GEqYizk9JgxKjgdwd50jl6EtDqhKpKVqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=xcW56Ki+Le5tHqOqZ03lP882wv/fg1wsuACW1zIYN5k=; b=jBroesJuGqQ/563IKibaaO8E3wHj60PpOa1dWHvJelGOjAYfGEyNaEoPs5uz7vUwfI EJxO9egEOakFlf2/75z9IHOrlnb3WqE4E3U67/Ze/YKQaaQ+AP+WJlWGqpIvevc37mja XtIvANRCCz52MDxcVeCsbWqBNOafy/KE63rRf0xV4HFP8knVfYIdRgVQp9sJIQjQgchO gQLpUtB9db6fgjCRuoU7oZF2fFHeBG847DnmdUuNDN0IWCCcNVeUv3w4TnQ9EwH6YPtO lItKhTIUW6LSjn2SkXChSnPYYp/tNtCKsw5EccA7j+Jxa7rz558aXLA9b4OrMeoOfr1B hxmQ== X-Gm-Message-State: ALQs6tD2M7NzgPvgxENmtXVbC/9aQRy/dsixxuPNF5g/Y43WkCifFFAd mi1qJ/rcw+XuLhOvtEzibX1PywsbW7jkgjNHEd1bvQ== X-Received: by 10.176.112.140 with SMTP id m12mr22205406ual.191.1525359688166; Thu, 03 May 2018 08:01:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.48.82 with HTTP; Thu, 3 May 2018 08:01:27 -0700 (PDT) In-Reply-To: References: <39b676d2ba7dac2436196cc5a090c6f151498dc8.1523673467.git.collinsd@codeaurora.org> From: Doug Anderson Date: Thu, 3 May 2018 08:01:27 -0700 X-Google-Sender-Auth: Kljf5i9n4wfK832Ckzx9m-oYOgo Message-ID: Subject: Re: [PATCH v2 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings To: David Collins Cc: Mark Brown , Liam Girdwood , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, Linux ARM , devicetree@vger.kernel.org, LKML , Rajendra Nayak , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, May 2, 2018 at 5:13 PM, David Collins wrote: > On 05/02/2018 09:37 AM, Doug Anderson wrote: >> On Fri, Apr 13, 2018 at 7:50 PM, David Collins wrote: >>> +- vdd_l26-supply >>> +- vdd_lvs1_lvs2-supply >>> +- vdd_lvs1_lvs2-supply >>> + Usage: optional (PM8998 only) >>> + Value type: >>> + Definition: phandle of the parent supply regulator of one or more of the >>> + regulators for this PMIC. >> >> One small additional nit here is that "vdd_lvs1_lvs2-supply" is listed twice. > > I'll remove the duplicate. > > >> Also on the schematics (and in the PM8998 datasheet) I have this is >> "VIN_LVS_1_2". It seems like you should be consistent here and call >> this "vin-lvs-1-2-supply". > > I was trying to keep the naming consistent within device tree binding > documentation for LVS vs LDO and SMPS (e.g. 'vdd' vs 'vin' prefix). I > suppose that I can change this to match the hardware documentation pin > name. I can also change '_' to '-' in the supply names if that is preferred. I'd rather it match the docs. I personally have no idea for why the writer of the docs used "vdd" vs. "vin", but even if they had no good reason matching the docs makes this searchable. As far as the "_" to "-", Rob asked for that earlier in this thread and you says "I will change this on the next patch set." In general the desire to convert "_" to "-" makes this less searchable (since the docs use "_"), but that's the way device tree guys want it so so c'est la vie. Luckily it's easily to mentally change the "-"s back to "_"s when searching... -Doug