Received: by 10.192.165.148 with SMTP id m20csp222948imm; Thu, 3 May 2018 18:41:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrj77a2p8nnAaeiuJSpeataMJWHbO2cBdbgDM7Nd+ho+6qGRe5ZMH5txta5mQh1CwgQfXFr X-Received: by 2002:a65:5786:: with SMTP id b6-v6mr15753755pgr.241.1525398097442; Thu, 03 May 2018 18:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525398097; cv=none; d=google.com; s=arc-20160816; b=QGJ+BAOTarXwvq7bQvrv8OZKXFn9oJ9DENZnUDSmBXGyfSBAQj9go/AXxZIj7ffE8b NncM0AquBIotsGl4z1aAvT37eYihYC/dBy1cmlwYCzTDemhhSUSeXBY5p8/sR6nkmVlr 0++0vZKEV+IsePuOfq+zw2Y6jf1nWvnjejfNri5RGLszaM9o4bTOTkuGOZ5bzgMXq5vN VUJMBCM3Wn0tNbzLpoXrPhHQtZD63BGAj24vvOWrCKu2sfi9Cw9i12/jXErhS3EROsWv 9/vH3oNGg6vOHCiZ8TZh26lvjDN8lTZjfJnAH3a/hfZI9ARbtv8bDKG9qYxQmq+21sK7 Zg7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=IC6+Eb1rWJofpVPCernIk4hx4NwxYchKW2NHh0TPTBM=; b=sY13ebPX6ewf9+NsAH9KQlRBNYCaHHAHgocDCIsST09ayN094KlN+Y4fXpEOTaMz6l 0TKBfO1fpSi7XbdtQ8UOpxhbl8oc/HNdrups4IUovW6h5v4lAp7A1Unm2fMA/P1eqW3F Db0GfZO5FZm7WWGFnufJT+JlZunW1Dxu6UyPHxqNnMexLLdLVAhLW3BEeio5DDQo66gz 5k8KNqAeQTnTJzAwQl7R+fbU5KDy5RCN6PwZiMGdAnjFDNZdAyMKxydbdMwCyaAy7vKo LKw8veDMf0r1y/SSDDcRfHcEBq0tT+H3EtgNR3pmSByYSx7BRfJl22I0JfffbL76YNAY UUoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nextdimension.cc header.s=nextdimension.cc header.b=0oGEH3Mw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5-v6si13271587plo.113.2018.05.03.18.41.21; Thu, 03 May 2018 18:41:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nextdimension.cc header.s=nextdimension.cc header.b=0oGEH3Mw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbeEDBlM (ORCPT + 99 others); Thu, 3 May 2018 21:41:12 -0400 Received: from hapkido.dreamhost.com ([66.33.216.122]:45442 "EHLO hapkido.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbeEDBlK (ORCPT ); Thu, 3 May 2018 21:41:10 -0400 Received: from homiemail-a58.g.dreamhost.com (sub5.mail.dreamhost.com [208.113.200.129]) by hapkido.dreamhost.com (Postfix) with ESMTP id 18C3795387 for ; Thu, 3 May 2018 18:41:10 -0700 (PDT) Received: from homiemail-a58.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTP id AD5C86000E32; Thu, 3 May 2018 18:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=nextdimension.cc; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s= nextdimension.cc; bh=4xI+NE1XOul1oW9nZBiOkvtNR0Y=; b=0oGEH3Mwc/Z kBGUGhz/+pK8yovDEQgLTnAocGvLMXben2zoapwzwmj0orqT/DkqQoUt+j5Ac1V7 z98eQyEeofWBftAnV7LucDPpletB+VrG+CNwLUGH43oRPN6sqwPX681uROziveF1 /FKIT7rTuoWpNbm6x1GJz8JOl/Sudhss= Received: from [192.168.0.21] (66-90-189-166.dyn.grandenetworks.net [66.90.189.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: brad@b-rad.cc) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTPSA id 1D44C6000E2B; Thu, 3 May 2018 18:41:08 -0700 (PDT) Subject: Re: [PATCH] media: lgdt3306a: fix lgdt3306a_search()'s return type To: Luc Van Oostenryck , linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Brad Love , Michael Ira Krufky , Hans Verkuil , Thomas Meyer , linux-media@vger.kernel.org References: <20180424131907.5817-1-luc.vanoostenryck@gmail.com> From: Brad Love Openpgp: preference=signencrypt Autocrypt: addr=brad@nextdimension.cc; prefer-encrypt=mutual; keydata= xsFNBFjBn7UBEADLu822UvzHuo/b/8T+oTBQ7qLGq8OAb/GFDdttJSMreILjzfZvt6Zs8hRO PsUZ3djhOQB5pxrDA+wQgFsQ3T7jSC14bPq/IrKsb7WOaD12SozhgcgkMjoV/R4p9WciBU39 an5AU6WGBRUE5+Q1Yul20x1R9N9wciFCxVDAh1ibFfBqNbPLTAjd1PGj5Hqoa4oV6OaFDFj9 Qu1Xfu7TVq5mwrBgstsQtkJwug2adNjqN8eqJ3U8Fkrb7LDE7qbozKunlLQzr+YeiSLpu4SQ Li88JvKqVqLbQAOoGFb9lVHnbBSVU+XX8mSqhU1rh/NYJ4PdToFS7BpL+JeEFOmVlU20LwvD aJ8SpJrbT5bSQS12GXKp4MvKvVMfsdu+18kodTLxxFMhWRUFpZ1kh6NLfeAXRulmMQjxhJHp yZRJ2aSzNugOT18xBI25N/leOKfrcGgTDaFnL80MrwTs5b0sNvCqYzx1SObfkWkDPaejbWxu JEtQbtqeBSfi9R+DxRIqWIY8hODB9H6T2OINor+flABE1ucQ+dRzKyrJio8Ec2QIatFdymgw stPjDO/EYENf7oHhQW8GHfdN2exZ+V+2IGNpMKe20DHGEm96/GoEVVe/5u5T52k5e5dqrgTo k1HvhjYmfJGxDfilx2om2nHOQ4zP1bitgNZ8rLzAkJQ5U/2mZwARAQABzSdCcmFkIExvdmUg KE9TUykgPGJyYWRAbmV4dGRpbWVuc2lvbi5jYz7CwXcEEwEIACEFAljBn7UCGwMFCwkIBwIG FQgJCgsCBBYCAwECHgECF4AACgkQnzntUMfs451sThAAxflSKnPvRsSn3gqqghTcqSxPzkqL C8KFs4+No1ELUfu9HpEzRTC9+B9v+Ny2ajVkPHqdai3wY6FQmUx0mvBcLi3IZ99FKkESLLrP ys5PwDdaP14Yp9JajPOZ09KlJ07vdFTUdW+OiZ+lZRhog4wUR7JnnG6QjFFf/j0Akt7kzmUO GVz+J6Wn33Q1H6hU2EUtf0BLTxMQ4WSQGHLhUcSzlhZy35P4dLb6yRgoDFqYkrUpy5iDQLwK ZC98cgF9gsviY5soHhp63Xz6h62aB8m+0jGMNZj39Yy1hvnpOjON2wwL/277G1rDtKe8RZr4 Ii02Py2u1ikSNRxGL/Y6AMsMpoB/WyJgTfX86eE8kMBAmMRJfGpR5TkaiXLSvdJVhLn+rsIb qgQ9g2xjafZn7419T1q6OMzaQ9B24fKL9kdHJ4iqpPpXIr9+JI9PEIP9K5xD8axYjOQQ8J7E KvBU5XjGujG7wH1UPY+ZbeIF5oI82eGIOKhEktbSrbH48BrAzhCe8o7bBLvmKOoSkezzCFTn HP45IePANrh+4i+zffngfCykrSbsxRfIUZD7GlpYH5hYUVVPh8PDa5tZFu3wQ7yALks7WdNF nBuXXDoHBceTM5mozKwnmaGdSj4Gzda/1dGvJqbZcF/lICYpjFPRSh/meHrKRh2Z6vgziOci C7PrGGPOwU0EWMGftQEQANXBRd4Fwwl7MY5NpDwtvA+wi0le0YgTfWJTbD5y6IFgdKVDfMRK todmjgFP6utdwsHY+AvY6hdfXpKnaRGJC3e4kFNa/MSGJvfvAcfSO/N3eda88DcCmL4Rgl/d 5gErzrcYeN+O76+oSwMJU3fBiHVtLJqt8DgvWa8TrVNBemPXF+u8cWs0MjMOFFRHP8FnXOkv Fz6qk7oKuNJgo679b0b80CQKn2mpWg0HL9MZdhANYSDwKSf8PtLK7mZ7onydhmcW9TKM3Hqd IA8jQfAxws1srJHEhCaK7k6uQDPGkaeKErYalZc9k45uoJ9JfqleRysh0vMYCpOP9yTG9G+e RNIxK5EVMMmTTwejaJuWUvHrv1oTU7CDJJRXEVlbp5NFgg4D+RsJl+0DtYwHJple0ibSMINA nCMPAcqNhka3LARYq19Akz616Ggpek4FWnZyAQMWQaYrfkid0jaexdIIKMD9viR2l2vlwv4k SJbxtp6Z/1stCen6UQPno61zDIB0o4n+VE+gUEccec7LO78DlRQ54Ph6wXnPwAklMOwQNvQW ALefZn/G2OKozmEG0fP8HsRd0waLkrA0U7vJ3PiVEhJR/3u6F5FFgcUMMgOkps2j3IfWmdt4 c4p7tHTWtONMiMv65fQoTN03vfAmluInHcNsmtJaZjCW4mINpKYp5z+tABEBAAHCwV8EGAEI AAkFAljBn7UCGwwACgkQnzntUMfs450Yzg//d385d7DYyA4pH5maHEZVV86CDm2dSSHo262J 55eH49++ox8xbe3Ov46T5eKVkBVBQ99OacO2dLkzsMfngC+vM6TeqR1JVy62wmNaccy7HDBa aMdrIM0AnWABbOR4K5i2jAGcoXIlbDtRZ0Rnrp6Ql7Ah/SvdymD0qOh0Rs4+tI+ujN9OPNU3 BR2DFUKl3+X1T9RvPwX2egLSTG672hi99noLhFzqz/G8ae5ylMIJMvKzR3tUOApwOgd62e3K 1q+wDo4C7+DgLazGknZnjn/4eKJBah27njKr44qVx0CG4dCazkBwlwqKZEzqKLKo8PlyOHwA sQCREcTcE7lFsrf7z/G7PaluElEm5mH5uVFSWDYQzn6ZX18hjGuW+hkRgy1k/246X+D6FG+W MJu0Divd5Cd+Ly7cMF2WT3NQYET5Ma75h1JxTyXQ9HNQqumy0kyws4EL9ARaZDYO3F5JwkKK Om93LaUGEs5Cqb/hUv9k6eqjjQre9mB0ImDsGXkuuP0X6eN6yrstcaPAYl82NW+PGJ1Zz2ai AHkvsjIskeau68XRcm301QJI3qAZghhD7uJUH/NWBlr+w+F9vLlCgKvJLpahrd3PGHwgJnfV 1qqhouQNjsUrwpkXdQjTbSwtZaDPzCeSUSMArNjQMp21IYg/LhafLMzBqVODgaTsFDuVyRg= Message-ID: Date: Thu, 3 May 2018 20:41:07 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180424131907.5817-1-luc.vanoostenryck@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Brad Love On 2018-04-24 08:19, Luc Van Oostenryck wrote: > The method dvb_frontend_ops::search() is defined as > returning an 'enum dvbfe_search', but the implementation in this > driver returns an 'int'. > > Fix this by returning 'enum dvbfe_search' in this driver too. > > Signed-off-by: Luc Van Oostenryck > --- > drivers/media/dvb-frontends/lgdt3306a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c > index 7eb4e1469..32de82447 100644 > --- a/drivers/media/dvb-frontends/lgdt3306a.c > +++ b/drivers/media/dvb-frontends/lgdt3306a.c > @@ -1784,7 +1784,7 @@ static int lgdt3306a_get_tune_settings(struct dvb_frontend *fe, > return 0; > } > > -static int lgdt3306a_search(struct dvb_frontend *fe) > +static enum dvbfe_search lgdt3306a_search(struct dvb_frontend *fe) > { > enum fe_status status = 0; > int ret;