Received: by 10.192.165.148 with SMTP id m20csp348738imm; Thu, 3 May 2018 22:03:02 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqdR9dqYapEj1dSVrWontEKjicB1ZRRualsWUUUO8rDMXAPILCvA9bSLNMwSSO/e8Z4NBaL X-Received: by 2002:a63:9b1a:: with SMTP id r26-v6mr4433697pgd.406.1525410182070; Thu, 03 May 2018 22:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525410182; cv=none; d=google.com; s=arc-20160816; b=HEQCNfJI1ZBYiieEYgKAQscKFXwwoHKqnvVwmzoLPRXvUNyQUdZRRhoB0mJvd+NTm1 CVWbrRGTARSMXEErNeI7S50V9fAE/bH3ghzG+OdVzPU2wj/HsQf66MhM4na//ak4EIQH mWRkI0fgtK7CCP4uXCAT6e1NyoSX9qDqg0BWLfG6ii0vyzoHA4gagi/wwZ7FQuP/FHax cIiVySkDBeh8IERB+g5bxcQN3g1zRDd3BJUO5ea65ny9vAjkUBurU/WDmU3145y4qMN0 VWG9B4Y/uGMl1tcgmPwiJgPAng+Ypsi3Y1TJMb1Qa4us7qjvpUJV8NzAdLlfUFy33LGp 7rWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:cc:subject:date:to :from:arc-authentication-results; bh=jmIouJpJ+7rC6Jv1zhGIXEBlXeldyw7lVkeMNA5QKTk=; b=z4QpdB0VIST8nQq2dgJlzMXOJcWD1yR4UQvjGiIum4Cd0BRO7l4bbfRkRcFaEkKNSn 8AeKnxRG6KuxyTGCRlQ+lczr2qdIDrXt5DOMmF3k6m+XWR28S0w8XCZSa6sGT47V+waL vJO3xPl0hYXtmYZIrFuRUfI4GKE/rXxuR8z5yv4gpy92KeiS2/4KvLIv2l800aF3Y/Kr RURW5I7LzwQHWyvwd7c13kZtmCzHHnB/qcbzbpGeAFBKNWqPDKE7RQgsjnKkOlXYt7rL AyBIkCzE8cvOoHh/iBTaAJVJ4qJ3/M7djxiEWj3+CR07DWpXkTFL5f3855JtGhZNdeoJ DkSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w135si4055052pff.340.2018.05.03.22.02.47; Thu, 03 May 2018 22:03:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751718AbeEDFCH (ORCPT + 99 others); Fri, 4 May 2018 01:02:07 -0400 Received: from mx2.suse.de ([195.135.220.15]:48438 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbeEDFB2 (ORCPT ); Fri, 4 May 2018 01:01:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 246DAABE9; Fri, 4 May 2018 05:01:27 +0000 (UTC) From: NeilBrown To: Greg Kroah-Hartman Date: Fri, 04 May 2018 14:58:36 +1000 Subject: [PATCH 7/8] staging: mt7621-pci: remove some dead code. Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Message-ID: <152540991631.12190.9879547396075931701.stgit@noble> In-Reply-To: <152540982998.12190.15220622955317261586.stgit@noble> References: <152540982998.12190.15220622955317261586.stgit@noble> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some code is dead because it is commented out. Some is dead because it is uninteresting printks. Some is dead because it declares unused functions. Remove it all. Signed-off-by: NeilBrown --- drivers/staging/mt7621-pci/pci-mt7621.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c index 5094e90eaf69..edd95013faf3 100644 --- a/drivers/staging/mt7621-pci/pci-mt7621.c +++ b/drivers/staging/mt7621-pci/pci-mt7621.c @@ -56,9 +56,6 @@ #include -extern void pcie_phy_init(void); -extern void chk_phy_pll(void); - /* * These functions and structures provide the BIOS scan and mapping of the PCI * devices. @@ -364,11 +361,8 @@ pcibios_map_irq(const struct pci_dev *dev, u8 slot, u8 pin) void set_pcie_phy(u32 *addr, int start_b, int bits, int val) { -// printk("0x%p:", addr); -// printk(" %x", *addr); *(unsigned int *)(addr) &= ~(((1< %x\n", *addr); } void @@ -497,7 +491,6 @@ static int mt7621_pci_probe(struct platform_device *pdev) val |= RALINK_PCIE2_RST; ASSERT_SYSRST_PCIE(RALINK_PCIE0_RST | RALINK_PCIE1_RST | RALINK_PCIE2_RST); - printk("pull PCIe RST: RALINK_RSTCTRL = %x\n", RALINK_RSTCTRL); *(unsigned int *)(0xbe000060) &= ~(0x3<<10 | 0x3<<3); *(unsigned int *)(0xbe000060) |= 0x1<<10 | 0x1<<3; @@ -513,12 +506,10 @@ static int mt7621_pci_probe(struct platform_device *pdev) val |= RALINK_PCIE2_RST; DEASSERT_SYSRST_PCIE(val); - printk("release PCIe RST: RALINK_RSTCTRL = %x\n", RALINK_RSTCTRL); if ((*(unsigned int *)(0xbe00000c)&0xFFFF) == 0x0101) // MT7621 E2 bypass_pipe_rst(); set_phy_for_ssc(); - printk("release PCIe RST: RALINK_RSTCTRL = %x\n", RALINK_RSTCTRL); read_config(0, 0, 0, 0x70c, &val); printk("Port 0 N_FTS = %x\n", (unsigned int)val); @@ -614,8 +605,6 @@ pcie(2/1/0) link status pcie2_num pcie1_num pcie0_num RALINK_PCI_PCICFG_ADDR |= 0x1 << 24; //port2 break; } - printk(" -> %x\n", RALINK_PCI_PCICFG_ADDR); - //printk(" RALINK_PCI_ARBCTL = %x\n", RALINK_PCI_ARBCTL); /* ioport_resource.start = mt7621_res_pci_io1.start; @@ -653,7 +642,6 @@ pcie(2/1/0) link status pcie2_num pcie1_num pcie0_num case 7: read_config(0, 2, 0, 0x4, &val); write_config(0, 2, 0, 0x4, val|0x4); - // write_config(0, 1, 0, 0x4, val|0x7); read_config(0, 2, 0, 0x70c, &val); val &= ~(0xff)<<8; val |= 0x50<<8; @@ -663,7 +651,6 @@ pcie(2/1/0) link status pcie2_num pcie1_num pcie0_num case 6: read_config(0, 1, 0, 0x4, &val); write_config(0, 1, 0, 0x4, val|0x4); - // write_config(0, 1, 0, 0x4, val|0x7); read_config(0, 1, 0, 0x70c, &val); val &= ~(0xff)<<8; val |= 0x50<<8; @@ -671,7 +658,6 @@ pcie(2/1/0) link status pcie2_num pcie1_num pcie0_num default: read_config(0, 0, 0, 0x4, &val); write_config(0, 0, 0, 0x4, val|0x4); //bus master enable - // write_config(0, 0, 0, 0x4, val|0x7); //bus master enable read_config(0, 0, 0, 0x70c, &val); val &= ~(0xff)<<8; val |= 0x50<<8;