Received: by 10.192.165.148 with SMTP id m20csp642348imm; Fri, 4 May 2018 04:08:27 -0700 (PDT) X-Google-Smtp-Source: AB8JxZojeeqGf/xfgUrLjuxnCgC7rNGJq8n5abhdPnbtugP0AGxgLdwZ2auleLPUMiS2sNmTNp9o X-Received: by 2002:a63:9c09:: with SMTP id f9-v6mr22379536pge.274.1525432107340; Fri, 04 May 2018 04:08:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525432107; cv=none; d=google.com; s=arc-20160816; b=PgRa2/uIDEAS7wt/0cNX0p8Na/SOFlEF4GLFu/SbOn0n3eUzB6MXOt+Yd/orvlP4Ja njkpJPCk7PCi7q0VrB67JPqLVvMdIGs+/WwWboJMCXwAvT9Ko4mXx93mRn71A4Mb08sZ VibP4mTZs9pTBRYjCmU1vgI5EPFIgyaeeAEX647oZ2a+1D1fyKmWHjPP4RguTi9zwG6B w87w7lTB0Ktruvz+IpUjKCMRcEc/cuQPqVwfREz5w4GcQ9dcKBk2Omlpmhkadd+Ge78Y UYWyScAVAqwhpmGerc2m0X/O0rCyGLsgJpZileteD6hwoSwd7bpruU1/DwEraBpNX4Nm +YAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=KX6gUnZEY2wet27qzRHoDiQHIpxqTYcEe+HWjVe/GyY=; b=nX2l/vbBge0MCJatwKWgg2Sha50gSA4JSlkhdThgDsig9cd4wjZPLTOVC9/jlLmRI1 X57oP/W5R59OwFoxDvZUmWtDB42ijB/ZTab1hb289YIO41uel3bqEfnlYkAoJpRnpIrT 9J5aNh4u22k44OC2NWAz9bpBjIC1QuYfiAB4axhwAOLSXeq0rYmH0FEjN3gbj1Cp/0NG IBCpXf4WeXtXnbIPqYYWEmwKAFZLhOAq4DMWy22T4X+vcMsSj/P+9vzjKvEYJwCXAwSK GgkrvFLq4r0SP7eI+y5rT9EHX75WAOFlZHXVFlDyrb+DQBIjZyAILNEnM2lyWghd42R5 HuOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si16207166pfk.342.2018.05.04.04.08.13; Fri, 04 May 2018 04:08:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751394AbeEDLH4 (ORCPT + 99 others); Fri, 4 May 2018 07:07:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:48904 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbeEDLHz (ORCPT ); Fri, 4 May 2018 07:07:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id ABD44AB3E; Fri, 4 May 2018 11:07:53 +0000 (UTC) Date: Fri, 4 May 2018 13:07:51 +0200 From: Michal Hocko To: "Eric W. Biederman" Cc: Johannes Weiner , Kirill Tkhai , akpm@linux-foundation.org, peterz@infradead.org, oleg@redhat.com, viro@zeniv.linux.org.uk, mingo@kernel.org, paulmck@linux.vnet.ibm.com, keescook@chromium.org, riel@redhat.com, tglx@linutronix.de, kirill.shutemov@linux.intel.com, marcos.souza.org@gmail.com, hoeun.ryu@gmail.com, pasha.tatashin@oracle.com, gs051095@gmail.com, dhowells@redhat.com, rppt@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, Balbir Singh , Tejun Heo Subject: Re: [PATCH] memcg: Replace mm->owner with mm->memcg Message-ID: <20180504110751.GM4535@dhcp22.suse.cz> References: <20180426130700.GP17484@dhcp22.suse.cz> <87efj2q6sq.fsf@xmission.com> <20180426192818.GX17484@dhcp22.suse.cz> <20180427070848.GA17484@dhcp22.suse.cz> <87r2n01q58.fsf@xmission.com> <87o9hz2sw3.fsf@xmission.com> <87h8nr2sa3.fsf_-_@xmission.com> <20180502084708.GC26305@dhcp22.suse.cz> <20180502132026.GB16060@cmpxchg.org> <87lgd1zww0.fsf_-_@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lgd1zww0.fsf_-_@xmission.com> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I am getting the following for nommu with MEMCG=y randconfig: kernel/fork.o: In function `mm_init': fork.c:(.text+0x948): undefined reference to `mm_update_memcg' kernel/fork.o: In function `mmput': fork.c:(.text+0x119c): undefined reference to `mm_update_memcg' make: *** [vmlinux] Error 1 I am sorry but I didn't get to look at it much more but I suspect you just have to move mm_update_memcg up before mem_cgroup_do_precharge. -- Michal Hocko SUSE Labs