Received: by 10.192.165.148 with SMTP id m20csp32839imm; Fri, 4 May 2018 06:17:23 -0700 (PDT) X-Google-Smtp-Source: AB8JxZreb6MlcDQiCnUJZZ8sedj74XygJM32YcIbV0uX0U/z1k1li4MFnfMG7UtibRKIfxRGudid X-Received: by 2002:a17:902:1665:: with SMTP id g92-v6mr28212536plg.195.1525439843808; Fri, 04 May 2018 06:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525439843; cv=none; d=google.com; s=arc-20160816; b=Okv7P3NdUrCiV2GJv/8NjfS7d317dxiVjN7UA5O63riH40IR2VbOMBRm7q6NGjEw47 p5g9SkL55YrmU1OHWJ11cknizf2OeEUQiOEJIau/UvuWm/Jc+6WMkYUYSbTDfLDYD1w7 hEPkD1v06MdfsoXX+mHXwYo1JIGrlVk7jS/V2JwHuA6mRoASrP/ztoQRRSaly70qDQ+Q uRXxGUI+tSU2Qqw8zRY24vv2Ts0hqURVqdHxbivvy1Ycn6C5nF7E3sl+tYwe28yHcPPR lCtkJjicIb+tnMcwl7PMWKiqLV/goV3RTllvNy8E69et/nesse2DZZ8yZsu0NfgpuzGM Fu6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=yOCRThAqK41vELlZLYfXZsvGmMEb5WuaH+O348hsxsQ=; b=kUjfSA0oWtsS6R4Z66AvZUkz0vRXMEmuapK/UKyDiUQzALXa8guEalRw0ubZ5OMya+ 4SSCsFZX4iTa29wzBcHvNAZgSoistCJvOT1xflN7Jw2ikd80CPYU7aomcIM2CkUfO0T5 dsf/kQ/zEfEFNyaxy/47Ee7LCpLfnfItOJIahqCj6N9Zybu2z8HvQXmYWTDyEz+IdYG2 k4iJ8eYZTfzvbHT3JfbD13wezgMMeOrJ/qBG+ay+uw1IcTFdhfcqrYekzq5E6Nxd1ClB 8BPDbzZ56wUUSHQymf1ZorcU3il3J5Yv4ZMnB3tBNi4iYDQNDT5appIKCixcIDv20xfI ne5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u47-v6si13456211pgn.488.2018.05.04.06.16.51; Fri, 04 May 2018 06:17:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbeEDNQi (ORCPT + 99 others); Fri, 4 May 2018 09:16:38 -0400 Received: from foss.arm.com ([217.140.101.70]:53186 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbeEDNQh (ORCPT ); Fri, 4 May 2018 09:16:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 307811435; Fri, 4 May 2018 06:16:37 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.207.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DADB3F587; Fri, 4 May 2018 06:16:34 -0700 (PDT) Date: Fri, 4 May 2018 14:16:28 +0100 From: Lorenzo Pieralisi To: honghui.zhang@mediatek.com Cc: marc.zyngier@arm.com, bhelgaas@google.com, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, ryder.lee@mediatek.com, hongkun.cao@mediatek.com, youlin.pei@mediatek.com, yong.wu@mediatek.com, yt.shen@mediatek.com, sean.wang@mediatek.com, xinping.qian@mediatek.com Subject: Re: [PATCH v7 0/2] PCI: mediatek: Fixups for the IRQ handle routine and MT7622's class code Message-ID: <20180504131628.GA8759@e107981-ln.cambridge.arm.com> References: <1525412853-24367-1-git-send-email-honghui.zhang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525412853-24367-1-git-send-email-honghui.zhang@mediatek.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 04, 2018 at 01:47:31PM +0800, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > Two fixups for mediatek's host bridge: > The first patch fixup class type and vendor ID for MT7622. > The second patch fixup the IRQ handle routine by using irq_chip solution > to avoid IRQ reentry which may exist for both MT2712 and MT7622. > > Change since v6: > - Remove the irq_mask, irq_unmask callback in lower layer irq_chip since we > have set the MSI_FLAG_USE_DEF_CHIP_OPS flags. > - Add irq_ack callback in irq_chip to handle edge IRQ. > - Uing handle_edge_irq to handle the MSI IRQs. > > Change since v5: > - Make the comments consistend with the code modification in the first patch. > - Using writew to performing a 16-bit write. > - Using irq_chip solution to fix the IRQ issue. > > The v5 patchset could be found in: > https://patchwork.kernel.org/patch/10133303 > https://patchwork.kernel.org/patch/10133305 > > Change since v4: > - Only setup vendor ID for MT7622, igorning the device ID since mediatek's > host bridge driver does not cares about the device ID. > > Change since v3: > - Setup the class type and vendor ID at the beginning of startup instead > of in a quirk. > - Add mediatek's vendor ID, it could be found in: > https://pcisig.com/membership/member-companies?combine=&page=4 > > Change since v2: > - Move the initialize of the iterate before the loop to fix an > INTx IRQ issue in the first patch > > Change since v1: > - Add the second patch. > - Make the first patch's commit message more standard. > > Honghui Zhang (2): > PCI: mediatek: Set up vendor ID and class type for MT7622 > PCI: mediatek: Using chained IRQ to setup IRQ handle > > drivers/pci/host/pcie-mediatek.c | 234 +++++++++++++++++++++++---------------- > include/linux/pci_ids.h | 2 + > 2 files changed, 143 insertions(+), 93 deletions(-) Applied to pci/mediatek for v4.18, thanks. Lorenzo