Received: by 10.192.165.148 with SMTP id m20csp102383imm; Fri, 4 May 2018 07:20:44 -0700 (PDT) X-Google-Smtp-Source: AB8JxZotcmjzmTQ/HJmk09rqAxKXj+XRL0Mm7NkYVZWSJTqFb5GEJpLgsLEj7B7l6iz8RsyN8LeZ X-Received: by 2002:a17:902:7488:: with SMTP id h8-v6mr28387897pll.124.1525443643995; Fri, 04 May 2018 07:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525443643; cv=none; d=google.com; s=arc-20160816; b=sy7Yw6QOwwddvqxOPurLMzgqZzNHLG6kXrem0KJ11hQo72R2oyJQA+LZwp7rbMLAEb UqJMKQAFnYKSFX2OGbkAX+jMhrzjNKwYHv0mLnFGiaNWUEW46/Ox5juTzwyFh4q5Ylfj M7f0c3kPsZOfk2n3zmUuGEzHQQlppXEWMNRp6Q8Q7sGcUZnrSRnAWsMbrBHREis/qFkN 2tVKKcE0z1PB5FGQs938IVFUJIkLmYYdKYcTYMId3M1Kd2RGPHsmqnNtpcTbVYDxJyuH AIN/uGq65Af5oG2d+d1VYp7ReYkzoyVwlGxOpxncjx1ex58Zm2x7EGhJvLiK/pCvmDQg 7Giw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=DdIGctgHhhV3koVUR8xil9IsQ6sZ75on5I+ljt60Lt8=; b=J3bIBUDdSgfefJdaEgY2hkKrP9VpsaTMX7xnf8u6binp/ZLDHlgB18iplzUopdgTts 98E/uhCGEGHjN+CwLv8WxkPXeHIdJXciyV84ukE04F1Q63RugeaopRjLXbhlSXjh8Aa1 CZkCQvCaqdxUTmjAO5BS4F+u3Ko39Ymf77lyrjkbdmCvgvOadXhn6lgTzFK5AzC29N/E 0IoAdwZO6cOg+TKyYwLOF4sIsL3Tptj/x/ClXcYiRVUrLcdH++raMvfFjQTGqkd+Vu7m Cn5zi6/+zzIVX8aPvFgZNEO1pMlRtZd7LlExWmLWCcPggUHTLtPrN1nnh1GMDSwiHHfW 8snw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=k/dUMshf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m39-v6si16082628plg.570.2018.05.04.07.20.29; Fri, 04 May 2018 07:20:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=k/dUMshf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbeEDOUN (ORCPT + 99 others); Fri, 4 May 2018 10:20:13 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:44716 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbeEDOUL (ORCPT ); Fri, 4 May 2018 10:20:11 -0400 Received: by mail-io0-f177.google.com with SMTP id d11-v6so25792112iof.11 for ; Fri, 04 May 2018 07:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DdIGctgHhhV3koVUR8xil9IsQ6sZ75on5I+ljt60Lt8=; b=k/dUMshfi6jljEB3nw7Yb2C5LMqp3ix4Zg6L0TSPDnreDfqDFIPLBVzY3OfLr4yD79 sdyuxySyBdCI8qCm4gwrRIzjW8PVkfG2AEs1FbLuBVEOkaR9AMEUajd1aS43HbfA6nSs 87YJANUQHrTKTRvW173bqw3MISAMq2WWaHVvWKoU7rqWEyFUYj3X9pii3hAQcLbI5tKi iG8FYY5iFyln5RjBovXH58l/jcYYWAp9JkiqLesDK0wSdk6pARcYsjXlMThdfIcB9pPm ja4430mVWSHhhZ6PQUb/jkytUiVlcWFJ5+KBYZBTrJ0SOHzyDA4LzEAJCpDST9ZL6OLk y/Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DdIGctgHhhV3koVUR8xil9IsQ6sZ75on5I+ljt60Lt8=; b=gbg5AoLtXPXsIQ8pdoSipLTIkdhpFqFHLFnzVsW/bJo25pv5GR/e+5vpAe36nX0VlL cHq7qV3+Y8NYRz2bXDRzrO/V8kiKHpUJqfmmUz9VWtE5vn+mNWsSaVrowBox648gQdRN /SZkvqBbIiRWlKda2EitW92X06FkFwwC+KMQzbN83zUVaUbWVEIcXz7+QENRbyo5yCI9 J98dPiZw1DKhnHk+kmAt8PeI/FVMnxyw5uZWPTxs8Xv9s/Tr2m07Jj++0vJps4eH7dML 3LWJh47DN1Q8ykay2olw3YZYfwfOx5WT8uQXTdPYzdTmZFhP3MKa3y0UBt//sG/RU9QI uYTA== X-Gm-Message-State: ALQs6tA6zAyK8+YREmJ9J7FppIKWp4qXiIQuFfikvPDMNh71eHp4lGgp baqnK5Ky7dwH0PQaRMLtQkDxig== X-Received: by 2002:a6b:520d:: with SMTP id g13-v6mr27578151iob.89.1525443610455; Fri, 04 May 2018 07:20:10 -0700 (PDT) Received: from [192.168.1.167] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id e72-v6sm8446885iod.51.2018.05.04.07.20.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 07:20:09 -0700 (PDT) Subject: Re: [PATCH] block: add verifier for cmdline partition To: Caizhiyong , Wang YanQing Cc: "gregkh@linuxfoundation.org" , "pombredanne@nexb.com" , "tglx@linutronix.de" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jiangheng References: <20180503111748.GA904@udknight> From: Jens Axboe Message-ID: <3267b3ec-0500-5772-949e-49570395085d@kernel.dk> Date: Fri, 4 May 2018 08:20:08 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/4/18 1:07 AM, Caizhiyong wrote: >> -----Original Message----- >> From: Wang YanQing [mailto:udknight@gmail.com] >> Sent: Thursday, May 03, 2018 7:18 PM >> To: axboe@kernel.dk >> Cc: gregkh@linuxfoundation.org; pombredanne@nexb.com; >> tglx@linutronix.de; Caizhiyong ; linux- >> block@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: [PATCH] block: add verifier for cmdline partition >> >> I meet strange filesystem corruption issue recently, the reason >> is there are overlaps partitions in cmdline partition argument. >> >> This patch add verifier for cmdline partition, then if there are >> overlaps partitions, cmdline_partition will return error and log >> a error message. >> > > Partition overlap was intentionally designed in this cmdline partition. > some time, the cmdline partition save raw data(not filesystem), the overlap makes data access very convenient. > > reference http://lists.infradead.org/pipermail/linux-mtd/2013-August/048092.html Might make sense to warn about it at least, it can be very surprising if it happens inadvertently. -- Jens Axboe