Received: by 10.192.165.148 with SMTP id m20csp106188imm; Fri, 4 May 2018 07:24:15 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqQcH1DiVJYuAHjG96E50gFDJ/cbUz32bNIemPZOgF+0c8XbzCREfU/aUkj2XPd/C+pg09q X-Received: by 2002:a17:902:145:: with SMTP id 63-v6mr28160076plb.332.1525443855870; Fri, 04 May 2018 07:24:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525443855; cv=none; d=google.com; s=arc-20160816; b=RE3f3KBQVPQSNvWzs8ZvbqAndZxn1Hp6ofHetFbKxSpVGkr1vbPINk1lXoL/UoEEDe IEA+j5QIuwuclMWCMcK6ZoEeNerrTXtk+RsFlfHML5QNBFehGsskuNHNUJAaygfM3wak HPA74+HQDb83KK370gG8cjC37f7oxJ4ik1RZRvYIAsp7uNFiHUfWmBaPvscHswWFdvhq zX4Nv67dgkavVOiWNSRZ2D2BcmXNEEf3oPwTmFtPeZ5R79AUvsy1RxmtpVOwwQ5FkD9d EidrSkWZAgVbw2fzWo7raDF5jFhQ2hdNOJMUwAQYjbYpzurR+7WAfqPFEe5wwgV7rGGF PJyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-filter :arc-authentication-results; bh=QNbq0FxeDT3M+aT56Ndfephh4DqHmJltwHKYFQP3Tn8=; b=kZ16D2Yz1wT3H7MXoTLWtHQyBDLZ/Sga+VfJ/EtB+FSlfRlVW91yCsPoWcUY/R2o/a j/O3C8feXFGaTdR+s2JVFBle5nnbsYDCAfCGrPHWtJOAyJ109yaPdX12kAgNaduUUI+a mDU4e9zwZhzHx4PxZO70P8TEZ9Ta5yAZv0YMTxxr6C79Tk+fsYvEo0YzCRYEnH3oe8Oq XrSYf9MzWGbpO6ForCXIBp+3lifF2sHLMOd4fzq+RGOCXq0yp8O11moB1HO6tis1au1a VcTLXY0GWACwhN/mtHfrvqrTXZe25PerCl9mz3AkjAQ71RkDaHKKma5kaSCCW9XkRXhn UfXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=cZ+RA045; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h62si15872117pfg.308.2018.05.04.07.24.01; Fri, 04 May 2018 07:24:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=cZ+RA045; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbeEDOWm (ORCPT + 99 others); Fri, 4 May 2018 10:22:42 -0400 Received: from conssluserg-01.nifty.com ([210.131.2.80]:34925 "EHLO conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751262AbeEDOWk (ORCPT ); Fri, 4 May 2018 10:22:40 -0400 Received: from mail-vk0-f51.google.com (mail-vk0-f51.google.com [209.85.213.51]) (authenticated) by conssluserg-01.nifty.com with ESMTP id w44EMWCk016220; Fri, 4 May 2018 23:22:33 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com w44EMWCk016220 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1525443753; bh=QNbq0FxeDT3M+aT56Ndfephh4DqHmJltwHKYFQP3Tn8=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=cZ+RA045kIpA8v7fIW59da/tDIx9w9IhwLRPDqpw+Dg6qiE7xP8ZHgb/9PYr3W8tM 9bbWiBJIp7g4nDHukMS1Icj+6LCO/V72i9sfVkmLdtc7FBK/8pwntMYaEnpnr4xEz0 aMVXs2/CG9HvRHmUHGEPQbPIq4XIQ38tqCcO6l27fO2g+mb3m9FnwiIoFtnZ1AL1D9 8b8x1Yym2awPrX2V9QhIJJp7xVn+92Z4D4zIOflrCSvCP5k3h9ShTVoQVkm7szP9Ib zZ3Bxp861o9pFfRmoB0R9vrQkRuW7pWW/xsTQ0Fc9jWKz2sweiUpxzkioUaEH+C9Cm 19EMrBUxf/SxA== X-Nifty-SrcIP: [209.85.213.51] Received: by mail-vk0-f51.google.com with SMTP id x191-v6so953238vke.10; Fri, 04 May 2018 07:22:32 -0700 (PDT) X-Gm-Message-State: ALQs6tBy1/kKgYh1KxVxoopf+Xw08f8kpMW7O8m3gW3qY02+x7T34h5U PUQrUQiroP8qYERQp2NMA517Cb9cvvqH3Mx+44U= X-Received: by 2002:a1f:8950:: with SMTP id l77-v6mr928631vkd.160.1525443751853; Fri, 04 May 2018 07:22:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.85.216 with HTTP; Fri, 4 May 2018 07:21:51 -0700 (PDT) In-Reply-To: <1523595999-27433-2-git-send-email-yamada.masahiro@socionext.com> References: <1523595999-27433-1-git-send-email-yamada.masahiro@socionext.com> <1523595999-27433-2-git-send-email-yamada.masahiro@socionext.com> From: Masahiro Yamada Date: Fri, 4 May 2018 23:21:51 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 01/30] gcc-plugins: fix build condition of SANCOV plugin To: Kees Cook Cc: Linus Torvalds , Sam Ravnborg , Ulf Magnusson , Nicholas Piggin , Emese Revfy , X86 ML , Masahiro Yamada , Linux Kernel Mailing List , Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kees, 2018-04-13 14:06 GMT+09:00 Masahiro Yamada : > Since commit d677a4d60193 ("Makefile: support flag > -fsanitizer-coverage=trace-cmp"), you miss to build the SANCOV > plugin under some circumstances. > > CONFIG_KCOV=y > CONFIG_KCOV_ENABLE_COMPARISONS=y > Your compiler does not support -fsanitize-coverage=trace-pc > Your compiler does not support -fsanitize-coverage=trace-cmp > > Under this condition, $(CFLAGS_KCOV) is not empty but contains a > space, so the following ifeq-conditional is false. > > ifeq ($(CFLAGS_KCOV),) > > Then, scripts/Makefile.gcc-plugins misses to add sancov_plugin.so to > gcc-plugin-y while the SANCOV plugin is necessary as an alternative > means. > > Fixes: d677a4d60193 ("Makefile: support flag -fsanitizer-coverage=trace-cmp") > Signed-off-by: Masahiro Yamada > --- I am planning to queue this up to the fixes branch since this is a bug fix. Do you have any comment on this? > Changes in v3: > - newly added > > Changes in v2: None > > scripts/Makefile.gcc-plugins | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.gcc-plugins b/scripts/Makefile.gcc-plugins > index b2a95af..7f5c862 100644 > --- a/scripts/Makefile.gcc-plugins > +++ b/scripts/Makefile.gcc-plugins > @@ -14,7 +14,7 @@ ifdef CONFIG_GCC_PLUGINS > endif > > ifdef CONFIG_GCC_PLUGIN_SANCOV > - ifeq ($(CFLAGS_KCOV),) > + ifeq ($(strip $(CFLAGS_KCOV)),) > # It is needed because of the gcc-plugin.sh and gcc version checks. > gcc-plugin-$(CONFIG_GCC_PLUGIN_SANCOV) += sancov_plugin.so > > -- > 2.7.4 > -- Best Regards Masahiro Yamada