Received: by 10.192.165.148 with SMTP id m20csp138420imm; Fri, 4 May 2018 07:56:57 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpV70CRE0UG0y5/SOsTD0/GBanZcs4LgMbelPvfcanDF2rt9QStBWiHi3u2bfQXsmtXMBiq X-Received: by 10.98.150.92 with SMTP id c89mr27354301pfe.37.1525445817428; Fri, 04 May 2018 07:56:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525445817; cv=none; d=google.com; s=arc-20160816; b=M0QPbptjKhRC0ZYqbfK4xefnz4lGx9+cNNEB4M+BYRb54qOIeuuwYHC46FTPbLqRQr zcTPHq3fXuiURxuZe52tZGm9OMZffKFJJ6k3jxtn170iXyEqFo3ToHtRHlfRZif9vN4v 3bbnW/ACE48TqUmkospqvsXGyAqYHYEvggQYj+eHeBnYAMXS8wuhUnGy0qaf7WlKoSmV 1KA1LNMRon0zZAYh414+2jYZYtJF9hYXBb/79aWskvMtBvqRZAvLlQ3belNC+clQ0k5i u5YvKLwjbEA+zqgyS7NijW7LCEO0L50YxrarTaJ45/ZE3i0uIMwk7nl1DnUjaQ0P7Veh jFZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ToZj+bYpWym3xRVgBjUGOGVDjno65i0ZfNwFO/vfLO0=; b=kNCywqnKOYO9QJmDGx5JJjY4q52OmK8NEB/IOgLRmLzmamLD2m9+VlXyMbbhkzrfMs MWfVZO/+vfjlbZ13e6yFit29dUba77+4p4OOQLUH/ol3vo1ktrX1qnl5iGx9kyl17a00 D9mBBjMm94we9BxkwpCsrb/nFUry0WiMh13k4bN8uLXkokClY5A4R2v5zan5np1YPZPE keX3HkMRJmqtThTLANEgmCLMyTUWS0VLSmNH8i31sSq7DGR6H4w7IvhLD31M/yz873YB vc4xgU+Z3H6YBli6wOliz2QjT7+LJP+W3af5+ug74+gf1OOltSmnVFXwKOfuMQpFe4Ue I+nw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e68-v6si15708268plb.566.2018.05.04.07.56.43; Fri, 04 May 2018 07:56:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbeEDO4b (ORCPT + 99 others); Fri, 4 May 2018 10:56:31 -0400 Received: from foss.arm.com ([217.140.101.70]:54714 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbeEDO4a (ORCPT ); Fri, 4 May 2018 10:56:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 890461435; Fri, 4 May 2018 07:56:30 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5440C3F25D; Fri, 4 May 2018 07:56:29 -0700 (PDT) Date: Fri, 4 May 2018 15:56:26 +0100 From: Mark Rutland To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, aryabinin@virtuozzo.com, dvyukov@google.com, mingo@redhat.com, peterz@infradead.org Subject: Re: [PATCH 1/3] kcov: ensure irq code sees a valid area Message-ID: <20180504145626.gup5ytwt3uqt57xm@lakrids.cambridge.arm.com> References: <20180504135535.53744-1-mark.rutland@arm.com> <20180504135535.53744-2-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180504135535.53744-2-mark.rutland@arm.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 04, 2018 at 02:55:33PM +0100, Mark Rutland wrote: > In kcov_init_task() Since we update t->kcov_{mode,area,size} with plain > stores, which may be re-ordered, torn, etc. Thus > __sanitizer_cov_trace_pc() may see bogus values for any of these fields, > and may attempt to write to memory which is not mapped. Whoops; that 'Since' shuoldn't be there. I've fixed this up locally. Mark.