Received: by 10.192.165.148 with SMTP id m20csp169557imm; Fri, 4 May 2018 08:24:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqYISGzuavTRHc42YRQPDYZ8dpfQS4pgUJdhKOzvZ5SmhO1RlrMT+be9iBSrQ9OeT2hD6bQ X-Received: by 10.98.55.69 with SMTP id e66mr8962633pfa.43.1525447447894; Fri, 04 May 2018 08:24:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525447447; cv=none; d=google.com; s=arc-20160816; b=s8BDXefD220+CyGQtPfayTOi+8e9VcVhD8uIoUWUr/bfLn0U+2XN/EgEutpVp0V67w lTNx0iy9KIPOFleTEh7LYuJJMa1mpmzWChVn5YnRl26uXYrbeLnK+0ifQ+ghrHUD+c5c fzKavBGAEe5DUPSfbzD1TJ8D+IurYirrTKzJ+2nUMjEomb1eSavcBGZZDoffiP5zZg+O zQvCsm7DJkPBVqfmNpf+r4WHNBhb5UyLJY+XbnJcTJAiUWsf5QC46QzuChOupSs+XXY9 8i+HoGGgm+cgdTPuj9vUUfbDCZ2nhpqjQ5ipu21JLIwTqYurMbLkngkR5R67V47IHxJa yVHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=VYYlm1CHQ//+REwLLBpz7ssWkWchdVNqySJQUkvm/cE=; b=zXYIyMZZv2c86BXBeArZlSdVRz969vfpbNsvXiIy7rKzbXNhaOEGFMplKjiMBJ8Cv4 lfhGEBv6rFxqp5CgTnhXe9akJqMQvfs4oV9DRkJ39ACZLnqyX0j/3X6vNzLc+FJNGhwA kpaEtQWqSwRJGdKR5xZCga/lJOclcMB/3nKfsUPj9u6cosenVAb00VvzgiYaUvIqf77h GyBkQhI2ikTsNjItj4jFZmzwIZe3pgkZFIMaFJ2wxGZYodx/4zEJIv+5E1XJA95qsIez I4h4BKXZuuMEH+4hkhlEYDjAU62ji+UQ7eMZN8fV04XuWxw6Lro9CiTkm7adHmyemD5R 6u9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=FUvgWkZh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x17si15818058pfm.330.2018.05.04.08.23.53; Fri, 04 May 2018 08:24:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=FUvgWkZh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751423AbeEDPX3 (ORCPT + 99 others); Fri, 4 May 2018 11:23:29 -0400 Received: from mail-ot0-f195.google.com ([74.125.82.195]:43464 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbeEDPX1 (ORCPT ); Fri, 4 May 2018 11:23:27 -0400 Received: by mail-ot0-f195.google.com with SMTP id y10-v6so24865327otg.10 for ; Fri, 04 May 2018 08:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=VYYlm1CHQ//+REwLLBpz7ssWkWchdVNqySJQUkvm/cE=; b=FUvgWkZhtXFcBRrnT6aAWWoevJkKYtxXoT//QOX+W6U3ZSRRvE/dfDsjZ2bRSxUW0b AsHjCVJFoyU5TJMB1OW1InZRQea4yGDErqCqMjbtBZYC39zpH5w2FvMO6a1TfiofBKJc EQwIxwEY7VQSyLUvSaSYbIRiwQTG3mpw5QQSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=VYYlm1CHQ//+REwLLBpz7ssWkWchdVNqySJQUkvm/cE=; b=V7gJ6h2/L+dbFh95txvZ9rDQ3TCRQdLZ7DIBjI4inLRA03h1OPjTAiGxVvjisuEXBi en7RqyH5sdd+nBDYpoD3ejDMAWQEN8hrIS8memcSUzIhhaWHOXBEl1XMpjQ7hL6TpcXE RKgNsSv8N7tbK5L+LqN/GK4ztN4oy4wsLil8Lxq0gRIL0BuIGlHw8vMb5uMJW82eTKRN gm6ANLn4npuUlOZQViZlW5BeyITPGKQhKD4pEoGLc+T/iqLY8PBp4PoMAKOP5hp+PLJf 2hGpKb0bFIW0e2ByY26buhicV6XpZYOkoF8uMMzfFOf2xDjDVUXTvfguPP1w40oBqgUL 0eWQ== X-Gm-Message-State: ALQs6tAix4nkEmN+JWq7hlc+vilpqw6btlY0MqHCJ4Dbn7Db0L33XfVA eDNbHmyvyNQ3sb1hzl/m39D2Gnt7su/Yol/XmWpLtw== X-Received: by 2002:a9d:3bb6:: with SMTP id k51-v6mr14920503otc.83.1525447406900; Fri, 04 May 2018 08:23:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:5303:0:0:0:0:0 with HTTP; Fri, 4 May 2018 08:23:26 -0700 (PDT) X-Originating-IP: [176.63.54.97] In-Reply-To: <20180412150826.20988-1-mszeredi@redhat.com> References: <20180412150826.20988-1-mszeredi@redhat.com> From: Miklos Szeredi Date: Fri, 4 May 2018 17:23:26 +0200 Message-ID: Subject: Re: [RFC PATCH 00/35] overlayfs: stack file operations To: overlayfs Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Amir Goldstein , Vivek Goyal , "J. R. Okajima" , Ritesh Harjani , Matthew Wilcox , Miklos Szeredi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 12, 2018 at 5:07 PM, Miklos Szeredi wrote: > Git tree is here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-rorw Thanks everyone for your review. Force pushed new version to the above branch. Hopefully no comment was missed (I didn't add more reverts yet, those can wait). I'll do a mailbomb as well next week and start processing the metacopy patches. Thanks, Miklos --- Miklos Szeredi (38): vfs: dedpue: return s64 vfs: dedupe: rationalize args vfs: dedupe: extract helper for a single dedup vfs: add path_open() vfs: optionally don't account file in nr_files vfs: add f_op->pre_mmap() vfs: export vfs_ioctl() to modules vfs: export vfs_dedupe_file_range_one() to modules ovl: copy up times ovl: copy up inode flags Revert "Revert "ovl: get_write_access() in truncate"" ovl: copy up file size as well ovl: deal with overlay files in ovl_d_real() ovl: stack file ops ovl: add helper to return real file ovl: add ovl_read_iter() ovl: add ovl_write_iter() ovl: add ovl_fsync() ovl: add ovl_mmap() ovl: add ovl_fallocate() ovl: add lsattr/chattr support ovl: add ovl_fiemap() ovl: add O_DIRECT support ovl: add reflink/copyfile/dedup support vfs: don't open real ovl: copy-up on MAP_SHARED vfs: simplify dentry_open() Revert "ovl: fix may_write_real() for overlayfs directories" Revert "ovl: don't allow writing ioctl on lower layer" vfs: fix freeze protection in mnt_want_write_file() for overlayfs Revert "ovl: fix relatime for directories" Revert "vfs: update ovl inode before relatime check" Revert "vfs: add flags to d_real()" Revert "vfs: do get_write_access() on upper layer of overlayfs" Partially revert "locks: fix file locking on overlayfs" Revert "fsnotify: support overlayfs" vfs: remove open_flags from d_real() ovl: fix documentation of non-standard behavior --- Documentation/filesystems/Locking | 4 +- Documentation/filesystems/overlayfs.txt | 60 ++-- Documentation/filesystems/vfs.txt | 19 +- fs/btrfs/ctree.h | 4 +- fs/btrfs/ioctl.c | 6 +- fs/file_table.c | 13 +- fs/inode.c | 46 +-- fs/internal.h | 17 +- fs/ioctl.c | 1 + fs/locks.c | 20 +- fs/namei.c | 2 +- fs/namespace.c | 69 +---- fs/ocfs2/file.c | 10 +- fs/open.c | 74 ++--- fs/overlayfs/Kconfig | 21 ++ fs/overlayfs/Makefile | 4 +- fs/overlayfs/dir.c | 33 ++- fs/overlayfs/file.c | 506 ++++++++++++++++++++++++++++++++ fs/overlayfs/inode.c | 63 +++- fs/overlayfs/overlayfs.h | 21 +- fs/overlayfs/ovl_entry.h | 1 + fs/overlayfs/super.c | 65 ++-- fs/overlayfs/util.c | 11 +- fs/read_write.c | 91 +++--- fs/xattr.c | 9 +- fs/xfs/xfs_file.c | 8 +- include/linux/dcache.h | 15 +- include/linux/fs.h | 30 +- include/linux/fsnotify.h | 14 +- include/uapi/linux/fs.h | 1 - mm/util.c | 5 + 31 files changed, 886 insertions(+), 357 deletions(-) create mode 100644 fs/overlayfs/file.c