Received: by 10.192.165.148 with SMTP id m20csp277784imm; Fri, 4 May 2018 10:08:28 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpegAbampYyXO73/NeZvcc+8bB4q2rrYmwaJOzlHWose7nbITRWx555aLwHy8j3MMf6jA94 X-Received: by 2002:a65:5504:: with SMTP id f4-v6mr8647850pgr.177.1525453708489; Fri, 04 May 2018 10:08:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525453708; cv=none; d=google.com; s=arc-20160816; b=RoAtyzHEsrbGoHZCMr4bzQ7I1242h47b1H9AWZcgrk+7JyRe5cn7ouSPuXQH/Ts81q tsgo/AAsy3IY6wGema4uib/fBjnNOm0GlQcbn+JgEg4fU9ImGpLE25iI9Y6ZxHtBL5yQ 1zTDDECFKDa4LVx1dJs0MG0y3arpoLf4rAMoP/KOWu5y0Bn42m/gBorMQdrMLaUdIVe4 BC4JUyCNt349MnGrdN2stAjrQZhnCrMa7rvsKuYXC4R5ugjYMXc5RD+rdBPdO7eIPP3A VFBvM11dn5eYMLxMeYjcNIrmfQQ4y1TOBUBDWz0XSDktTuAKH09xawvB7FRkpc1IH6s/ NSQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=khD7PNrWi8mhXVVNi1Jw+de6bNCAy3J9VOD9LQKfFnA=; b=ODrZK8wx+1cYI1ijHXjWwqwBHvGvOw5InuLTyrv9CMhzMML9dF1a8aegGOXS6/zeTJ iS2CtJLDpejmKvtv+6PdPwLbmY3e0G/12emOlLlRfBmYr6qQxal0iKRWU0wGd/nfM+W8 KBfkMj5NY60RlWWGfm8xhEK1eFN144G838VBCWdhEjE++638Oi/KIBA5l+BO/HnTCADT KbOn4vtPReE8OKr0ovduKGf8UNHVd2pyqLJ9rCtaPa5TkNNiWCu62mlUjuCrbWU8DXlA DiQyYbUabkxtXksiUTMsqSdNYlcmUM9jJbr8a32BNuD02DmiDfJHkioEwaLGjlWCf38o ujGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pu81S4n9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i64-v6si1614324pli.274.2018.05.04.10.08.14; Fri, 04 May 2018 10:08:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pu81S4n9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbeEDRH7 (ORCPT + 99 others); Fri, 4 May 2018 13:07:59 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:45341 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbeEDRH5 (ORCPT ); Fri, 4 May 2018 13:07:57 -0400 Received: by mail-pf0-f194.google.com with SMTP id c10so17891741pfi.12; Fri, 04 May 2018 10:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=khD7PNrWi8mhXVVNi1Jw+de6bNCAy3J9VOD9LQKfFnA=; b=pu81S4n958FbGlcafy+qPwrZ4FWoYbfq47gm1rhuLmOcAw1s1zTzOt6u/1Xmvpt0m/ 4acm93athnRF4hLwOXxXBU8LHDNJEEBs7vybo9pRyNlgGIJVAtGp6XWEQZYE14ss7Niq bnfQmjjp2j4mM0gibmjFQioPxAH81n0pymkFYa3OatI02j610rqXKi9++KTebym7lDlD kZTr8QCIg3eylbLPFLditgC5pTZ5ORfaX20RZ2QBMov6AfpeyS9Jen0wrrxDEguswKUl 3iV2NhoMmIrjS0+U3dgSaJdcNtpfLD7A85EXwv7hG56j11EbQywGhKglhAJR3MeHHSDI dWWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=khD7PNrWi8mhXVVNi1Jw+de6bNCAy3J9VOD9LQKfFnA=; b=pLWiSox/YXQF1KYKzl2tefFwA1JyQRcNyEuKCr8D0B9gnStQsA/8ldRQcKlaJGzoPX 8EhCiSNR/P0zxc5cepVCTIcHNxTuoXVuOTsa9NdC3PoK5460HLiuaV9Xu/YFRiCEpF9Z MGlnfQaCYtHy4dlDSVUeFN6+g+s5Ld6YPry+iTfp4yUHpwL6PRAK3j7SAO4ctHjSjdXg /d9zsirhddlGQQ/nKcLf6KcDiqiHh/UxhdBIqOCRj6wFYjSZd94uQ4+/weQV5+Z5UlKC KhgaO4+4KWlqHQXEd1WDg3YlkE3iUu2W0VWdQI31ADLAv5JmYHMehD5/CY8gPM09BXhC n00w== X-Gm-Message-State: ALQs6tBUS1/K483SzPdBI9MAwCyU8XlzzoeeCAfVl5BHpout/8NMq2dA EKJh6JxSzFSbxNTzclcZZXE= X-Received: by 10.98.47.2 with SMTP id v2mr27696885pfv.239.1525453676291; Fri, 04 May 2018 10:07:56 -0700 (PDT) Received: from [10.69.41.93] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id i1sm14087615pfi.133.2018.05.04.10.07.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 10:07:55 -0700 (PDT) Subject: Re: [PATCH net-next v2 03/13] net: phy: sfp: warn the user when no tx_disable pin is available To: Antoine Tenart , davem@davemloft.net, kishon@ti.com, linux@armlinux.org.uk, gregory.clement@bootlin.com, andrew@lunn.ch, jason@lakedaemon.net, sebastian.hesselbarth@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com, linux-arm-kernel@lists.infradead.org References: <20180504135643.23466-1-antoine.tenart@bootlin.com> <20180504135643.23466-4-antoine.tenart@bootlin.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: Date: Fri, 4 May 2018 10:07:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180504135643.23466-4-antoine.tenart@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/2018 06:56 AM, Antoine Tenart wrote: > In case no Tx disable pin is available the SFP modules will always be > emitting. This could be an issue when using modules using laser as their > light source as we would have no way to disable it when the fiber is > removed. This patch adds a warning when registering an SFP cage which do > not have its tx_disable pin wired or available. Is this something that was done in a possibly earlier revision of a given board design and which was finally fixed? Nothing wrong with the patch, but this seems like a pretty serious board design mistake, that needs to be addressed. -- Florian