Received: by 10.192.165.148 with SMTP id m20csp440906imm; Fri, 4 May 2018 12:48:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZodgi1bHXZpCj8VKoHAXRFMrL2L05n47BG0TkygzbNZV1t3qjquE7wxjyotbQdIhsrD63d1 X-Received: by 2002:a17:902:41:: with SMTP id 59-v6mr29348081pla.345.1525463294556; Fri, 04 May 2018 12:48:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525463294; cv=none; d=google.com; s=arc-20160816; b=MLQJCbsWIvPlQgjsnrKUloWSTwk/nCkUxaJx0mb+TlQEeGhSGAhZ94uiitok7g0xM7 C1ELt/tjj+jQRwuybhsDsHLDl8hReSxZwxMaWMe6VNTCLDWcEhMGB0nnnTSJicX4BQhg VUR7C0i0CWI7kO200XJsZkO9WOmdA4Hv5IPBN16w2r8mUFXNbFGVL7A09QouTKDQJXC1 BRKi0BAj8QLazfjv6odTTAYXzjtAdfDPGTVSOKCYsnww4w4hdhnkg9o94svRgaOttYie KcnoknLT4851EKL7sU9ouie1eKIXgbs8YRFuYAXPdm7pRM7jO2eKUtsLUqE3DnvBKsGB SDBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=1zZXJKeKaszj8jWNS7LLDmXgE8w7Nr0Z/MXQRgwvqmk=; b=RBBk6AcYZDttO+wv/ncYcY9V3N1eSxf6lbB4Qfk+kEBDho4wiCyhsRtKpbYDTISt7d PVdKw22D6aJ4JC//NwY5zL3aa9KIKgKatYLXOvYopzI7m0h2RbQPWrhmZoBJ23UhFQX1 Sd8ZdApX0jlqX56kv0GYNWvU1xazUof5q4bMDC0zogAadTdG1946sWY56bbVToQj7J2X LLS4T6HGwHZ5QZEinr4W6fcxTXt71XXkweWMKtmexXzjcyd1V01jWohc7bjOlxPdM9qX dUG1iyblNsFa09jXqRo80hRn8xRyss1hU0qbroZx7XATZhZzsje2DaR52C0NPOCMnguD TTeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=CPPX4BeS; dkim=fail header.i=@chromium.org header.s=google header.b=Lf1LLJSu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r126si3737994pfc.202.2018.05.04.12.48.00; Fri, 04 May 2018 12:48:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@google.com header.s=20161025 header.b=CPPX4BeS; dkim=fail header.i=@chromium.org header.s=google header.b=Lf1LLJSu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbeEDTrc (ORCPT + 99 others); Fri, 4 May 2018 15:47:32 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:34412 "EHLO mail-ua0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbeEDTra (ORCPT ); Fri, 4 May 2018 15:47:30 -0400 Received: by mail-ua0-f194.google.com with SMTP id f22so14777479uam.1 for ; Fri, 04 May 2018 12:47:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1zZXJKeKaszj8jWNS7LLDmXgE8w7Nr0Z/MXQRgwvqmk=; b=CPPX4BeSQH2xUik2dBlAAriXt98LoLEXMcw8C7MKfPhzFfApAqcRH3UQQ++I2g1qWD wp21ncLrN5cT8pGwksoS0wkMUvr2hRCgmTFG1sswmwXuD3HCtzyOU0pOpKY+ix8pCAhy IcUhvCm1JGf5wO5wdrsnP16M/5wFJYeLQzbpcMXzwxrMbVxa9e0NW5FCJBf0TlENeWUT A1pi6aV57eMdIzJrnvCb3wf/wJFhgR9XY0fGd7kX79LuEW9DBMdOW2iAaFCu4oxi/v6N fV6fx4BGGAhs/Bq8KWfyHv4vStQQLsnikLQCcKQcr6vGFbdzWOOL5Wu3zKH8+UrZrPCu kNRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=1zZXJKeKaszj8jWNS7LLDmXgE8w7Nr0Z/MXQRgwvqmk=; b=Lf1LLJSu8tSS5iQ1f16wIw38QWYwKS773hzlQaF5SUt3Tcu2c3ZlpeK5C6RY8PIjXl t4cJUsY2GuP1LPpeMR++7AVSDVUvQxzeRoQi/YBzAjSMHaGmFCvTHkMZ8Cvnfebknak6 aMaSrBCDaZhZvtKt8lrTjWUq7+OZcZpnGP3eU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=1zZXJKeKaszj8jWNS7LLDmXgE8w7Nr0Z/MXQRgwvqmk=; b=QJZWSFffltBqfkQDM/Ra3kB6xrIJPccF906zwP+H5EK0ElHI5oBtGCqM/vw9E44qQQ de3UzKDuu/SLDMTeGh1v55ovPVq83NUYgxR0F0B/iihG3AGLxOIZP+fMOVBXTcizr4qu FzK7ZXNrATbPHNb01Qv+PaS/StblzlCnMp0LqIulIH8mc0L7JcTkY+niEngznTFTJgS9 p/1lPbUqe84ZXwJsUd16T5B832eZa4g221ByJnGGkpVYmeWfzmjGBp7p751++0rr0duw v1NSy/s5MNCewOm5SlOJ9Imhk+rLN009nehk2BeglrN3XkhfiKFs0Dfv5TCG1qdJqTg6 pprw== X-Gm-Message-State: ALQs6tALR8pSVs/Utcmr2S3x85nlM8ZaUH8M7Rhpi26unIYDUxwexqnn AsMOKwZpJ5e09rRT/hUNYgYafjHOJPIwDNvdnG22Uw== X-Received: by 10.176.90.114 with SMTP id m47mr8832590uad.37.1525463249329; Fri, 04 May 2018 12:47:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.48.82 with HTTP; Fri, 4 May 2018 12:47:28 -0700 (PDT) In-Reply-To: <1525295174-15995-8-git-send-email-mgautam@codeaurora.org> References: <1525295174-15995-1-git-send-email-mgautam@codeaurora.org> <1525295174-15995-8-git-send-email-mgautam@codeaurora.org> From: Doug Anderson Date: Fri, 4 May 2018 12:47:28 -0700 X-Google-Sender-Auth: qIiz_EhUCIf7jYwfu90uegA2-pg Message-ID: Subject: Re: [PATCH v5 7/7] phy: qcom-qusb2: Add QUSB2 PHYs support for sdm845 To: Manu Gautam Cc: Kishon Vijay Abraham I , Rob Herring , Stephen Boyd , devicetree@vger.kernel.org, LKML , Evan Green , Vivek Gautam , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, May 2, 2018 at 2:06 PM, Manu Gautam wrote: > There are two QUSB2 PHYs present on sdm845. In order > to improve eye diagram for both the PHYs some parameters > need to be changed. Provide device tree properties to > override these from board specific device tree files. > > Signed-off-by: Manu Gautam > --- > drivers/phy/qualcomm/phy-qcom-qusb2.c | 126 +++++++++++++++++++++++++++++++--- > 1 file changed, 118 insertions(+), 8 deletions(-) I confirmed that all my previous comments were fixed and this looks nice to me now. Reviewed-by: Douglas Anderson