Received: by 10.192.165.148 with SMTP id m20csp1489306imm; Sat, 5 May 2018 13:27:30 -0700 (PDT) X-Google-Smtp-Source: AB8JxZreNdesVi6/4lAi9pKFok/gHE+frtV/nNgvm7f9sK88TdUS33/VAWfyOznLno3/iO4/Vs3/ X-Received: by 2002:a63:7150:: with SMTP id b16-v6mr25992970pgn.326.1525552050214; Sat, 05 May 2018 13:27:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525552050; cv=none; d=google.com; s=arc-20160816; b=QOBULVUCKtKjkVn3ITJXOh9U9zl8+t7TdVYwOFKi/fplum2hNz533Hz083Ag4SKe4b /o1Po+rXHAErIRRcDSCTFGzrP67UBUPpzKOJ9SsK0RejItiioUqFqMNQxAYoOpb7WDTf C6feNuwSiF/+fMoDGzYzHwT9XudpiNhnq7H78SjNN6unkxz/nB/dzw+GK07OU4zC5W0i bT5q68juKun+s0gh8DKOOiBQrb8JGpq+rOt4N7B+w8xsy3k86+lXDhHOb73hpJcCWEHN xunhmbQ3ZOO8W3lZfw73bN+CShdQRwDvaOrkNPmJ//ZB8L1ZLUQxpLUG8oC1zyJ2Q1EJ 2yLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to:date :references:subject:cc:to:from:arc-authentication-results; bh=Kj6FKB6Df8UGjwwauhyzgpKIImCOH9UBLFWq1e8D++k=; b=BE11vA7hdC8zlUz0nfJcqigCXaBNhoZHUBhrIV+rq4U/vxbShzgbrDTunAEdj0dSgH ifjMSWKIkgNKTUlVeDwbjiH1Mj6XYe4YWG4XOocATWbMNcyGRhJclGIm/4KOXCmuMQRy hTnZ3cL9U4Oj++yROSEwG4oVMuC+E0X2ze1t8E4VdQc5PAGexuFuXA/vC8kDCeh8LHZJ QLMEOTqFRP+L65mcFBIEEKk6bLh6GpsL5fcRrw6+n8Rc1InIKHETZyiACo/QuzI34Cl4 QWiT/ec04pP59gGzZN7j4x/S2t7YwneoAm8dXEui9VkCvPtdBmOEmC2Myn8sC/mW/uiu wGTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c8si19054796pfj.138.2018.05.05.13.27.16; Sat, 05 May 2018 13:27:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbeEEU0x (ORCPT + 99 others); Sat, 5 May 2018 16:26:53 -0400 Received: from inx.pm.waw.pl ([91.202.125.194]:53364 "EHLO inx.pm.waw.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751860AbeEEU0v (ORCPT ); Sat, 5 May 2018 16:26:51 -0400 Received: by inx.pm.waw.pl (Postfix, from userid 2530) id 4BF562993E; Sat, 5 May 2018 22:23:46 +0200 (CEST) From: Krzysztof Halasa To: "Luis R. Rodriguez" Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, keescook@chromium.org, josh@joshtriplett.org, teg@jklm.no, wagi@monom.org, hdegoede@redhat.com, andresx7@gmail.com, zohar@linux.vnet.ibm.com, kubakici@wp.pl, shuah@kernel.org, mfuzzey@parkeon.com, dhowells@redhat.com, pali.rohar@gmail.com, tiwai@suse.de, kvalo@codeaurora.org, arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com, markivx@codeaurora.org, broonie@kernel.org, dmitry.torokhov@gmail.com, dwmw2@infradead.org, torvalds@linux-foundation.org, Abhay_Salunke@dell.com, bjorn.andersson@linaro.org, jewalt@lgsinnovations.com, oneukum@suse.com, cantabile.desu@gmail.com, ast@fb.com, hare@suse.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, davem@davemloft.net, maco@android.com, arve@android.com, tkjos@android.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v5 0/6] firmware_loader: cleanups for v4.18 References: <20180504174356.13227-1-mcgrof@kernel.org> <20180504195835.GU27853@wotan.suse.de> Date: Sat, 05 May 2018 22:26:46 +0200 In-Reply-To: <20180504195835.GU27853@wotan.suse.de> (Luis R. Rodriguez's message of "Fri, 4 May 2018 19:58:35 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Luis R. Rodriguez" writes: > So we can nuke CONFIG_WANXL_BUILD_FIRMWARE now? I'm uncertain I understand why do you want it, or maybe what are you trying to do at all. And what use would wanxlfw.S (the assembly source) have if the option is removed? >> It's more about delivering the .S source for the firmware, I guess. >> Nobody is expected to build it. The fw is about 2.5 KB and is directly >> linked with the driver. > > :P Future work I guess would be to just use the firmware API and stuff > it into linux-firmware? Who's going to make it happen? The last time I checked (several years ago), wanXL worked. Who's going to test it after the change? I assume linux-firmware could include fw source and there would be means to build the binary. Just to be sure: the wanXL firmware has exactly nothing to do with FW loader, nothing depends on it (nor the other way around), it's just (with the rest of the wanXL code) an old piece of a driver for an old card. The question is, what do we gain by messing with it? -- Krzysztof Halasa