Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Martin Steigerwald <martin@lichtvoll.de>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        Matthew Wilcox <willy@infradead.org>, dsterba@suse.cz,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jens Axboe <axboe@kernel.dk>, linux-m68k@lists.linux-m68k.org,
        Debian m68k <debian-68k@lists.debian.org>
Subject: Re: moving affs + RDB partition support to staging?
Date:   Sun, 06 May 2018 12:12:22 +0200
Message-ID: <5644198.Giea1MT2Lg@merkaba>
In-Reply-To: <20180506005946.GI30522@ZenIV.linux.org.uk>
References: <20180425154602.GA8546@bombadil.infradead.org> <76ca15e2-7b43-8b02-43e1-9ee65ab85356@physik.fu-berlin.de> <20180506005946.GI30522@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Al Viro - 06.05.18, 02:59:
> On Thu, Apr 26, 2018 at 12:45:41PM +0200, John Paul Adrian Glaubitz 
wrote:
> > Exactly. It works fine as is:
> > 
> > root@elgar:~> uname -a
> > Linux elgar 4.16.0-rc2-amiga-16784-ga8917fc #650 Mon Mar 5 15:32:52
> > NZDT 2018 m68k GNU/Linux root@elgar:~> mount /dev/sda1 /mnt -taffs
> > root@elgar:~> ls -l /mnt | head
> > total 0
> > drwx------ 1 root root      0 Mar 30  2001 Alt
> > -rw------- 1 root root   1352 Mar 27  1997 Alt.info
> > drwx------ 1 root root      0 Nov 16 14:39 C
> > drwx------ 1 root root      0 Mar 27  1997 CS_Fonts
> > drwx------ 1 root root      0 Mar 27  1997 Classes
> > -rwx------ 1 root root   1132 Aug 14  1996 Classes.info
> > drwx------ 1 root root      0 Feb 10  2004 Commodities
> > -rw------- 1 root root    628 Jan 14  2002 Commodities.info
> > drwx------ 1 root root      0 Apr 10  1999 CyberTools
> > root@elgar:~> mount |grep affs
> > /dev/sda1 on /mnt type affs (rw,relatime,bs=512,volume=:)
> > root@elgar:~>
> > 
> > There is nothing at the moment that needs fixing.
> 
> Funny, that...  I'd been going through the damn thing for the
> last week or so; open-by-fhandle/nfs export support is completely
> buggered.  And as for the rest... the least said about the error
> handling, the better - something like rename() hitting an IO
> error (read one) can not only screw the on-disk data into the
> ground, it can do seriously bad things to kernel data structures.
> 
> Is there anything resembling fsck for that thing, BTW?  Nevermind
> the repairs, just the validity checks would be nice...

I am not aware of the fsck command for affs on Linux. There is a 
partitioning tool called amiga-fdisk, but for checking a filesystem you 
would need to use a tool under AmigaOS.

-- 
Martin