Received: by 10.192.165.148 with SMTP id m20csp2467445imm; Sun, 6 May 2018 15:51:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr0sPWyzgpmUdpsAuc3+J3nwU0fFGHHcF9XljQ+ggeF4HfKDW7TndLD1q4DuBBQZw7AGNFJ X-Received: by 2002:a65:4ed0:: with SMTP id w16-v6mr11588468pgq.41.1525647097797; Sun, 06 May 2018 15:51:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525647097; cv=none; d=google.com; s=arc-20160816; b=FcOOFj8Z1USCb+WtyqIcvrvWJUVzeipHCGvw0ltQft8bs9O5g0E8xHpqX5HgfRGAh2 yRnx+phn1g8n4ik51oD63x1aSw7qLZYP/3wPN47NGdrKmfqkUOeCna5tsEb0MvtRs/mM 5wnoH5h693h1WwdisZHON+77zFHw795gA4tsxfMGyyO8ub2AV+3jGtD4TGU6tuMT4tqJ 0uYWYcZY9w6s6R/M5B0KomDyX8EEyWvLQakOPMsZminH1eTg45Fe3I3iFPPGp99wq9PS TRTXBGDjz9Z6D/Iljd8Rn0Uy9FVP2kVxQM2iRIJ/eXVwEy1dMwfXub6uRxdT0gd4SuZA pQpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=G391Zmih1LjohO7IRf32vNqtd1TH9EGcZ2xc1iB9Cig=; b=0VFcYwb+1aTzcMDzLXDwinOyv5Ntx9C8kIj+ayQKlbPyhScVFWi7ZtBlxh/evo2S2Z UK/+3yu2tLmH4SHCELPrsVo/DbN+XZyB/Uuvn27LjGmblbu/Jfb8HVLn9UHdfV22pejm bBMAZWjiSl5KvxDoHHbggF+pxu1O1S5B+NcoFktknBeLKoXWx9Cup4n0NyGcfor1O8uQ H6l9KCReQ1QWkVF3Zy4r1bI3XiJk792qJiB27S5HwzocZxtRly6zzJbRe0L3xyhC4Tbq phS6HxS1n8ZPsXX7gffOiIxDHOkVgJkjpP948lCI4x9YODxduHpG5CDay4nMhbm7erZN ZkrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gDzjZElj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1-v6si20785496plt.39.2018.05.06.15.51.23; Sun, 06 May 2018 15:51:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=gDzjZElj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752378AbeEFWuy (ORCPT + 99 others); Sun, 6 May 2018 18:50:54 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:46147 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752368AbeEFWut (ORCPT ); Sun, 6 May 2018 18:50:49 -0400 Received: by mail-pf0-f195.google.com with SMTP id p12so21300681pff.13; Sun, 06 May 2018 15:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=G391Zmih1LjohO7IRf32vNqtd1TH9EGcZ2xc1iB9Cig=; b=gDzjZEljKu1NfvI6W9xUufpZQX/qMUf9VhYHA9+3ZufKnZzkNrMPfFd/39B1IBCzVR miMMYSfgg++FvntlKh1COjc6U8bZJV/hTDlpLEDBn2sOeDEputExQ3f61vA94Fi7ajBY J++3vwXgjR0A8+e0nkBN4KJiw5xjYalIDd5DSuF7KjvwMxJ892uYwArB069myEHjQ0ag WNvb7lU8Qsbi3M6GFn3778McktN8pr0RDSwz7bDxYWrct/dhbEtHoS0Zr5m6hrK/KskZ FWpmL0Wl3QKYD35cfcBIs+z3UOTek7N0ddS+NH9qlnftvQUrzTEl2N0c4OTTdJZx0U9U T8JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=G391Zmih1LjohO7IRf32vNqtd1TH9EGcZ2xc1iB9Cig=; b=GGjGXvAPRkH34sxxEYogVxzUPeRNO3Vw9Nhl5pTduP5ug901gfM6HKnVpxBuFJ+5te wrQURBXBuVaLAk7vjsSZTb28ahbZbx0hwTvs92icFZZQSbx4t2aZ5aiKiPAQg6oVA9mh aKKvnE9D/Lv/HTNRiBEVZtinqT14kcQi1/wFWBDK8feu4lLhasZA4M9szbC76qDBD9DW 7w8rjgV81lqJwODbzwURVV83T8vgGChB9JgP2VeyHGQtAoR49B6AEfTfLWRhdljbbPK+ USfaeVP57laPtKOm19wDAWWhuJpLcVYYlS6/ZZ7XQeV5GS49Qi9sIPmZGjmiTxbo8emq yL/Q== X-Gm-Message-State: ALQs6tCCI6v/Z1OfAr5Jsdg+fa9C0bQLbd2yFvpal17BflwQRrl7HcTz moYAExy6y50+MVfVhWFBuKk= X-Received: by 2002:a17:902:290a:: with SMTP id g10-v6mr35807019plb.155.1525647048939; Sun, 06 May 2018 15:50:48 -0700 (PDT) Received: from localhost.localdomain ([2601:644:8201:32e0:7256:81ff:febd:926d]) by smtp.gmail.com with ESMTPSA id u86sm47783845pfg.71.2018.05.06.15.50.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 May 2018 15:50:47 -0700 (PDT) Date: Sun, 6 May 2018 15:50:45 -0700 From: Eduardo Valentin To: srplinux2008 Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, rui.zhang@intel.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] thermal: tegra: soctherm: add const to struct thermal_cooling_device_ops Message-ID: <20180506225044.GA25956@localhost.localdomain> References: <1523188905-3066-1-git-send-email-srplinux2008@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1523188905-3066-1-git-send-email-srplinux2008@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 08, 2018 at 05:31:45PM +0530, srplinux2008 wrote: > From: srp linux > > Correct the typecast with const to struct thermal_cooling_device_ops. > It is the last argument to the function thermal_of_cooling_device_register > and this argument is of type const. So, declare this structure > thermal_cooling_device_ops as constant. > > Signed-off-by: srp linux Please resend with your real name. Thanks > --- > drivers/thermal/tegra/soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c > index 455b58c..72da745 100644 > --- a/drivers/thermal/tegra/soctherm.c > +++ b/drivers/thermal/tegra/soctherm.c > @@ -926,7 +926,7 @@ static int throt_set_cdev_state(struct thermal_cooling_device *cdev, > return 0; > } > > -static struct thermal_cooling_device_ops throt_cooling_ops = { > +static const struct thermal_cooling_device_ops throt_cooling_ops = { > .get_max_state = throt_get_cdev_max_state, > .get_cur_state = throt_get_cdev_cur_state, > .set_cur_state = throt_set_cdev_state, > -- > 2.7.4 >