Received: by 10.192.165.148 with SMTP id m20csp2738967imm; Sun, 6 May 2018 23:39:26 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoUYhBH3NZZZiPxdpDTDVYGvR5Dvk7Sww40IHHzZoFZgbl2VH21RMuZ8fgryBV6xiPuXGAZ X-Received: by 2002:a63:6d81:: with SMTP id i123-v6mr29100716pgc.319.1525675166201; Sun, 06 May 2018 23:39:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525675166; cv=none; d=google.com; s=arc-20160816; b=JS+EJVi4Tw13mY5IukOIvaFGjuz2TeAPhtUtlxMgkN8XTVa4+8vL2MeD3NrnfflRhL qOFzrL5oTwLCn7uGdWsJFYkqGVSvqg5rE3Uc5RkuA0or9s3txcD/J8fURyVT9e5R0/Hm r+4fK2X3csyfwBFo798UknlF3m/yG3jjRLiF01d+gExCMDdctBckWdAc/FYsPTpNErei 3ZrlWWh3uAvbQq68qQz1uxkhJ1/xNtqQb9cEpG5ptbg1mPExLJypr8C2lXf+XsTNd5lv sR5sShOeV1PNMD+XTBgiP5OV2mYVma+6gk4kmo4rs3aHsUd6u5bSk2s0/erdk+pTy6Iv j/eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature:dkim-filter :arc-authentication-results; bh=URcynVnwcH8qclcAx3hNtg0MWwPCU9ZGJWX6OjwciGw=; b=BZro6n7AjLbTdykw2jS8VWS3QoxXnUSSUz+/lEt+IQI0WMkrmgyxzQXv/fOIJns7E3 lVjKd6FBuCxWUXGvOFOOUK97FRfm9c8Zn/nkJhySSY2+n0+KhXhkyNKW4vvxbG1PR9yv CrGC0DlBI5h7hfG7Zonlad/lQLrzsytjdhYFfRdW1BgZyx5qxGirpYe9JKcZZ7CNjbcl FKhn1dOBFseIj7JCS2Vuyt6YlEKa0anLfnQtnfuZoTUNzGjuzZfc3lZdFRHUQ2tuDJuA Q9bT8uYD6uc4nEcDMUGJ1GKiFHwNDgzuRJMPUtiD3GUY9I9i7SmFAAm6qTH2hPAQKk1J NpyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=dAy/qovq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t126si22399517pfd.55.2018.05.06.23.39.11; Sun, 06 May 2018 23:39:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=dAy/qovq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbeEGGix (ORCPT + 99 others); Mon, 7 May 2018 02:38:53 -0400 Received: from conssluserg-02.nifty.com ([210.131.2.81]:65015 "EHLO conssluserg-02.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135AbeEGGiw (ORCPT ); Mon, 7 May 2018 02:38:52 -0400 Received: from mail-ua0-f174.google.com (mail-ua0-f174.google.com [209.85.217.174]) (authenticated) by conssluserg-02.nifty.com with ESMTP id w476ciEA003140; Mon, 7 May 2018 15:38:45 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com w476ciEA003140 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1525675125; bh=URcynVnwcH8qclcAx3hNtg0MWwPCU9ZGJWX6OjwciGw=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=dAy/qovq1dUqqAEbncsStgXtdVYV7qsoc3/XRiTf8UjCEuV2ofxn3DeZ4dBqTQC/q q8zCKk2KJNXvbK8ZAY/Ea4zqs4iQemQASQQK6dK+yml7aT0eFie9so8HUQ1leceraG whOFQ+M8oQ/C0Wn3sXpUCdrWwGNvesWdrGe01TFN5f+BFlgOETziWjv65WBd9Bef8a 9uHFdnLMCfnvaQxTAReXYecUyS04LGN5tv/4fAa+2T4QQ3XeTfIBcDcmyTmnc4UN10 auJAjcDIsZbLASdUFmUBVtMz07QvHOGOby6yToqqDa2hGLfTvODKUX7qyXBOZ5KGFd fnbcEVehn7yPQ== X-Nifty-SrcIP: [209.85.217.174] Received: by mail-ua0-f174.google.com with SMTP id f22so17670695uam.1; Sun, 06 May 2018 23:38:44 -0700 (PDT) X-Gm-Message-State: ALQs6tBakB7x64TLD8cLIGYQhGsWp8YN63IeyowFMSw5ssuzHLCFS+du FlxMfElx4QA6Z4remJaboP5QLwa71rqWqEESLjQ= X-Received: by 10.176.21.232 with SMTP id j37mr30975692uae.199.1525675123741; Sun, 06 May 2018 23:38:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.85.216 with HTTP; Sun, 6 May 2018 23:38:03 -0700 (PDT) In-Reply-To: <20180329180112.11055-3-labbott@redhat.com> References: <20180329180112.11055-1-labbott@redhat.com> <20180329180112.11055-3-labbott@redhat.com> From: Masahiro Yamada Date: Mon, 7 May 2018 15:38:03 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFCv2 PATCH 2/3] kbuild: Link with generated build-salt header To: Laura Abbott Cc: Andy Lutomirski , mjw@fedoraproject.org, "H . J . Lu" , Linus Torvalds , X86 ML , Linux Kernel Mailing List , Nick Clifton , Cary Coutant , Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2018-03-30 3:01 GMT+09:00 Laura Abbott : > diff --git a/scripts/build-salt.lds.S b/scripts/build-salt.lds.S > new file mode 100644 > index 000000000000..f85981f1187e > --- /dev/null > +++ b/scripts/build-salt.lds.S > @@ -0,0 +1,5 @@ > +#include > + > +SECTIONS { > + BUILD_ID_SALT > +} Do you need this just for wrapping ? How about generating scripts/build-salt.lds directly by scripts/gensalt ? is unneeded, then "some sporadic failures about missing the generated header" will be solved. I think something like follows will be simpler and better. always := $(hostprogs-y) $(hostprogs-m) build-salt.lds define filechk_build-salt.lds ($(CONFIG_SHELL) $(srctree)/scripts/gensalt $(CONFIG_BUILD_ID_SALT)) endef $(obj)/build-salt.lds: $(src)/gensalt FORCE $(call filechk,build-salt.lds) -- Best Regards Masahiro Yamada