Received: by 10.192.165.148 with SMTP id m20csp2825367imm; Mon, 7 May 2018 01:42:07 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoXCFWuHQCdUPFAmfMP/G1ZnJv0fEvxlAr2Fm904YUDndNjcZ66hVdICf21MnA6Ea1nzNED X-Received: by 2002:a63:203:: with SMTP id 3-v6mr22618382pgc.133.1525682527173; Mon, 07 May 2018 01:42:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525682527; cv=none; d=google.com; s=arc-20160816; b=HOVpT3k3fKVKhZ2U9xWUGqMmTUIQLRwAFKP7A9MzIwj+MreE6gGLawvqDwl6hM9NzI v4BIiEdhltF6aSzaUJRBz+mtbT2ZRa1kAuPpkmYiEKjqj0nk1rQhipq74XkRyGig409c ZVdLbEdjhT6h0AeaYej6+SaK9jpVXyPmZBktibKkwkiYnlPgNPFW+ZV09icgsLJI3g+s pFBakrL76cK/xUUSDIu0wyUxw6Z8LAdq6ABGz58gzyb3iFUFwhn9TXdTPAVAImkT1Gkf LFdUWHQr8LkpXlVcYq7G7cffpNZztfxjfkTnA5zDGoRsHI3cF50j/VD1uq0wZQzdlrIi i2lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XAqtlJKk0KFtCftADSZIIfBbqS7mvtSTKiWscehsItY=; b=hXEBDwostUDSTKzmXQ/+mGSEzSI9jsi0mJh7RDGOA7JdaDiVEwGQwTuDtj433PmSrb PXIIGIIBhBVGVmNJK8ri+GdL27TwEtcy++tc1LHEyDjc18OLra6ZYROezDtcn+MWPvVa tpWbr3CeRMalgeytZjcSnYGxHQkzn2c1InZtsS0JJvmMi3NE0e8XfS5xrYW9iB0P3m8r iyliwYrYKxBsLR73u21B4BklZ3qeAtOlY0bNdS1qflPZP5KV8yLfL8ui2UbvNgN7B2YU 31BQwecM3AvgFXctQuaSAsJp6q3iMrjZPVifQastLhU/Vrce006j0wmiamvu3AWqZfd0 Z7vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r5-v6si21688736plo.414.2018.05.07.01.41.53; Mon, 07 May 2018 01:42:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbeEGIlG (ORCPT + 99 others); Mon, 7 May 2018 04:41:06 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:44547 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbeEGIim (ORCPT ); Mon, 7 May 2018 04:38:42 -0400 Received: by mail-wr0-f193.google.com with SMTP id y15-v6so16122537wrg.11 for ; Mon, 07 May 2018 01:38:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XAqtlJKk0KFtCftADSZIIfBbqS7mvtSTKiWscehsItY=; b=GCtmgZh7Kf4XRTupla/HUDIzlWYIlDX2hJWxiqdcSPIxSHn8zQ93YyBEyNKFSqHsWZ 57lfC1mwpOGySL5wU+x1HZE5tdao0g+6mA6jXP24xIdFeKxE8VVstm5dYXbjMnbCACcT n2i05sR3giThuRkuUzUEXW+PCvFgL8IMkZzvCTtkXMu5JSMG8KERwZYv/a4qeefXUhoV EbrTFF8IRzdIdEJEGQYNI4bEOCXb3cDod5GmAMm9rpxeANVaauCdlHV6aB/doLe5VXed kPqkf4KYuO27bdWg+95WL3jevoAw+7rkor4Ole6sQkYJJsbyGCl4KreI5Elab+KDbQWG NeRw== X-Gm-Message-State: ALQs6tBP3HNfiuXa8smrVKNtV1o2uoIKXo7YC2c9Gb32aAJ7+a5gHTbm HuJiQu4DA6uyWZ/n9Dp14njstw== X-Received: by 2002:adf:e64b:: with SMTP id b11-v6mr28352908wrn.51.1525682320940; Mon, 07 May 2018 01:38:40 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (C2B0E321.catv.pool.telekom.hu. [194.176.227.33]) by smtp.gmail.com with ESMTPSA id h8-v6sm5908050wmc.16.2018.05.07.01.38.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 01:38:40 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Subject: [PATCH v2 25/35] Revert "ovl: fix may_write_real() for overlayfs directories" Date: Mon, 7 May 2018 10:37:57 +0200 Message-Id: <20180507083807.28792-26-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180507083807.28792-1-mszeredi@redhat.com> References: <20180507083807.28792-1-mszeredi@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 954c736f865d6c0c68ae4263a2f3502ee7c447a3. Overlayfs no longer relies on the vfs for checking writability of files. Signed-off-by: Miklos Szeredi --- fs/namespace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 5f75969adff1..c3f7152a8419 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -468,9 +468,7 @@ static inline int may_write_real(struct file *file) /* File refers to upper, writable layer? */ upperdentry = d_real(dentry, NULL, 0, D_REAL_UPPER); - if (upperdentry && - (file_inode(file) == d_inode(upperdentry) || - file_inode(file) == d_inode(dentry))) + if (upperdentry && file_inode(file) == d_inode(upperdentry)) return 0; /* Lower layer: can't write to real file, sorry... */ -- 2.14.3