Received: by 10.192.165.148 with SMTP id m20csp2826662imm; Mon, 7 May 2018 01:43:47 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpOWGleu9C5RITSPK0i7siKbrjnMcTH/hZhWk8evSySIR8cRw8t5n97kZRO5u+DdbMu6H+W X-Received: by 2002:a65:4ed0:: with SMTP id w16-v6mr12676822pgq.41.1525682627497; Mon, 07 May 2018 01:43:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525682627; cv=none; d=google.com; s=arc-20160816; b=Z6bLpAab45F+GFTnts8y3DmyEfPwrbiilBNSqDYnR8ub4XRtGZnGDC81zaMzghp8WQ oGFpqBs+gpJfrXeXmFQP13yawZwbuSFwluqUFomRUMEAVfxrzBonIT1VLo+C4BFZZ40I AWaMVFdlaZN4RTvnx3mui7ajWk390j5/OHH5dMwLXG8NxeGPLq15Z64Uvvxa6a5aqNon 8sehm0me447UbrrenXKoGXSKJNm/piiK5DKAXLtOU7zQCUlBnYybL3obN2rsW8k9kbf5 0y8EgbHQjQz9CBEm2an005GhhSjvdNsla0ogBaI2kxjY4l11ykxwFlxkMB7/ol5PnSBW 3XBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=V2OmmVFBuUSgQckE8B0XrGIAQg/4IsUcPqZSEaSvA5o=; b=ieP5dmGy2Pj4soxQf+ozsiBKckkoUBUCzOIOViEMfX5thScn8gwJiQBci/Zt3O60+t piWJ0A1nMfEjUR9mUpVFcHfH8aw6oVkD7/1VHpazrH8q++1IzsxgRR7CxGWmNr/VyY6d FDLxNlcYBqRgU3GdgGAYCIcO9qQDwpflLgbjMhhx91i4kiVg1ENpWbXjg97sfC4iIc7h prsuUopGjnhISu/W4GXAJsor1GIKqgTtI574trCw5ePKefKL2i0Ni3pqNZ9mB+Z7QXI8 insjknMUDUmk5qGJajitfFk1rBYQCJov95noX5ioNdogJp4pqvbHeRZURttVS1HWaEhz OyJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si21548827plv.217.2018.05.07.01.43.33; Mon, 07 May 2018 01:43:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752472AbeEGImw (ORCPT + 99 others); Mon, 7 May 2018 04:42:52 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:39059 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbeEGIii (ORCPT ); Mon, 7 May 2018 04:38:38 -0400 Received: by mail-wm0-f66.google.com with SMTP id f8-v6so13831512wmc.4 for ; Mon, 07 May 2018 01:38:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V2OmmVFBuUSgQckE8B0XrGIAQg/4IsUcPqZSEaSvA5o=; b=JroYFHqboSTBaXiw0nf9CcdY5mLTurL6ZJ7YzolJ2Db72dOOk0gjNygtWa4679JQrn 8TfIuaQQhrwFGZl0ZslZ3GDSisfK3ldlkfvwn5NGNtN8+elSCTlmuXI7wAoYpazsla0h sPM0b8o3R6aOEsN0LvCHVMWlbL2NTQ8vMOgRTAFBxbMRSizzJtRN/6XNJMqauGmLyhEY 9/xBkNUSD6ZBWqapKIYOeirVDzHo6SpOyeyxIt/GeB+7iANQv6AsmHDvQeeLRb2j+cLW xjfr7dWYW6w+Jw85BDUXCmlDtz50ySUrzCpDE+ThJu20qwMq+SFTMVbSEdjJEved6Hm1 uQOg== X-Gm-Message-State: ALKqPwdJgUrQ1W35Ec227XiLvXCmnPpotktieMf4GU4h7o8gHPMzsIdC 0OXLiMHbJbiwvE1wZzlt2nmjBQ== X-Received: by 2002:a1c:1a53:: with SMTP id a80-v6mr190238wma.36.1525682317608; Mon, 07 May 2018 01:38:37 -0700 (PDT) Received: from veci.piliscsaba.redhat.com (C2B0E321.catv.pool.telekom.hu. [194.176.227.33]) by smtp.gmail.com with ESMTPSA id h8-v6sm5908050wmc.16.2018.05.07.01.38.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 May 2018 01:38:37 -0700 (PDT) From: Miklos Szeredi To: linux-unionfs@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro Subject: [PATCH v2 22/35] vfs: don't open real Date: Mon, 7 May 2018 10:37:54 +0200 Message-Id: <20180507083807.28792-23-mszeredi@redhat.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180507083807.28792-1-mszeredi@redhat.com> References: <20180507083807.28792-1-mszeredi@redhat.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Let overlayfs do its thing when opening a file. This enables stacking and fixes the corner case when a file is opened for read, modified through a writable open, and data is read from the read-only file. After this patch the read-only open will not return stale data even in this case. Signed-off-by: Miklos Szeredi --- fs/open.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/open.c b/fs/open.c index 6e52fd6fea7c..244cd2ecfefd 100644 --- a/fs/open.c +++ b/fs/open.c @@ -897,13 +897,8 @@ EXPORT_SYMBOL(file_path); int vfs_open(const struct path *path, struct file *file, const struct cred *cred) { - struct dentry *dentry = d_real(path->dentry, NULL, file->f_flags, 0); - - if (IS_ERR(dentry)) - return PTR_ERR(dentry); - file->f_path = *path; - return do_dentry_open(file, d_backing_inode(dentry), NULL, cred); + return do_dentry_open(file, d_backing_inode(path->dentry), NULL, cred); } /** -- 2.14.3