Received: by 10.192.165.148 with SMTP id m20csp2866473imm; Mon, 7 May 2018 02:30:03 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqQEa3dK7bCgwPVAL8ej0XE7cweD6k0HqYzzWVOQ2CA4e/Rm7W/Cw9ALPq7smaVqKX22odI X-Received: by 2002:a17:902:7241:: with SMTP id c1-v6mr37725051pll.217.1525685403488; Mon, 07 May 2018 02:30:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525685403; cv=none; d=google.com; s=arc-20160816; b=iCwnxKhghFBX3F6c9a2iL7giSzmemvvQI6khFz+guVq8Y9PCAjv6cyb5kTEDFPr/Te EsLITJPcy2SsdlRg2tPSUK1oNgo+YzYlt/LuK80fkKX3Xc5YlvVmjhsL5xhroxNy4FfJ A+XAZWNcjkdkcTgpdEphs6nYxd6hwguGaeWhvsG3Nr+iBTSaYy6rE5BnDcf2PY8v7V6q G2btHrOiVdVS30OzcOFC7HeKMyj7lkUNywX2R9YciF89VbLVPqvP2VKZqZ+mW/ygF89D fo7H1scccpYjUXo3rhnBacLvGE4huhJ0YV/HVZ0hT8GJzhqVrYEIGVK46yZaFp1eJohm 1I4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=N9nNjgLucZ7BChHQjJOpASQArx0HpKdggfxTcN4wH+Q=; b=TKMcdrXaQ3W2Wz5WnS7figqZwzQ6UjC8skS49HW2v5ib5TBRQzLw9Rje5M2MZ9skjU MYSuI2fpE+ZdYF44NRYr8unUcBO/DOBjYZdjiQwTg6pQ+1R3YHxQ61jbRB4RwLwaO5vP Wa4DQMAybWapTpuzYz3I04OuigI1IUAIO40sLStfEhkDK3BnuXZWR1cPfL95hteWB3Ld pyBed6R+SJh8cjEQOIUU59uoMea0X+M6FTT4XHOHbd3ZXZBAWceKfrXsrlSO3GebaYKO 8c6Jhmo/hZ9ckt2X3nzhit0S6F4PSVYyQaMxajub1CAsrMSvOaan4UnhoYqpHJZVYEG5 pREw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g4-v6si22073915plb.522.2018.05.07.02.29.48; Mon, 07 May 2018 02:30:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752170AbeEGJ16 (ORCPT + 99 others); Mon, 7 May 2018 05:27:58 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:50064 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbeEGJ15 (ORCPT ); Mon, 7 May 2018 05:27:57 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fFcQz-00087g-6b; Mon, 07 May 2018 17:27:53 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fFcQu-0007OO-Nn; Mon, 07 May 2018 17:27:48 +0800 Date: Mon, 7 May 2018 17:27:48 +0800 From: Herbert Xu To: NeilBrown Cc: Thomas Graf , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] rhashtable: remove nulls_base and related code. Message-ID: <20180507092748.yqqldkwkxkynaaju@gondor.apana.org.au> References: <152540595840.18473.11298241115621799037.stgit@noble> <152540605427.18473.12277050439942480863.stgit@noble> <20180505091208.tnsxi6hdpjn456yz@gondor.apana.org.au> <877eoheqc2.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877eoheqc2.fsf@notabene.neil.brown.name> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 06, 2018 at 07:37:49AM +1000, NeilBrown wrote: > > I can see no evidence that this is required for anything, as it isn't > use and I'm fairly sure that in it's current form - it cannot be used. Search for nulls in net/ipv4. This is definitely used throughout the network stack. As the aim is to convert as many existing hash tables to rhashtable as possible, we want to keep this. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt