Received: by 10.192.165.148 with SMTP id m20csp2868870imm; Mon, 7 May 2018 02:32:34 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqOK11rLBgTDz6L0XL7Sxk+SnCzyUxQt57i6vQXlAkFIyP0gE+pzjxTqdNdct/PkF/rYLmy X-Received: by 2002:a17:902:b908:: with SMTP id bf8-v6mr36924032plb.358.1525685554849; Mon, 07 May 2018 02:32:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525685554; cv=none; d=google.com; s=arc-20160816; b=Kpa3iUcUUdZaObo8MF77bpq6NE+0WpnskwAG3BludW1ktIusVcfTX+P30bd/qr1KS8 KFn26iEa4Z9bXjrOmtHU/Rsyp572A88o2QsxM9AYj6clvuoQj9wP9QjZast6MPxUAhO5 OP5kpqz/P/P6vAHgStx+6E91cJsCA1eHbVujvrxZWBfNHm0cdan0lN4bTwJB3XxkOM0H mjHDdI2f7VbWab7ZV4VJYlXS9P5pbeiM94FG3aZsULyW31ayLNnMAcwdnZMbi6kVQcY2 FHAkFT7FB+AQs5TztuPvad0YTqvRIxxub60BHRRlKib7YYzt5SK07jsPn8NaLt19OMb3 9JEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qv1XBcY8lVQRJPuXYLXIhace7C8mJKze8DezYMmbHhw=; b=FsnfREti5ZtC4wKu8LmJ/cZqygzQnhAzIJVNUDdkOfQIuim1BkjWBDL7wG14Tcw3IE Y31WtTVXeY99I9BxLP0mgBWw5qM3hQ0Qnb5ZHCV902Y2dXTQdi0mWBt2qoCAfoWlkzde lvnWTJxN1H2fzgH6WH39tARkWbGe9H3Ix5OLgHb2/neqGWHzgS0Dbn9gSrxH4XdCq2S4 pT/ERqM+uSX3zUoLJLkDdC4SlNOFR5hWn2RoNaHy+qkjP93Rnm140Lhiaoq32THvcHLs vczgmIFXgEPwAjsuJiTLCbfbiZ4RLhV0csb5DPcyW/PlkDe2LcCjn3tTvIip3QKz/7vA eXqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14-v6si15254223plr.131.2018.05.07.02.32.20; Mon, 07 May 2018 02:32:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbeEGJaZ (ORCPT + 99 others); Mon, 7 May 2018 05:30:25 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:50156 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbeEGJaZ (ORCPT ); Mon, 7 May 2018 05:30:25 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fFcTL-0008CK-Sn; Mon, 07 May 2018 17:30:19 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fFcTL-0007P4-Jy; Mon, 07 May 2018 17:30:19 +0800 Date: Mon, 7 May 2018 17:30:19 +0800 From: Herbert Xu To: NeilBrown Cc: Thomas Graf , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/8] rhashtable: further improve stability of rhashtable_walk Message-ID: <20180507093019.qkz75qm7rocnbfnl@gondor.apana.org.au> References: <152540595840.18473.11298241115621799037.stgit@noble> <152540605438.18473.4797800779538116583.stgit@noble> <20180505094212.hpqjyv5ijibviuwh@gondor.apana.org.au> <87vac1db5t.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vac1db5t.fsf@notabene.neil.brown.name> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 06, 2018 at 07:50:54AM +1000, NeilBrown wrote: > > Do we? How could we fix it for both rhashtable and rhltable? Well I suggested earlier to insert the walker object into the hash table, which would be applicable regardless of whether it is a normal rhashtable of a rhltable. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt