Received: by 10.192.165.148 with SMTP id m20csp3074668imm; Mon, 7 May 2018 06:16:33 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpEz6WI+YZyE9TnH+pcN0jg+JDtS/NzkSYWuctC0hwYgrhy/NNj/HLfC99KoVpqvvcU2w6a X-Received: by 2002:a63:8f5b:: with SMTP id r27-v6mr20377549pgn.439.1525698993118; Mon, 07 May 2018 06:16:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525698993; cv=none; d=google.com; s=arc-20160816; b=H5xqCNhC6xTp0U0bfAkikyxE3hIi3K1eCjzXSu3FGPRC9D6jxMJ2a12bTTPh4Z/sg6 wEsxX63l5lCU3zKqQLP8gNgP/b5ZYRrC4iv39uFhGfiOO97aoaZhS0sf+zNDM4TTLOF+ CJx143CjKfLOKu/ithFHXYMbWoU1m88Dt6xPuSwxSnHjyIJZSsg2ez8wFAZDkaXeCTFE k3lsL/hTqAOlGpqG2RJqIDIJd0jY4XhzE+Hf2tLdzwwHEKDMD8Bo+q+TkrButeFQ/Gvn RsJgycLGPWfloL+SVNHqGlT/Tdmlv+g9aficls59BcEiAyxevlqLRFOsvzCw+UHDtiyP 1wmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ax3dDGdDrKwZbzAp5sZcMtFXW+Dcrcb9I2GjB7iDK10=; b=g9yMjmdzpKcDslcE9IDFFKWjbSmKWAGw1aHW7TX46PwAoJhLzCGEzVqXgUUKXxWoOm 9Q4+4H9R/cVo/pS0+sZ81lAWFdyOVNwlp58zGpFngRQXAIYZE5tQ6PHz1Ji3SQxzv89o sP3BB8LZbAems67iKy6BWEV37xLt/We3/yHEuFViLOS1+TSK72kJbQBdSPXxi5whaAb4 Bw8WFiBQI9FxvYEz1jdHx30Jzezj9LR9fF65cZ23QpjN6ZonJulqOqx+WUpeKGl0UN0o lLcKjRJiHrnRPH8U8ihFX0jYv8qYKG/yqEN+mr7XyqfBy3b0zh+JYxj557Vvjt4C2f8k WFag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XXMCGL9e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5-v6si14304958ple.417.2018.05.07.06.16.18; Mon, 07 May 2018 06:16:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XXMCGL9e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752366AbeEGNQC (ORCPT + 99 others); Mon, 7 May 2018 09:16:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:49524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbeEGNQA (ORCPT ); Mon, 7 May 2018 09:16:00 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C726E21788; Mon, 7 May 2018 13:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525698960; bh=A8tdTCZKtDUWHxrHJKALsDBLkMQVekdMVhi+XiAAHPo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XXMCGL9eBT2Q3Ibc15OC5nfMq+jMtPBxDqDlnJSKkZZwWlRP0NCwFFfPDnvvFzID+ mZMw5uQsKNu/vjtrHDAOYgx4rvwaZ5KBG5RMOSMse+vJ/57ue2aSMcvZMu7NHVy3vB gsT9iKxph05uE1gX/DwBVxuR2khhrYuonD3duTbo= Date: Sun, 6 May 2018 18:47:34 -0700 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , Lai Siyao , Jinshan Xiong , NeilBrown , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 4/4] staging: lustre: obdclass: change object lookup to no wait mode Message-ID: <20180507014734.GA7146@kroah.com> References: <1525285308-15347-1-git-send-email-jsimmons@infradead.org> <1525285308-15347-5-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1525285308-15347-5-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 02, 2018 at 02:21:48PM -0400, James Simmons wrote: > From: Lai Siyao > > Currently we set LU_OBJECT_HEARD_BANSHEE on object when we want > to remove object from cache, but this may lead to deadlock, because > when other process lookup such object, it needs to wait for this > object until release (done at last refcount put), while that process > maybe already hold an LDLM lock. > > Now that current code can handle dying object correctly, we can just > return such object in lookup, thus the above deadlock can be avoided. > > Signed-off-by: Lai Siyao > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-9049 > Reviewed-on: https://review.whamcloud.com/26965 > Reviewed-by: Alex Zhuravlev > Tested-by: Cliff White > Reviewed-by: Fan Yong > Reviewed-by: Oleg Drokin > Signed-off-by: James Simmons > --- > drivers/staging/lustre/lustre/include/lu_object.h | 2 +- > drivers/staging/lustre/lustre/obdclass/lu_object.c | 82 +++++++++------------- > 2 files changed, 36 insertions(+), 48 deletions(-) Patch does not apply to my tree :(