Received: by 10.192.165.148 with SMTP id m20csp3250717imm; Mon, 7 May 2018 09:04:50 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrfa/I1Wo0wey/hYmMieceAy5EHR0UgNU9kZwvjEaY/3Z9dd8FuqnJtTpif78aQ2FdjkBmH X-Received: by 2002:a24:5fca:: with SMTP id r193-v6mr212641itb.89.1525709090001; Mon, 07 May 2018 09:04:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525709089; cv=none; d=google.com; s=arc-20160816; b=qNBVsj9sJgEKNGLy2sH9XDNd3ZkjgGUZvutw7eAXgFd9C0lMtgTSPG20EJnObCWKTu cV1zIdEubY5I+ccp1q5mdpk02do9/purpb18I6cNViSWZVNoAKeGtei8tqZQWbU8X3D7 6eyR6FJZfDhg9EHcsCV3yrcF5kZVN7aBKVraorrRpcDL7aYJH3dPoWBIg1XAMq/jLu2a QUWBVRo6D0ODaZxcI3UgPABngzzleXXmGhAjHCjn/kXZIiXCeZSIz5VEvu5Ba/g+QAE2 pGGFH9oY68FsFZkSI+v5YbozDI3bdgCvbdj1Mp6Ie3zbpFSAhPNNGayqHv0cO2/4phtj WFjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=V8430Yf2cE0D7Zj6Fe/G9AoxLIg45KH53g7C0uu2RgQ=; b=F5cixu2ba+H2Rc4KzqIVTkwqSMJKPiXYssiF26NsRP9PMt9QmA14+3S4hO5J4rvPNP 7nEhr9GyBzGHrc9ODn6oFbzeFcUGsRgD6RRFV8vIUUOYB8oiGJUg+dxXvht94Sk4Sah/ IpORCE7nyPfyei1+gksqUiEAbZNd58qd+fvIHQFOfM1pmz7n7gBTomJ1d/wF6gpIm0Ac G1xLtELVkRz4TCeqccB5YRVvFp8mzhUZmEDXiUx6xYZvsuYCnKzc7LsTNsUJkuauZFWX woG5Ji3//y7Mh52ALfvz7FIK9FnBvxtUIp79OtRopedGnGIzPtXxZePyBdixwbWMPNN1 tLeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DK/+EfP3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j93-v6si20075822iod.207.2018.05.07.09.04.36; Mon, 07 May 2018 09:04:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DK/+EfP3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766AbeEGQEW (ORCPT + 99 others); Mon, 7 May 2018 12:04:22 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:35255 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752428AbeEGQEU (ORCPT ); Mon, 7 May 2018 12:04:20 -0400 Received: by mail-it0-f65.google.com with SMTP id q72-v6so2281397itc.0; Mon, 07 May 2018 09:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=V8430Yf2cE0D7Zj6Fe/G9AoxLIg45KH53g7C0uu2RgQ=; b=DK/+EfP37oD03rfMG5/+5KNwWe3kz04/Ue2WSkJaTt+sfnRI/zu8c98SMJXsvYdi8C f65/U/WDwK2/Zf0O28RFz38vlsQB23e35lJPJ08seFDNQbjEosHj6la5O9WP3ER7qxBj amYsYhdgUQfRgQmkDjA4aIU9raSTOatmQQC3xhzRdxk7m4h/PkzN9yicjheDaNg26atk 0eIoNBD0iTTS65oGv/V2Zddi4KYwd0gxMQx/zFe0j8XckcZxCuQK4UdzCqQi1nYnnxPh m/z8nJMeatekgTDF1zFdxMoj4c4RhCkdn07JH3ocK+UXPxWuRKwNkjXB+eVmM09m6uEb S57Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=V8430Yf2cE0D7Zj6Fe/G9AoxLIg45KH53g7C0uu2RgQ=; b=jzT7uRJVm+HzWPoRnUhnfJwmsaoIcYHV7vqNMq8pE+xritDkjcob9+XGKFeSmQBq0/ VNarhThmKfL4wm6Tso4KEoCa5wNsEYv2kh3/JpNZV4U8+KAi7wZnkXNmv4fViGjGI0um IrPf96owf/oecFBVHO601QOi37THQo5lyyaWeBTT+KRbUU8vm8OVh4NXHhd3VphgW3xD PYlWbBjg6xkSj9EsvG+KEKUKoMALNJ7cu2eeywnDUHw20k3OB+9Jqyu5nzUp8BcasNYQ ZrH46wJLLqZDEaNmSr9WZumV4Y71ZUMsT5cGd0EfKbGTnvTPNrlbUFqL7LPREn2oo9MN T98Q== X-Gm-Message-State: ALKqPwfL1z8Uea2njmC3PVwggC+Wv54isFLiLqGpaj35a5PmoxWbOt76 IMnzORsMVQzvUPt5903J9EAFhtz4eawmLcJBuxZiEA== X-Received: by 2002:a24:6d86:: with SMTP id m128-v6mr1881970itc.75.1525709059620; Mon, 07 May 2018 09:04:19 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:7109:0:0:0:0:0 with HTTP; Mon, 7 May 2018 09:03:58 -0700 (PDT) In-Reply-To: <20180507084240.GA26491@jamesdev> References: <20180507084240.GA26491@jamesdev> From: Matt Turner Date: Mon, 7 May 2018 09:03:58 -0700 Message-ID: Subject: Re: [PATCH v3 1/3] alpha: Use OPTIMIZE_INLINING instead of asm/compiler.h To: James Hogan Cc: linux-mips@linux-mips.org, Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , linux-alpha , linux-arch@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 7, 2018 at 1:42 AM, James Hogan wrote: > On Sun, May 06, 2018 at 12:33:21PM -0700, Matt Turner wrote: >> On Tue, Apr 17, 2018 at 3:11 AM, James Hogan wrote: >> > Use CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING and CONFIG_OPTIMIZE_INLINING >> > instead of undefining the inline macros in the alpha specific >> > asm/compiler.h. This is to allow asm/compiler.h to become a general >> > header that can be used for overriding linux/compiler*.h. >> > >> > A build of alpha's defconfig on GCC 7.3 before and after this series >> > (i.e. this commit and "compiler.h: Allow arch-specific overrides" which >> > includes asm/compiler.h from linux/compiler_types.h) results in the >> > following size differences, which appear harmless to me: >> > >> > $ ./scripts/bloat-o-meter vmlinux.1 vmlinux.2 >> > add/remove: 1/1 grow/shrink: 3/0 up/down: 264/-348 (-84) >> > Function old new delta >> > cap_bprm_set_creds 1496 1664 +168 >> > cap_issubset - 68 +68 >> > flex_array_put 328 344 +16 >> > cap_capset 488 500 +12 >> > nonroot_raised_pE.constprop 348 - -348 >> > Total: Before=5823709, After=5823625, chg -0.00% >> > >> > Suggested-by: Arnd Bergmann >> > Signed-off-by: James Hogan >> > Cc: Richard Henderson >> > Cc: Ivan Kokshaysky >> > Cc: Matt Turner >> > Cc: linux-alpha@vger.kernel.org >> >> Looks fine to me. >> >> Acked-by: Matt Turner > > Thanks > >> >> Should I take it through the alpha tree? > > I'll take all 3 through the MIPS tree if thats okay with you, as its a > prerequisite to allowing MIPS to override stuff in linux/compiler-gcc.h > using asm/compiler.h, which is needed to fix build breakage in 4.17. Thanks. That works for me.