Received: by 10.192.165.148 with SMTP id m20csp3257055imm; Mon, 7 May 2018 09:10:21 -0700 (PDT) X-Google-Smtp-Source: AB8JxZoH+wcptmc0peYZJIZJi1aewx9V5v9x+hRgWyKEBW5oK09kw+j+cYw76/eGtoneAhwBmRfc X-Received: by 2002:a24:a342:: with SMTP id p63-v6mr1869287ite.146.1525709421817; Mon, 07 May 2018 09:10:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525709421; cv=none; d=google.com; s=arc-20160816; b=YWdq5s/HZYU4m9lbzD7fEW1UIcUQ+24Mwz0tpf6qKrpVBJi8WuuW+TB9OgBeCiBVqh GFz2MvKAHfrnn4EPkmdRHadpcaFkrkW9Lli7F9gPQYDx43ZlWjoPrGum64LOJFsUuCAJ 71/rOb0MhInVZEhT50/Jpoxkv5yZa07eEGglZaU9pY8WPImbQsvKe9Doi7eKxw8JG7uY TmHvz0vgB0VQOhqzJRLv++Uw+1hJi7LJRuK0DLRkZquRJa/Hd7jJMzrO8nATxyYaqXE7 fwD0mQo5mkHlA91FkZQ5ZGXvZ4RKr1WivRbHNQ/RtrHbIMHSoGiYfkGszRfjoVVcwri1 OPCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=nBorw2pDMF3hhUmL2BJ3KbuQlvrbIsbTTOpXm5HXWnY=; b=am1WQaEcaPFkvGOo2wMBS+duj1QnOA4bitaNH17wQhFB+8MWmqEq34gdv4IqCaAG3J VYuK8ha9fxtQ+7miVigcvnQ2nC4jJCGNk+9VDuQi1ICy75hHLhvo6hsdb5xGTG3Iewgr tLqnffJCFphc2huzHMspn7CllYbU6c22WmBuVG6vSWughnv2IApdpc9uj2QLJx5BYAzS EmnT1SegNSpCQXk+t5nb2OvRS+ZKhBTgybnD2kam/pCgD6Rsze0Wiawpblhrui/ZqRI9 Vfrl6VbA47tS6rCa5BKNYDIeJi9FmJ0meUAaQS1yzLXAI/lo9zidj9LAGH22Ixme7Yrp Y7mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z82-v6si21114725ioz.18.2018.05.07.09.10.07; Mon, 07 May 2018 09:10:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbeEGQHu (ORCPT + 99 others); Mon, 7 May 2018 12:07:50 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43142 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752751AbeEGQHs (ORCPT ); Mon, 7 May 2018 12:07:48 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w47FsF7v016100 for ; Mon, 7 May 2018 12:07:47 -0400 Received: from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 2htqm2q4wy-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 07 May 2018 12:07:47 -0400 Received: from localhost by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 May 2018 17:07:45 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 7 May 2018 17:07:42 +0100 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w47G7fFk7537000; Mon, 7 May 2018 16:07:41 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9505911C054; Mon, 7 May 2018 16:59:09 +0100 (BST) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6898A11C04A; Mon, 7 May 2018 16:59:08 +0100 (BST) Received: from localhost.endicott.ibm.com (unknown [9.60.15.245]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 7 May 2018 16:59:08 +0100 (BST) From: Nayna Jain To: linux-integrity@vger.kernel.org Cc: zohar@linux.vnet.ibm.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, jarkko.sakkinen@linux.intel.com, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, patrickc@us.ibm.com, Nayna Jain Subject: [PATCH v3 0/2] tpm: improving granularity in poll sleep times Date: Mon, 7 May 2018 12:07:31 -0400 X-Mailer: git-send-email 2.13.3 X-TM-AS-GCONF: 00 x-cbid: 18050716-0040-0000-0000-000004560695 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18050716-0041-0000-0000-000020FA4245 Message-Id: <20180507160733.8817-1-nayna@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-07_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805070162 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The existing TPM polling code sleeps in each loop iteration for time in msecs ranging from 1 msecs to 5 msecs. However, many of the TPM commands complete much faster, resulting in unnecessary delays. This set of patches identifies such iterations and optimizes the sleep time. The first patch replaces TPM_POLL_SLEEP with TPM_TIMEOUT_POLL and moves it from tpm_tis_core.c to tpm.h as an enum with value 1 msecs. The second patch further reduces the TPM poll sleep time in get_burstcount() and wait_for_tpm_stat() in tpm_tis_core.c by calling usleep_range() directly. The change is only in the polling time, and the maximum timeout is still maintained the same. Thus, it should not affect the overall existing behavior. Changelog: v3: tpm: reduce poll sleep time in tpm_transmit() * added testing platform information * updated patch description for more clarity on reasoning tpm: reduce polling time to usecs for even finer granularity * added testing platform information * added Jarkko's and Mimi's Reviewed-by v2: tpm: reduce poll sleep time in tpm_transmit() * merged previously defined two patches into this. * updated patch description as per Jarkko's feedback tpm: reduce polling time to usecs for even finer granularity * directly use usleep_range with finer granularity less than 1msec Nayna Jain (2): tpm: reduce poll sleep time in tpm_transmit() tpm: reduce polling time to usecs for even finer granularity drivers/char/tpm/tpm-interface.c | 2 +- drivers/char/tpm/tpm.h | 5 ++++- drivers/char/tpm/tpm_tis_core.c | 11 +++-------- 3 files changed, 8 insertions(+), 10 deletions(-) -- 2.13.3