Received: by 10.192.165.148 with SMTP id m20csp3786196imm; Mon, 7 May 2018 19:51:05 -0700 (PDT) X-Google-Smtp-Source: AB8JxZq4nEbg7ii7iOCPPyi10XNjSaywKlqmxWs3AF3VptJAdDtBLjUaG31DPc0M/gH6+06K2AkM X-Received: by 10.167.133.15 with SMTP id v15mr24443162pfn.144.1525747865891; Mon, 07 May 2018 19:51:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525747865; cv=none; d=google.com; s=arc-20160816; b=H0OPjZEPjtYrO3MgihHtGlOes4DLXD+pHDXXIsRbkAnks1pe7AIPgUdkeJJPJans9q rxhB9uMgSDg/RT6z5uCKXiJiUDJxr09Kw61Cu0WJq69K1O7Et7/6hO5liO4fW/IRURj7 e08+l8tgJ1h2bpCfNSQTDjlEP7uFwLsFFGWsgKRJu5bRZ4dLGw2li1metHzmF4xNE7DN b0TT1Jy/QC7oRsWf4SqRzJUk1Tx3b+8Ci8cUKOqJ6Qm6Uo7MbjOi0u671Mr5YRdATwry tPkvBsmY1y2B6UjyUoLfi6rB4Sky0V1PE1MjJYnglPNKmd43LaU53xlGkw7GdTFiC+yw EcaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=XXxDl7v41UQZ9lvzXg1YEbL8jlxZywOSJ8ZG4XN2BYA=; b=VCgHCmxK3XuJ9FyG/8fVUm4wQayzmScNMfb7H87cU+wGS4McH1fAFhkfnz+ovpInnN r5sPRnzIwnWY5qARB11pfq4vmWp1mDj0hzvr7iIHEJjJ3lKBvAydxGU2bYPGyYiSZQG5 w9vvdEulQ5bC1DAOzKZt7Ucu2VYG6LiolkxpQa/EH7u2ym4t8PD4BD4FkgFMAs7qsWbo yita1b7cHArPUIZJIrdPJU0zoypeNPwukwzP2knZ4K0tvr4YZJ6QNqReKxBGHjxxjkDg hxnisWtJ/Chsajj9/BHHSa1VzAwBBD46ZzCSPQo7LBOXKuvEZJTeW4Af48wCUgONKmeA Y3FQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ky8nAMCD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3-v6si22270621pld.309.2018.05.07.19.50.51; Mon, 07 May 2018 19:51:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ky8nAMCD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754025AbeEHCuE (ORCPT + 99 others); Mon, 7 May 2018 22:50:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:55218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753780AbeEHCuD (ORCPT ); Mon, 7 May 2018 22:50:03 -0400 Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0F2E21747 for ; Tue, 8 May 2018 02:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525747802; bh=dx+9hVG73m0xFOUUkwXPQG77vONKgKSd4v7NlBVdsMs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Ky8nAMCDoH6mmyX0E0F4onFpOrY+d2VDf3FfcSin+xyLBE5+Ke0cGCOo9IE0MxYUe LLrwzZqzgWAcl0BYlQ+k+7wrSyJwHRmjshOS5PsnrvdOkvbNcfxj6OfnBFbOzYbKbW iST2CufVQD5UBsBWMDHMpnmg/6AYlruui0yOGbkg= Received: by mail-wr0-f175.google.com with SMTP id v5-v6so30652221wrf.9 for ; Mon, 07 May 2018 19:50:02 -0700 (PDT) X-Gm-Message-State: ALQs6tDYROF3C3yvdCQQZG/pF5eK/vaJ3yI6l9MOxyyWlxXotXB6HWwe D6HjRZ+VrZC/55hSNpQVdageOZduC+oNlu0qsCFbHw== X-Received: by 2002:adf:9c01:: with SMTP id f1-v6mr23332757wrc.171.1525747801125; Mon, 07 May 2018 19:50:01 -0700 (PDT) MIME-Version: 1.0 References: <20180329180112.11055-1-labbott@redhat.com> <1522413619.15770.88.camel@fedoraproject.org> In-Reply-To: From: Andy Lutomirski Date: Tue, 08 May 2018 02:49:50 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFCv2 PATCH 0/3] Salted build ids via linker sections To: Masahiro Yamada Cc: Mark Wielaard , Laura Abbott , Andrew Lutomirski , "H. J. Lu" , Linus Torvalds , X86 ML , LKML , Nick Clifton , Cary Coutant , linux-kbuild@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 6, 2018 at 11:59 PM Masahiro Yamada < yamada.masahiro@socionext.com> wrote: > 2018-03-30 21:40 GMT+09:00 Mark Wielaard : > > On Thu, 2018-03-29 at 11:01 -0700, Laura Abbott wrote: > >> I'm still mostly looking for feedback whether > >> this would be acceptable for merging or if we should just persue a > >> --build-id-salt in binutils. > > > > Personally I would go with this approach. It seems simple and it might > > take years before a new linker option is available everywhere. > Indeed. This series is easier than --build-id-salt. > If you do not see any better solution, I can accept this. > BTW, when I read > https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo > I thought "we could reverse the symlink direction from debug file to > build-id file)" > sensible (but I understand it is not easy to change this way). > If two packages share an identical image, > one package can borrow the image from the other, > then the storage space will be saved. > So, having identical ID should be advantage, > but we actually see only disadvantage... > > To simplify things I think you could just always add the extra vdso > > .comment initialized to something like KERNELRELEASE. Which distros > > seem to update anyway to include their build number, so they wouldn't > > need to do anything special to "update the build salt". > > That's what I was thinking, too. Would that solve Fedora's problem?