Received: by 10.192.165.148 with SMTP id m20csp3890038imm; Mon, 7 May 2018 22:23:45 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpvuTc086JVhs0dROV1CMKJc9lYIxocLlwAbE0u+05FvcGusx7w79KnglaNGm4iXFcv/09D X-Received: by 2002:a17:902:5409:: with SMTP id d9-v6mr13503638pli.1.1525757025640; Mon, 07 May 2018 22:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525757025; cv=none; d=google.com; s=arc-20160816; b=fcJisTSDtnFf/UUMcRkJTu7C0EcZAcsCsaqoRt+bCxMLNGDTQpBB3E9ldSGfW22J0J 2T9JTr2xXubU7XExn6ElXUkq3srR70gPnA3iJc1Co9VDebBIhAijI2vanw9eVxKrzGJI qT/PE6GzpvbETmdguEvuQvZRJYm05pwxlWnM9o781baSs9S4pANc0vHGL2FEXDTl+FLp Ww3adYtRHlnvqP2Ph8IAlHXgIt2kPqDcm2WwLya+34/lv8OufvvCZ+cT4QPVkMEmWriF AB+dlpGoh/S3lSe5OvbFziifcTyGB8xE0usTviVC31SFr4WTSGZJZrvWmmqKqNBKwWIt SBWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature:arc-authentication-results; bh=Q88Mh0jAHux9vVJv2OiFPq91KktdS7PCm5VusOhy/pI=; b=EF1cE/vBwhNETULJfBA0Xb0mBTiStn+Jut28WCCAYnqRAdcXFkZiLe4mDN8I2hOsAG h5hwiIWk0bt3zPvVvH+D0EaRdFzWbSBfXrdgw9YPW8D57jr0DWw08WcfeXGyuhYa47Xb Q9KDqspfWyBJ6OIJA1cfte5iSEqCuMdsXD4lyarDCAK4C3cJiBcocgtLy071IGMk54zA zQmZ4K74+O692E3tjThI7R1lYkLO1wlhDU9tMWUMvqDc0iPx9pzjBIQunIAMM7a5/XGu /57D5v1TRyTkl0kuf7HuAPI0lp+L3OG97UalAkNgFAhzvuFnVsjkGk6VGCJKTcvFWrqD YAxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=e9wtD5gs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v201-v6si18873552pgb.295.2018.05.07.22.23.28; Mon, 07 May 2018 22:23:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=e9wtD5gs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753540AbeEHFWF (ORCPT + 99 others); Tue, 8 May 2018 01:22:05 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51222 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbeEHFWE (ORCPT ); Tue, 8 May 2018 01:22:04 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w485M100090218; Tue, 8 May 2018 05:22:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2017-10-26; bh=Q88Mh0jAHux9vVJv2OiFPq91KktdS7PCm5VusOhy/pI=; b=e9wtD5gsXkBVbZsgx7RqUKDdiE1QkyfAqcMLmH3dxZfDvKQND/sdhTE9k7MlSdcuvSjl bKcIrGWEz6/53/9EVRsQ6CLNoRIGko8kKo8VB8/bMSXlYeDOyeaWWfPkpzlY9WiU+IoI sDmqFhE30bfhzqpEcned4de7ypNyCRzD2hOq5VGuoWMt1FKGawDrbTHJDidCEIxzn9Ra THXl/4y8vHaBom6hVuTlOyL5Yi6g4VXNMow0PCXr03UQDrDwYZCy/SR3xXW4h+nxgeEb AkF9WEoDP2kt47ZPcef/YFEGqBQ8sRYNk03tkrbv3ZWjsf++/kSMJYKKFH+P7xBycAzh uQ== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2hs426ewx8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 May 2018 05:22:00 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w485Lx5l024948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 May 2018 05:22:00 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w485LxPB015834; Tue, 8 May 2018 05:21:59 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 07 May 2018 22:21:59 -0700 To: Luc Van Oostenryck Cc: linux-kernel@vger.kernel.org, Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: Re: [PATCH] mptlan: fix mpt_lan_sdu_send()'s return type From: "Martin K. Petersen" Organization: Oracle Corporation References: <20180424131558.3010-1-luc.vanoostenryck@gmail.com> Date: Tue, 08 May 2018 01:21:56 -0400 In-Reply-To: <20180424131558.3010-1-luc.vanoostenryck@gmail.com> (Luc Van Oostenryck's message of "Tue, 24 Apr 2018 15:15:58 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8886 signatures=668698 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=319 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805080052 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luc, > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. You forgot to update the function prototype accordingly. -- Martin K. Petersen Oracle Linux Engineering