Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naga Sureshkumar Relli <nagasure@xilinx.com>
To:     Julia Cartwright <julia@ni.com>
CC:     "nagasureshkumarrelli@gmail.com" <nagasureshkumarrelli@gmail.com>,
        "boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "alexandre.belloni@free-electrons.com" 
        <alexandre.belloni@free-electrons.com>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "ladis@linux-mips.org" <ladis@linux-mips.org>,
        "ada@thorsis.com" <ada@thorsis.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [LINUX PATCH v8 2/2] memory: pl353: Add driver for arm pl353
 static memory controller
Thread-Topic: [LINUX PATCH v8 2/2] memory: pl353: Add driver for arm pl353
 static memory controller
Thread-Index: AQHTu4GvmXFu5KnCoUisvmGJ5xXly6PvYMoAgDT38PCAAHfqAIAA5YRw
Date:   Tue, 8 May 2018 06:35:46 +0000
Message-ID: <BY2PR02MB1411D166CF8D31421D183A5DAF9A0@BY2PR02MB1411.namprd02.prod.outlook.com>
References: <1521024235-30374-1-git-send-email-nagasureshkumarrelli@gmail.com>
 <1521024274-30467-1-git-send-email-nagasureshkumarrelli@gmail.com>
 <20180403165042.GE7654@jcartwri.amer.corp.natinst.com>
 <BY2PR02MB1411FA717E8DFB244F9B7976AF9B0@BY2PR02MB1411.namprd02.prod.outlook.com>
 <20180507165248.GK967@jcartwri.amer.corp.natinst.com>
In-Reply-To: <20180507165248.GK967@jcartwri.amer.corp.natinst.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8842a793-749c-436d-91cb-08d5b4adee48
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2018 06:35:46.0524
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB1378
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Julia Cartwright [mailto:julia@ni.com]
> Sent: Monday, May 7, 2018 10:23 PM
> To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> Cc: nagasureshkumarrelli@gmail.com; boris.brezillon@bootlin.com; rogerq@t=
i.com;
> lee.jones@linaro.org; alexandre.belloni@free-electrons.com; nicolas.ferre=
@microchip.com;
> ladis@linux-mips.org; ada@thorsis.com; linux-kernel@vger.kernel.org
> Subject: Re: [LINUX PATCH v8 2/2] memory: pl353: Add driver for arm pl353=
 static
> memory controller
>=20
> On Mon, May 07, 2018 at 10:12:28AM +0000, Naga Sureshkumar Relli wrote:
> > Hi Julia,
> >
> > Thanks for reviewing the patch and Sorry for my late reply. This patch
> > went to junk folder, hence I didn't catch this patch.
> >
> > From: Julia Cartwright [mailto:julia@ni.com]
> [..]
> > >
> > > It would be easier to follow if you constructed your two patchsets
> > > with git format-patch -- thread.
> > >
> >
> > I am using the same but with out --thread.
> >
> > > Or, merge them into a single patchset, especially considering the dep=
endency between
> patches.
> >
> > But both are different patches, one for Device tree documentation and o=
ther for driver
> update.
>=20
> Yes, I'm not proposing you merge _patches_ but _patchsets_.  You have two=
 patchsets, one for
> the SMC driver, and another for the NAND.  Given that they depend on one =
another, it's
> helpful for reviewers if you sent them all together, with a cover letter =
which describes the
> entire patchset, changelog, it's dependencies, revision changelog, etc.
>=20
> Something like:
>=20
>    [PATCH v9 0/4] rawnand: memory: add support for PL353 static memory co=
ntroller +
> NAND
>       [PATCH v9 1/4] Devicetree: Add pl353 smc controller devicetree bind=
ing information
>       [PATCH v9 2/4] memory: pl353: Add driver for arm pl353 static memor=
y controller
>       [PATCH v9 3/4] Documentation: nand: pl353: Add documentation for co=
ntroller and
> driver
>       [PATCH v9 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 =
smc nand interface
>=20
> Anyway, just with --thread enabled would be an improvement.
Ok. Got it. But both are different layers hence I sent like that.

>=20
> [..]
> > > > --- a/drivers/memory/Kconfig
> > > > +++ b/drivers/memory/Kconfig
> > > > @@ -152,6 +152,13 @@ config DA8XX_DDRCTL
> > > >  	  This driver is for the DDR2/mDDR Memory Controller present on
> > > >  	  Texas Instruments da8xx SoCs. It's used to tweak various memory
> > > >  	  controller configuration options.
> > > > +config PL35X_SMC
> > > > +	bool "ARM PL35X Static Memory Controller(SMC) driver"
> > >
> > > Is there any reason why this can't be tristate?
> >
> > There is a Nand driver which uses this driver. i.e The NAND driver
> > Depends on this driver.
>=20
> That's true, but it's irrelevant to question I asked.  It is perfectly va=
lid for both the SMC and
> NAND drivers to be tristate, why are you not allowing this configuration?
Yes, I will update it in next version of patch set.

Thanks,
Naga Sureshkumar Relli
>=20
>    Julia